mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:20:10 +01:00
Jon Ross-PerkinsandChandler Carruth
7befe2ce9f
This switches most error printing to use diagnostics instead of direct stream writes, even when not a specific file diagnostic. I'm allowing empty filenames for this use-case. This allows a little more specific testing to validate coverage of output using the diagnostic coverage test. I'm adding a few tests to cover things that weren't previously tested. Separately, this also forces a little more standardization in format... considering how changes like #4568 show effort being spent to _mirror_ diagnostic style, my thought is now to just use diagnostic code where possible. Note this also allows incrementally better testing of the language server; I'm changing the crash fix from #4847 in favor of diagnostic testing. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
38 lines
1.3 KiB
C++
38 lines
1.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_DIAGNOSTICS_FILE_DIAGNOSTICS_H_
|
|
#define CARBON_TOOLCHAIN_DIAGNOSTICS_FILE_DIAGNOSTICS_H_
|
|
|
|
#include "toolchain/diagnostics/diagnostic_emitter.h"
|
|
|
|
namespace Carbon {
|
|
|
|
// We frequently want a `DiagnosticEmitter` that directly uses a filename. Note
|
|
// that an empty string can be used for a diagnostic that has no particular
|
|
// location.
|
|
//
|
|
// Note this provides no way to set a line or column on diagnostics. More
|
|
// specific emitters must be used for that.
|
|
class FileDiagnosticEmitter : public DiagnosticEmitter<llvm::StringRef> {
|
|
public:
|
|
explicit FileDiagnosticEmitter(DiagnosticConsumer* consumer)
|
|
: DiagnosticEmitter<llvm::StringRef>(converter_, *consumer) {}
|
|
|
|
private:
|
|
// Converts a filename directly to the diagnostic location.
|
|
struct FileDiagnosticConverter : DiagnosticConverter<llvm::StringRef> {
|
|
auto ConvertLoc(llvm::StringRef filename, ContextFnT /*context_fn*/) const
|
|
-> ConvertedDiagnosticLoc override {
|
|
return {.loc = {.filename = filename}, .last_byte_offset = -1};
|
|
}
|
|
};
|
|
|
|
FileDiagnosticConverter converter_;
|
|
};
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_DIAGNOSTICS_FILE_DIAGNOSTICS_H_
|