mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-PerkinsandChandler Carruth
7befe2ce9f
This switches most error printing to use diagnostics instead of direct stream writes, even when not a specific file diagnostic. I'm allowing empty filenames for this use-case. This allows a little more specific testing to validate coverage of output using the diagnostic coverage test. I'm adding a few tests to cover things that weren't previously tested. Separately, this also forces a little more standardization in format... considering how changes like #4568 show effort being spent to _mirror_ diagnostic style, my thought is now to just use diagnostic code where possible. Note this also allows incrementally better testing of the language server; I'm changing the crash fix from #4847 in favor of diagnostic testing. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
57 lines
1.9 KiB
C++
57 lines
1.9 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "absl/flags/flag.h"
|
|
#include "toolchain/diagnostics/diagnostic_kind.h"
|
|
#include "toolchain/testing/coverage_helper.h"
|
|
|
|
ABSL_FLAG(std::string, testdata_manifest, "",
|
|
"A path to a file containing repo-relative names of test files.");
|
|
|
|
namespace Carbon {
|
|
namespace {
|
|
|
|
constexpr DiagnosticKind DiagnosticKinds[] = {
|
|
#define CARBON_DIAGNOSTIC_KIND(Name) DiagnosticKind::Name,
|
|
#include "toolchain/diagnostics/diagnostic_kind.def"
|
|
};
|
|
|
|
constexpr DiagnosticKind UntestedDiagnosticKinds[] = {
|
|
// These exist only for unit tests.
|
|
DiagnosticKind::TestDiagnostic,
|
|
DiagnosticKind::TestDiagnosticNote,
|
|
|
|
// Diagnosing erroneous install conditions, but test environments are
|
|
// typically correct.
|
|
DiagnosticKind::CompilePreludeManifestError,
|
|
DiagnosticKind::DriverInstallInvalid,
|
|
|
|
// These diagnose filesystem issues that are hard to unit test.
|
|
DiagnosticKind::ErrorReadingFile,
|
|
DiagnosticKind::ErrorStattingFile,
|
|
DiagnosticKind::FileTooLarge,
|
|
|
|
// These aren't feasible to test with a normal testcase, but are tested in
|
|
// lex/tokenized_buffer_test.cpp.
|
|
DiagnosticKind::TooManyTokens,
|
|
DiagnosticKind::UnsupportedCRLineEnding,
|
|
DiagnosticKind::UnsupportedLFCRLineEnding,
|
|
|
|
// This is a little long but is tested in lex/numeric_literal_test.cpp.
|
|
DiagnosticKind::TooManyDigits,
|
|
};
|
|
|
|
// Looks for diagnostic kinds that aren't covered by a file_test.
|
|
TEST(Coverage, DiagnosticKind) {
|
|
Testing::TestKindCoverage(absl::GetFlag(FLAGS_testdata_manifest),
|
|
R"(^ *// CHECK:STDERR: .* \[(\w+)\]$)",
|
|
llvm::ArrayRef(DiagnosticKinds),
|
|
llvm::ArrayRef(UntestedDiagnosticKinds));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon
|