mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:30:12 +01:00
Jon Ross-PerkinsandChandler Carruth
7befe2ce9f
This switches most error printing to use diagnostics instead of direct stream writes, even when not a specific file diagnostic. I'm allowing empty filenames for this use-case. This allows a little more specific testing to validate coverage of output using the diagnostic coverage test. I'm adding a few tests to cover things that weren't previously tested. Separately, this also forces a little more standardization in format... considering how changes like #4568 show effort being spent to _mirror_ diagnostic style, my thought is now to just use diagnostic code where possible. Note this also allows incrementally better testing of the language server; I'm changing the crash fix from #4847 in favor of diagnostic testing. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
162 lines
3.5 KiB
Python
162 lines
3.5 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
|
|
load("//bazel/manifest:defs.bzl", "manifest")
|
|
|
|
package(default_visibility = ["//visibility:public"])
|
|
|
|
filegroup(
|
|
name = "testdata",
|
|
data = glob(["testdata/**/*.carbon"]),
|
|
)
|
|
|
|
cc_library(
|
|
name = "diagnostic_emitter",
|
|
srcs = [
|
|
"diagnostic.cpp",
|
|
"diagnostic_consumer.cpp",
|
|
],
|
|
hdrs = [
|
|
"diagnostic.h",
|
|
"diagnostic_consumer.h",
|
|
"diagnostic_converter.h",
|
|
"diagnostic_emitter.h",
|
|
],
|
|
deps = [
|
|
":diagnostic_kind",
|
|
":format_providers",
|
|
"//common:check",
|
|
"//common:ostream",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "diagnostic_emitter_test",
|
|
size = "small",
|
|
srcs = ["diagnostic_emitter_test.cpp"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
":mocks",
|
|
"//testing/base:gtest_main",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "diagnostic_kind",
|
|
srcs = ["diagnostic_kind.cpp"],
|
|
hdrs = ["diagnostic_kind.h"],
|
|
textual_hdrs = [
|
|
"diagnostic_kind.def",
|
|
],
|
|
deps = [
|
|
"//common:enum_base",
|
|
],
|
|
)
|
|
|
|
manifest(
|
|
name = "all_testdata.txt",
|
|
srcs = ["//toolchain/testing:all_testdata"],
|
|
)
|
|
|
|
cc_test(
|
|
name = "coverage_test",
|
|
size = "small",
|
|
srcs = ["coverage_test.cpp"],
|
|
args = ["--testdata_manifest=$(location :all_testdata.txt)"],
|
|
data = [
|
|
":all_testdata.txt",
|
|
"//toolchain/testing:all_testdata",
|
|
],
|
|
deps = [
|
|
":diagnostic_kind",
|
|
"//testing/base:gtest_main",
|
|
"//toolchain/testing:coverage_helper",
|
|
"@abseil-cpp//absl/flags:flag",
|
|
"@googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "file_diagnostics",
|
|
hdrs = ["file_diagnostics.h"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "format_providers",
|
|
srcs = ["format_providers.cpp"],
|
|
hdrs = ["format_providers.h"],
|
|
deps = [
|
|
"//common:check",
|
|
"//common:ostream",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "format_providers_test",
|
|
size = "small",
|
|
srcs = ["format_providers_test.cpp"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
":format_providers",
|
|
":mocks",
|
|
"//testing/base:gtest_main",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "null_diagnostics",
|
|
hdrs = ["null_diagnostics.h"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "sorting_diagnostic_consumer",
|
|
hdrs = ["sorting_diagnostic_consumer.h"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
"//common:check",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "sorting_diagnostic_consumer_test",
|
|
size = "small",
|
|
srcs = ["sorting_diagnostic_consumer_test.cpp"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
":mocks",
|
|
":sorting_diagnostic_consumer",
|
|
"//testing/base:gtest_main",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "mocks",
|
|
testonly = 1,
|
|
srcs = ["mocks.cpp"],
|
|
hdrs = ["mocks.h"],
|
|
deps = [
|
|
":diagnostic_emitter",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|