carbon-lang

carbon-language/carbon-lang

Fork 0

mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 21:20:11 +01:00

Files

T

History

Jon Ross-PerkinsandChandler Carruth 7befe2ce9f Switch custom error stream output to diagnostic (#4846 )

This switches most error printing to use diagnostics instead of direct
stream writes, even when not a specific file diagnostic. I'm allowing
empty filenames for this use-case.

This allows a little more specific testing to validate coverage of
output using the diagnostic coverage test. I'm adding a few tests to
cover things that weren't previously tested.

Separately, this also forces a little more standardization in format...
considering how changes like #4568 show effort being spent to _mirror_
diagnostic style, my thought is now to just use diagnostic code where
possible.

Note this also allows incrementally better testing of the language
server; I'm changing the crash fix from #4847 in favor of diagnostic
testing.

---------

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>

2025-01-30 01:58:07 +00:00

fuzzer_corpus

…

testdata

Switch custom error stream output to diagnostic (#4846 )

2025-01-30 01:58:07 +00:00

BUILD

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

call.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

call.h

Use As and ImplicitAs interfaces for conversions. (#4209 )

2024-09-05 23:39:58 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849 )

2025-01-27 23:48:44 +00:00

check_unit.cpp

Switch custom error stream output to diagnostic (#4846 )

2025-01-30 01:58:07 +00:00

check_unit.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

check.cpp

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

check.h

Generate AST when importing a cpp file (#4790 )

2025-01-14 20:45:50 +00:00

context.cpp

Switch custom error stream output to diagnostic (#4846 )

2025-01-30 01:58:07 +00:00

context.h

Switch custom error stream output to diagnostic (#4846 )

2025-01-30 01:58:07 +00:00

convert.cpp

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

convert.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

decl_introducer_state.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

decl_name_stack.cpp

Change DeclNameStack::LookupOrAddName() to return SemIR::ScopeLookupResult instead of a pair (#4852 )

2025-01-28 21:36:20 +00:00

decl_name_stack.h

Return the NameId for a new instruction regardless if it's unresolved because it's poisoned or not (#4861 )

2025-01-29 14:20:05 +00:00

deduce.cpp

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

deduce.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

deferred_definition_worklist.cpp

Split deferred node traversal out from check.cpp (#4559 )

2024-11-20 20:58:58 +00:00

deferred_definition_worklist.h

Split deferred node traversal out from check.cpp (#4559 )

2024-11-20 20:58:58 +00:00

diagnostic_helpers.h

Make SemIRLoc data private to diagnostics (#4867 )

2025-01-29 20:46:30 +00:00

dump.cpp

Clean up a few details of lex yaml printing (#4845 )

2025-01-24 21:52:02 +00:00

eval.cpp

Make SemIRLoc data private to diagnostics (#4867 )

2025-01-29 20:46:30 +00:00

eval.h

Produce a note indicating where the specific was used from if monomorphization fails. (#4662 )

2024-12-11 22:34:10 +00:00

full_pattern_stack.h

Use FullPatternStack instead of node stack for binding context (#4829 )

2025-01-23 17:25:31 +00:00

function.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

function.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

generic_region_stack.cpp

…

generic_region_stack.h

…

generic.cpp

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

generic.h

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

global_init.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

global_init.h

…

handle_alias.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

handle_array.cpp

Finish removing BuiltinInstKind (#4637 )

2024-12-05 22:07:51 +00:00

handle_binding_pattern.cpp

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

handle_call_expr.cpp

Include the call arguments in the location of a call. (#4602 )

2024-12-02 18:51:44 +00:00

handle_choice.cpp

…

handle_class.cpp

Clean up obsolete import handling in class/function (#4857 )

2025-01-28 22:49:03 +00:00

handle_codeblock.cpp

…

handle_export.cpp

Wrap lookup result in a new ScopeLookupResult (#4831 )

2025-01-27 10:05:23 +00:00

handle_expr_statement.cpp

…

handle_file.cpp

…

handle_function.cpp

Clean up obsolete import handling in class/function (#4857 )

2025-01-28 22:49:03 +00:00

handle_if_expr.cpp

Model type expressions as regions (#4698 )

2024-12-19 21:41:06 +00:00

handle_if_statement.cpp

Model type expressions as regions (#4698 )

2024-12-19 21:41:06 +00:00

handle_impl.cpp

Stop allowing impl redeclarations to differ syntactically in where clause (#4850 )

2025-01-28 06:00:34 +00:00

handle_import_and_package.cpp

Implement 'extern library' support for functions. (#4220 )

2024-08-19 22:12:21 +00:00

handle_index.cpp

Finish removing BuiltinInstKind (#4637 )

2024-12-05 22:07:51 +00:00

handle_interface.cpp

Change DeclNameStack::LookupOrAddName() to return SemIR::ScopeLookupResult instead of a pair (#4852 )

2025-01-28 21:36:20 +00:00

handle_let_and_var.cpp

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

handle_literal.cpp

Finish removing BuiltinInstKind (#4637 )

2024-12-05 22:07:51 +00:00

handle_loop_statement.cpp

Model type expressions as regions (#4698 )

2024-12-19 21:41:06 +00:00

handle_match.cpp

…

handle_modifier.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

handle_name.cpp

Wrap lookup result in a new ScopeLookupResult (#4831 )

2025-01-27 10:05:23 +00:00

handle_named_constraint.cpp

…

handle_namespace.cpp

Change DeclNameStack::LookupOrAddName() to return SemIR::ScopeLookupResult instead of a pair (#4852 )

2025-01-28 21:36:20 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700 )

2024-12-18 00:19:12 +00:00

handle_operator.cpp

Late response to comments on #4698 (#4758 )

2025-01-07 17:44:34 +00:00

handle_paren_expr.cpp

…

handle_pattern_list.cpp

Use FullPatternStack instead of node stack for binding context (#4829 )

2025-01-23 17:25:31 +00:00

handle_return_statement.cpp

…

handle_struct.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

handle_tuple_literal.cpp

…

handle_where.cpp

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

handle.h

…

impl_lookup.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

impl_lookup.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

impl.cpp

Stop allowing impl redeclarations to differ syntactically in where clause (#4850 )

2025-01-28 06:00:34 +00:00

impl.h

Stop allowing impl redeclarations to differ syntactically in where clause (#4850 )

2025-01-28 06:00:34 +00:00

import_cpp.cpp

Clean up a few details of lex yaml printing (#4845 )

2025-01-24 21:52:02 +00:00

import_cpp.h

Support multiple import Cpp library in a single unit (#4814 )

2025-01-20 09:44:45 +00:00

import_ref.cpp

Wrap lookup result in a new ScopeLookupResult (#4831 )

2025-01-27 10:05:23 +00:00

import_ref.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

import.cpp

Wrap lookup result in a new ScopeLookupResult (#4831 )

2025-01-27 10:05:23 +00:00

import.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

inst_block_stack.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

inst_block_stack.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

interface.cpp

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

interface.h

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

keyword_modifier_set.h

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

lexical_lookup.h

Refactor value store code to use separate files. (#4477 )

2024-11-04 04:00:17 +00:00

literal.cpp

Finish removing BuiltinInstKind (#4637 )

2024-12-05 22:07:51 +00:00

literal.h

Factor out machinery for forming int type literals. (#4616 )

2024-12-03 18:46:27 +00:00

member_access.cpp

Wrap lookup result in a new ScopeLookupResult (#4831 )

2025-01-27 10:05:23 +00:00

member_access.h

Remove redundant optional wrapping llvm::function_ref (#4367 )

2024-10-07 17:25:35 +00:00

merge.cpp

Wrap lookup result in a new ScopeLookupResult (#4831 )

2025-01-27 10:05:23 +00:00

merge.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

modifiers.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

modifiers.h

Refactor modifier formatting to remove string passing. (#4418 )

2024-10-17 22:47:40 +00:00

name_component.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

name_component.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

node_id_traversal.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

node_id_traversal.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

node_stack.cpp

Remove verbose formatting of instructions on crash messages. (#4495 )

2024-11-07 16:22:36 +00:00

node_stack.h

Treat associated constants as entities parameterized by Self (#4837 )

2025-01-25 02:13:52 +00:00

operator.cpp

Remove InstId::Builtin members (#4632 )

2024-12-05 18:13:46 +00:00

operator.h

Remove redundant optional wrapping llvm::function_ref (#4367 )

2024-10-07 17:25:35 +00:00

param_and_arg_refs_stack.h

Update files and clang-tidy config to pass with clang-tidy-20 (#4691 )

2024-12-17 01:25:53 +00:00

pattern_match.cpp

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

pattern_match.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

pending_block.h

Enforce that the parse node for an instruction has the kind specified in the instruction definition (#4264 )

2024-08-29 21:10:14 +00:00

pointer_dereference.cpp

Switch TypeId::TypeType to TypeType::SingletonTypeId, and similar (#4619 )

2024-12-04 18:40:50 +00:00

pointer_dereference.h

…

return.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

return.h

Model var as a pattern operator (#4720 )

2025-01-17 17:51:34 +00:00

scope_index.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

scope_stack.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

scope_stack.h

Invalid comment cleanup (#4836 )

2025-01-23 02:21:48 +00:00

sem_ir_diagnostic_converter.cpp

Make SemIRLoc data private to diagnostics (#4867 )

2025-01-29 20:46:30 +00:00

sem_ir_diagnostic_converter.h

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

subst.cpp

Id::Invalid -> Id::None (#4834 )

2025-01-22 23:15:00 +00:00

subst.h

Basic support for implementing and using a parameterized interface. (#4203 )

2024-08-09 01:05:03 +00:00