mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:10:13 +01:00
Per recent discussion, in `... where .A = B`, require that `B` is implicitly convertible to the type of `A` immediately, rather than treating that as part of the criteria that a type must satisfy to satisfy the resulting constraint. Extend the implementation of implicit conversion so that conversion of a type to a constraint checks that the type satisfies the constraint. As part of implementing this, stop duplicating rewrite constraints as equality constraints. Instead, when checking that a constraint is satisfied, check both its equality constraints and its rewrite constraints. This fixes an infinite recursion that would otherwise be caused by this change, and is also a necessary prerequisite for applying rewrite constraints to equality constraints, where we would otherwise collapse the implied equality constraints to a tautological `V == V` constraint. In passing, make ErrorBuilder support building the error message more incrementally and use that to improve diagnostics for mismatched values with equality constraints.
194 lines
5.9 KiB
C++
194 lines
5.9 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_COMMON_ERROR_H_
|
|
#define CARBON_COMMON_ERROR_H_
|
|
|
|
#include <string>
|
|
#include <variant>
|
|
|
|
#include "common/check.h"
|
|
#include "common/ostream.h"
|
|
#include "llvm/ADT/Twine.h"
|
|
|
|
namespace Carbon {
|
|
|
|
// Success values should be represented as the presence of a value in ErrorOr,
|
|
// using `ErrorOr<Success>` and `return Success();` if no value needs to be
|
|
// returned.
|
|
struct Success {};
|
|
|
|
// Tracks an error message.
|
|
class [[nodiscard]] Error {
|
|
public:
|
|
// Represents an error state.
|
|
explicit Error(llvm::Twine location, llvm::Twine message)
|
|
: location_(location.str()), message_(message.str()) {
|
|
CARBON_CHECK(!message_.empty()) << "Errors must have a message.";
|
|
}
|
|
|
|
// Represents an error with no associated location.
|
|
// TODO: Consider using two different types.
|
|
explicit Error(llvm::Twine message) : Error("", message) {}
|
|
|
|
Error(Error&& other) noexcept
|
|
: location_(std::move(other.location_)),
|
|
message_(std::move(other.message_)) {}
|
|
|
|
// Prints the error string.
|
|
void Print(llvm::raw_ostream& out) const {
|
|
if (!location().empty()) {
|
|
out << location() << ": ";
|
|
}
|
|
out << message();
|
|
}
|
|
|
|
// Returns a string describing the location of the error, such as
|
|
// "file.cc:123".
|
|
auto location() const -> const std::string& { return location_; }
|
|
|
|
// Returns the error message.
|
|
auto message() const -> const std::string& { return message_; }
|
|
|
|
private:
|
|
// The location associated with the error.
|
|
std::string location_;
|
|
// The error message.
|
|
std::string message_;
|
|
};
|
|
|
|
// Holds a value of type `T`, or an Error explaining why the value is
|
|
// unavailable.
|
|
template <typename T>
|
|
class [[nodiscard]] ErrorOr {
|
|
public:
|
|
// Constructs with an error; the error must not be Error::Success().
|
|
// Implicit for easy construction on returns.
|
|
// NOLINTNEXTLINE(google-explicit-constructor)
|
|
ErrorOr(Error err) : val_(std::move(err)) {}
|
|
|
|
// Constructs with a value.
|
|
// Implicit for easy construction on returns.
|
|
// NOLINTNEXTLINE(google-explicit-constructor)
|
|
ErrorOr(T val) : val_(std::move(val)) {}
|
|
|
|
// Moves held state.
|
|
ErrorOr(ErrorOr&& other) noexcept : val_(std::move(other.val_)) {}
|
|
|
|
// Returns true for success.
|
|
auto ok() const -> bool { return std::holds_alternative<T>(val_); }
|
|
|
|
// Returns the contained error.
|
|
// REQUIRES: `ok()` is false.
|
|
auto error() const& -> const Error& {
|
|
CARBON_CHECK(!ok());
|
|
return std::get<Error>(val_);
|
|
}
|
|
auto error() && -> Error {
|
|
CARBON_CHECK(!ok());
|
|
return std::get<Error>(std::move(val_));
|
|
}
|
|
|
|
// Returns the contained value.
|
|
// REQUIRES: `ok()` is true.
|
|
auto operator*() -> T& {
|
|
CARBON_CHECK(ok());
|
|
return std::get<T>(val_);
|
|
}
|
|
|
|
// Returns the contained value.
|
|
// REQUIRES: `ok()` is true.
|
|
auto operator*() const -> const T& {
|
|
CARBON_CHECK(ok());
|
|
return std::get<T>(val_);
|
|
}
|
|
|
|
// Returns the contained value.
|
|
// REQUIRES: `ok()` is true.
|
|
auto operator->() -> T* {
|
|
CARBON_CHECK(ok());
|
|
return &std::get<T>(val_);
|
|
}
|
|
|
|
// Returns the contained value.
|
|
// REQUIRES: `ok()` is true.
|
|
auto operator->() const -> const T* {
|
|
CARBON_CHECK(ok());
|
|
return &std::get<T>(val_);
|
|
}
|
|
|
|
private:
|
|
// Either an error message or
|
|
std::variant<Error, T> val_;
|
|
};
|
|
|
|
// A helper class for accumulating error message and converting to
|
|
// `Error` and `ErrorOr<T>`.
|
|
class ErrorBuilder {
|
|
public:
|
|
explicit ErrorBuilder(std::string location = "")
|
|
: location_(std::move(location)),
|
|
out_(std::make_unique<llvm::raw_string_ostream>(message_)) {}
|
|
|
|
// Accumulates string message to a temporary `ErrorBuilder`. After streaming,
|
|
// the builder must be converted to an `Error` or `ErrorOr`.
|
|
template <typename T>
|
|
[[nodiscard]] auto operator<<(const T& message) && -> ErrorBuilder&& {
|
|
*out_ << message;
|
|
return std::move(*this);
|
|
}
|
|
|
|
// Accumulates string message for an lvalue error builder.
|
|
template <typename T>
|
|
auto operator<<(const T& message) & -> ErrorBuilder& {
|
|
*out_ << message;
|
|
return *this;
|
|
}
|
|
|
|
// NOLINTNEXTLINE(google-explicit-constructor): Implicit cast for returns.
|
|
operator Error() { return Error(location_, message_); }
|
|
|
|
template <typename T>
|
|
// NOLINTNEXTLINE(google-explicit-constructor): Implicit cast for returns.
|
|
operator ErrorOr<T>() {
|
|
return Error(location_, message_);
|
|
}
|
|
|
|
private:
|
|
std::string location_;
|
|
std::string message_;
|
|
// Use a pointer to allow move construction.
|
|
std::unique_ptr<llvm::raw_string_ostream> out_;
|
|
};
|
|
|
|
} // namespace Carbon
|
|
|
|
// Macro hackery to get a unique variable name.
|
|
#define CARBON_MAKE_UNIQUE_NAME_IMPL(a, b, c) a##b##c
|
|
#define CARBON_MAKE_UNIQUE_NAME(a, b, c) CARBON_MAKE_UNIQUE_NAME_IMPL(a, b, c)
|
|
|
|
#define CARBON_RETURN_IF_ERROR_IMPL(unique_name, expr) \
|
|
if (auto unique_name = (expr); /* NOLINT(bugprone-macro-parentheses) */ \
|
|
!(unique_name).ok()) { \
|
|
return std::move(unique_name).error(); \
|
|
}
|
|
|
|
#define CARBON_RETURN_IF_ERROR(expr) \
|
|
CARBON_RETURN_IF_ERROR_IMPL( \
|
|
CARBON_MAKE_UNIQUE_NAME(_llvm_error_line, __LINE__, __COUNTER__), expr)
|
|
|
|
#define CARBON_ASSIGN_OR_RETURN_IMPL(unique_name, var, expr) \
|
|
auto unique_name = (expr); /* NOLINT(bugprone-macro-parentheses) */ \
|
|
if (!(unique_name).ok()) { \
|
|
return std::move(unique_name).error(); \
|
|
} \
|
|
var = std::move(*(unique_name)); /* NOLINT(bugprone-macro-parentheses) */
|
|
|
|
#define CARBON_ASSIGN_OR_RETURN(var, expr) \
|
|
CARBON_ASSIGN_OR_RETURN_IMPL( \
|
|
CARBON_MAKE_UNIQUE_NAME(_llvm_expected_line, __LINE__, __COUNTER__), \
|
|
var, expr)
|
|
|
|
#endif // CARBON_COMMON_ERROR_H_
|