Files
carbon-lang/toolchain/parse/testdata/if/fail_else_unbraced.carbon
T
Chandler Carruth 2c9739799b Render diagnostics through the terminal library (#7683)
Diagnostic rendering was part of the data model: `Loc::FormatLocation`
and
`Loc::FormatSnippet` wrote plain text to a stream, so no capability,
color, or
terminal width could reach them.

A diagnostic is now one message with labels, contexts, and location
information
attached, and `Diagnostics::Renderer` draws it into a
`Terminal::Buffer`. The
design is in `toolchain/docs/diagnostics_rendering.md` (#7668),
authoring in
`toolchain/docs/diagnostics.md`.

Before:

```
example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments
  Run0(1);
  ^~~~~~~
example.carbon:3:1: note: calling function declared here
fn Run0() {}
^~~~~~~~~~~
```

After:

```
error: 1 argument passed to function expecting 0 arguments
       ╭─┤ example.carbon:6:3
       ┆
     3 │ fn Run0() {}
       · ─────┬─────
       ·      ╰──┤ calling function declared here
       ┆
->   6 │   Run0(1);
       ·   ───────
       ╰────────────
```

`--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`.
File
tests use it; the rendering tests under `toolchain/diagnostics/testdata`
ask for
snippets.

C++ interop diagnostics are data now rather than text Clang drew:
`SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang
location is
marked as the point it names.

`StreamConsumer` moves to a `:renderer` target that `:emitter` does not
depend
on, keeping `common/terminal` out of `consumer.h`. Capabilities come
from the
file behind the error stream, so tests get plain ASCII.

`renderer_fuzzer` draws diagnostics built from fuzzer bytes with every
capability combination, since a shape the renderer doesn't expect must
never be
why the compiler dies while reporting a problem.

TODOs mark the follow-ups: line weights and crossing lines, wrapping
that keeps
a quoted type whole, and ordering diagnostics that share a byte offset.

Also: `IncorrectExtension`'s hint moves into its message, since its note
had no
location of its own, and `strip_noise` in `check_diagnostics.py` blanks
multi-line `#define`s instead of deleting them.

Assisted-by: Claude Code
2026-10-15 06:08:57 +00:00

88 lines
4.4 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/parse/testdata/if/fail_else_unbraced.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/if/fail_else_unbraced.carbon
fn F() {
if (a)
// CHECK:STDERR: fail_else_unbraced.carbon:[[@LINE+2]]:5-6: error: expected braced code block [ExpectedCodeBlock]
// CHECK:STDERR:
if (b)
// CHECK:STDERR: fail_else_unbraced.carbon:[[@LINE+2]]:7: error: expected braced code block [ExpectedCodeBlock]
// CHECK:STDERR:
c;
else
// CHECK:STDERR: fail_else_unbraced.carbon:[[@LINE+2]]:7: error: expected braced code block [ExpectedCodeBlock]
// CHECK:STDERR:
d;
else
// CHECK:STDERR: fail_else_unbraced.carbon:[[@LINE+2]]:5: error: expected braced code block [ExpectedCodeBlock]
// CHECK:STDERR:
e;
if (x) { f; }
else if (x) { g; }
else { h; }
}
// CHECK:STDOUT: - filename: fail_else_unbraced.carbon
// CHECK:STDOUT: ╭─FileStart ''
// CHECK:STDOUT: │ ╭─FunctionIntroducer 'fn'
// CHECK:STDOUT: │ ├─IdentifierNameMaybeBeforeSignature 'F'
// CHECK:STDOUT: │ │ ╭─ExplicitParamListStart '('
// CHECK:STDOUT: │ ├─ExplicitParamList ')'
// CHECK:STDOUT: │ ╭─FunctionDefinitionStart '{'
// CHECK:STDOUT: │ │ ╭─IfConditionStart '('
// CHECK:STDOUT: │ │ ├─IdentifierNameExpr 'a'
// CHECK:STDOUT: │ │ ╭─IfCondition ')'
// CHECK:STDOUT: │ │ │ ╭─CodeBlockStart 'if' has_error
// CHECK:STDOUT: │ │ │ │ ╭─IfConditionStart '('
// CHECK:STDOUT: │ │ │ │ ├─IdentifierNameExpr 'b'
// CHECK:STDOUT: │ │ │ │ ╭─IfCondition ')'
// CHECK:STDOUT: │ │ │ │ │ ╭─CodeBlockStart 'c' has_error
// CHECK:STDOUT: │ │ │ │ │ │ ╭─IdentifierNameExpr 'c'
// CHECK:STDOUT: │ │ │ │ │ ├─ExprStatement ';'
// CHECK:STDOUT: │ │ │ │ ├─CodeBlock 'c' has_error
// CHECK:STDOUT: │ │ │ │ ├─IfStatementElse 'else'
// CHECK:STDOUT: │ │ │ │ │ ╭─CodeBlockStart 'd' has_error
// CHECK:STDOUT: │ │ │ │ │ │ ╭─IdentifierNameExpr 'd'
// CHECK:STDOUT: │ │ │ │ │ ├─ExprStatement ';'
// CHECK:STDOUT: │ │ │ │ ├─CodeBlock 'd' has_error
// CHECK:STDOUT: │ │ │ ├─IfStatement 'if'
// CHECK:STDOUT: │ │ ├─CodeBlock 'if' has_error
// CHECK:STDOUT: │ │ ├─IfStatementElse 'else'
// CHECK:STDOUT: │ │ │ ╭─CodeBlockStart 'e' has_error
// CHECK:STDOUT: │ │ │ │ ╭─IdentifierNameExpr 'e'
// CHECK:STDOUT: │ │ │ ├─ExprStatement ';'
// CHECK:STDOUT: │ │ ├─CodeBlock 'e' has_error
// CHECK:STDOUT: │ ├─IfStatement 'if'
// CHECK:STDOUT: │ │ ╭─IfConditionStart '('
// CHECK:STDOUT: │ │ ├─IdentifierNameExpr 'x'
// CHECK:STDOUT: │ │ ╭─IfCondition ')'
// CHECK:STDOUT: │ │ │ ╭─CodeBlockStart '{'
// CHECK:STDOUT: │ │ │ │ ╭─IdentifierNameExpr 'f'
// CHECK:STDOUT: │ │ │ ├─ExprStatement ';'
// CHECK:STDOUT: │ │ ├─CodeBlock '}'
// CHECK:STDOUT: │ │ ├─IfStatementElse 'else'
// CHECK:STDOUT: │ │ │ ╭─IfConditionStart '('
// CHECK:STDOUT: │ │ │ ├─IdentifierNameExpr 'x'
// CHECK:STDOUT: │ │ │ ╭─IfCondition ')'
// CHECK:STDOUT: │ │ │ │ ╭─CodeBlockStart '{'
// CHECK:STDOUT: │ │ │ │ │ ╭─IdentifierNameExpr 'g'
// CHECK:STDOUT: │ │ │ │ ├─ExprStatement ';'
// CHECK:STDOUT: │ │ │ ├─CodeBlock '}'
// CHECK:STDOUT: │ │ │ ├─IfStatementElse 'else'
// CHECK:STDOUT: │ │ │ │ ╭─CodeBlockStart '{'
// CHECK:STDOUT: │ │ │ │ │ ╭─IdentifierNameExpr 'h'
// CHECK:STDOUT: │ │ │ │ ├─ExprStatement ';'
// CHECK:STDOUT: │ │ │ ├─CodeBlock '}'
// CHECK:STDOUT: │ │ ├─IfStatement 'if'
// CHECK:STDOUT: │ ├─IfStatement 'if'
// CHECK:STDOUT: ├─FunctionDefinition '}'
// CHECK:STDOUT: ├─FileEnd ''
// CHECK:STDOUT: (root)