mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 18:58:11 +00:00
Chandler Carruth
2c9739799b
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
36 lines
2.3 KiB
Plaintext
36 lines
2.3 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// EXTRA-ARGS: --parse-dump-format=yaml-preorder
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/parse/testdata/dump_format/yaml_preorder.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/dump_format/yaml_preorder.carbon
|
|
|
|
// --- fail_yaml_preorder.carbon
|
|
|
|
// CHECK:STDERR: fail_yaml_preorder.carbon:[[@LINE+2]]:9: error: expected `.field: field_type` or `.field = value` [ExpectedStructLiteralField]
|
|
// CHECK:STDERR:
|
|
var x: {,} = {};
|
|
|
|
// CHECK:STDOUT: - filename: fail_yaml_preorder.carbon
|
|
// CHECK:STDOUT: parse_tree: [
|
|
// CHECK:STDOUT: {node_index: 0, kind: 'FileStart', text: ''},
|
|
// CHECK:STDOUT: {node_index: 13, kind: 'VariableDecl', text: ';', subtree_size: 13, children: [
|
|
// CHECK:STDOUT: {node_index: 1, kind: 'VariableIntroducer', text: 'var'},
|
|
// CHECK:STDOUT: {node_index: 9, kind: 'VariablePattern', text: 'var', subtree_size: 8, children: [
|
|
// CHECK:STDOUT: {node_index: 8, kind: 'VarBindingPattern', text: ':', subtree_size: 7, children: [
|
|
// CHECK:STDOUT: {node_index: 2, kind: 'IdentifierNameNotBeforeSignature', text: 'x'},
|
|
// CHECK:STDOUT: {node_index: 3, kind: 'BindingPatternTypeStart', text: ':'},
|
|
// CHECK:STDOUT: {node_index: 7, kind: 'StructLiteral', text: '}', has_error: yes, subtree_size: 4, children: [
|
|
// CHECK:STDOUT: {node_index: 4, kind: 'StructLiteralStart', text: '{'},
|
|
// CHECK:STDOUT: {node_index: 5, kind: 'InvalidParse', text: ',', has_error: yes},
|
|
// CHECK:STDOUT: {node_index: 6, kind: 'InvalidParse', text: ',', has_error: yes}]}]}]},
|
|
// CHECK:STDOUT: {node_index: 10, kind: 'VariableInitializer', text: '='},
|
|
// CHECK:STDOUT: {node_index: 12, kind: 'StructLiteral', text: '}', subtree_size: 2, children: [
|
|
// CHECK:STDOUT: {node_index: 11, kind: 'StructLiteralStart', text: '{'}]}]},
|
|
// CHECK:STDOUT: {node_index: 14, kind: 'FileEnd', text: ''},
|
|
// CHECK:STDOUT: ]
|