mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-17 11:08:10 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
84 lines
5.5 KiB
Plaintext
84 lines
5.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/lex/testdata/fail_char_literals_bad_encoding.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/lex/testdata/fail_char_literals_bad_encoding.carbon
|
|
// CHECK:STDOUT: - filename: fail_char_literals_bad_encoding.carbon
|
|
// CHECK:STDOUT: tokens:
|
|
|
|
// Be careful when operating on this file: it contains invalid UTF-8 sequences
|
|
// and Unicode control characters, and text editors are likely to corrupt it.
|
|
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: control character in character literal; specify as escape sequence `\u{00}` [CharLiteralControlCharacter]
|
|
// CHECK:STDERR:
|
|
'[[@0x00]]'
|
|
// CHECK:STDOUT: - { index: 1, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\x00'", has_leading_space: true }
|
|
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: control character in character literal; specify as escape sequence `\u{01}` [CharLiteralControlCharacter]
|
|
// CHECK:STDERR:
|
|
'[[@0x01]]'
|
|
// CHECK:STDOUT: - { index: 2, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\x01'", has_leading_space: true }
|
|
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: control character in character literal; specify as escape sequence `\u{1F}` [CharLiteralControlCharacter]
|
|
// CHECK:STDERR:
|
|
'[[@0x1F]]'
|
|
// CHECK:STDOUT: - { index: 3, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\x1F'", has_leading_space: true }
|
|
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: control character in character literal; specify as escape sequence `\u{7F}` [CharLiteralControlCharacter]
|
|
// CHECK:STDERR:
|
|
'[[@0x7F]]'
|
|
// CHECK:STDOUT: - { index: 4, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\x7F'", has_leading_space: true }
|
|
|
|
// 0xC2 0x80 is U+0080.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: control character in character literal; specify as escape sequence `\u{80}` [CharLiteralControlCharacter]
|
|
// CHECK:STDERR:
|
|
'[[@0xC2]][[@0x80]]'
|
|
// CHECK:STDOUT: - { index: 5, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xC2\x80'", has_leading_space: true }
|
|
|
|
// 0xC2 0x9F is U+009F.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: control character in character literal; specify as escape sequence `\u{9F}` [CharLiteralControlCharacter]
|
|
// CHECK:STDERR:
|
|
'[[@0xC2]][[@0x9F]]'
|
|
// CHECK:STDOUT: - { index: 6, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xC2\x9F'", has_leading_space: true }
|
|
|
|
// 0xC3 is invalid UTF-8 due to having a lead byte with no trail byte.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: incomplete UTF-8 [CharLiteralUnderflow]
|
|
// CHECK:STDERR:
|
|
'[[@0xC3]]'
|
|
// CHECK:STDOUT: - { index: 7, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xC3'", has_leading_space: true }
|
|
|
|
// 0xC3 0xC3 is invalid UTF-8 due to having two lead bytes in a row.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: invalid UTF-8 character [CharLiteralInvalidUTF8]
|
|
// CHECK:STDERR:
|
|
'[[@0xC3]][[@0xC3]]'
|
|
// CHECK:STDOUT: - { index: 8, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xC3\xC3'", has_leading_space: true }
|
|
|
|
// This is invalid UTF-8 due to being too large.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: invalid UTF-8 character [CharLiteralInvalidUTF8]
|
|
// CHECK:STDERR:
|
|
'[[@0xFF]][[@0x80]][[@0x80]][[@0x80]][[@0x80]][[@0x80]][[@0x80]][[@0x80]][[@0x80]]'
|
|
// CHECK:STDOUT: - { index: 9, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xFF\x80\x80\x80\x80\x80\x80\x80\x80'", has_leading_space: true }
|
|
|
|
// 0xED 0xA0 0x80 would be U+D800 but is invalid UTF-8 due to encoding a high surrogate value.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: invalid UTF-8 character [CharLiteralInvalidUTF8]
|
|
// CHECK:STDERR:
|
|
'[[@0xED]][[@0xA0]][[@0x80]]'
|
|
// CHECK:STDOUT: - { index: 10, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xED\xA0\x80'", has_leading_space: true }
|
|
|
|
// 0xED 0xBF 0xBF would be U+DFFF but is invalid UTF-8 due to encoding a low surrogate value.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: invalid UTF-8 character [CharLiteralInvalidUTF8]
|
|
// CHECK:STDERR:
|
|
'[[@0xED]][[@0xBF]][[@0xBF]]'
|
|
// CHECK:STDOUT: - { index: 11, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xED\xBF\xBF'", has_leading_space: true }
|
|
|
|
// 0xED 0xA0 0xBD 0xED 0xBA 0x80 would be U+D83D U+DE80, but those are both surrogates.
|
|
// Treated as UTF-16, that would in turn produce U+1F680. But we don't do that.
|
|
// CHECK:STDERR: fail_char_literals_bad_encoding.carbon:[[@LINE+2]]:1: error: invalid UTF-8 character [CharLiteralInvalidUTF8]
|
|
// CHECK:STDERR:
|
|
'[[@0xED]][[@0xA0]][[@0xBD]][[@0xED]][[@0xBA]][[@0x80]]'
|
|
// CHECK:STDOUT: - { index: 12, kind: "Error", line: {{ *}}[[@LINE-1]], column: 1, indent: 1, spelling: "'\xED\xA0\xBD\xED\xBA\x80'", has_leading_space: true }
|