mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 17:28:11 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
77 lines
3.0 KiB
Plaintext
77 lines
3.0 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/language_server/testdata/text_document/diagnostics_no_line.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/language_server/testdata/text_document/diagnostics_no_line.carbon
|
|
|
|
// An api file with an `.impl.carbon` extension gets a diagnostic about the
|
|
// file as a whole, with no line or column. Its range must not be negative.
|
|
|
|
// --- STDIN
|
|
[[@LSP-CALL:initialize:"capabilities": {}]]
|
|
[[@LSP-NOTIFY:textDocument/didOpen:
|
|
"textDocument": {"uri": "file:/test.impl.carbon", "languageId": "carbon",
|
|
"version": 1, "text": "fn F() {}"}
|
|
]]
|
|
[[@LSP-CALL:shutdown]]
|
|
[[@LSP-NOTIFY:exit]]
|
|
|
|
// --- AUTOUPDATE-SPLIT
|
|
|
|
// CHECK:STDOUT: Content-Length: 432{{\r}}
|
|
// CHECK:STDOUT: {{\r}}
|
|
// CHECK:STDOUT: {
|
|
// CHECK:STDOUT: "id": 1,
|
|
// CHECK:STDOUT: "jsonrpc": "2.0",
|
|
// CHECK:STDOUT: "result": {
|
|
// CHECK:STDOUT: "capabilities": {
|
|
// CHECK:STDOUT: "declarationProvider": true,
|
|
// CHECK:STDOUT: "definitionProvider": true,
|
|
// CHECK:STDOUT: "documentFormattingProvider": true,
|
|
// CHECK:STDOUT: "documentSymbolProvider": true,
|
|
// CHECK:STDOUT: "hoverProvider": true,
|
|
// CHECK:STDOUT: "implementationProvider": true,
|
|
// CHECK:STDOUT: "positionEncoding": "utf-16",
|
|
// CHECK:STDOUT: "referencesProvider": true,
|
|
// CHECK:STDOUT: "textDocumentSync": 2,
|
|
// CHECK:STDOUT: "typeDefinitionProvider": true
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: }Content-Length: 537{{\r}}
|
|
// CHECK:STDOUT: {{\r}}
|
|
// CHECK:STDOUT: {
|
|
// CHECK:STDOUT: "jsonrpc": "2.0",
|
|
// CHECK:STDOUT: "method": "textDocument/publishDiagnostics",
|
|
// CHECK:STDOUT: "params": {
|
|
// CHECK:STDOUT: "diagnostics": [
|
|
// CHECK:STDOUT: {
|
|
// CHECK:STDOUT: "message": "file extension of `.carbon` required for api; `.impl.carbon` names an `impl` file",
|
|
// CHECK:STDOUT: "range": {
|
|
// CHECK:STDOUT: "end": {
|
|
// CHECK:STDOUT: "character": 0,
|
|
// CHECK:STDOUT: "line": 0
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: "start": {
|
|
// CHECK:STDOUT: "character": 0,
|
|
// CHECK:STDOUT: "line": 0
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: "severity": 1,
|
|
// CHECK:STDOUT: "source": "carbon"
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: ],
|
|
// CHECK:STDOUT: "uri": "file:///test.impl.carbon",
|
|
// CHECK:STDOUT: "version": 1
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: }Content-Length: 51{{\r}}
|
|
// CHECK:STDOUT: {{\r}}
|
|
// CHECK:STDOUT: {
|
|
// CHECK:STDOUT: "id": 2,
|
|
// CHECK:STDOUT: "jsonrpc": "2.0",
|
|
// CHECK:STDOUT: "result": null
|
|
// CHECK:STDOUT: }
|