mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 16:38:09 +00:00
We allow using `InstId` as a `LocId` for diagnostics, which works great in `handle_*` functions, where we are working with non-canonical insts. And convert and pattern matching often are given non-canonical insts, which they can use, or pull apart to find some other inst, and use those as a location for diagnostics. However these operations can also be called with canonical insts, which have no location. In that case if we need to diagnose an error, it ends up not being attached to any code at all. Since we always have a `LocId` somewhere up the call stack, pass it along and in these places that handle canonical instructions too, use `GetInstLocationOrFallback()` to get a valid location for diagnostics. This is also similar to what eval does with its fallback `LocId`. The result is that many diagnostics now have a location where they had none before. It also means some insts don't get `<elided>` in formatted semir for not having a location at all and thus not being in range.
184 lines
11 KiB
Plaintext
184 lines
11 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// ARGS: compile --optimize=size foo.carbon --target=x86_64-unknown-linux-gnu --phase=lower --dump-llvm-ir --exclude-dump-file-prefix=%{core}
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/driver/testdata/compile/optimize/optimize_size.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/driver/testdata/compile/optimize/optimize_size.carbon
|
|
|
|
// --- foo.carbon
|
|
fn Rand() -> i32;
|
|
|
|
fn NoInlineWithOz() -> i32 {
|
|
return Rand() + Rand();
|
|
}
|
|
|
|
fn CallNoInlineWithOptSize() -> i32 {
|
|
// Should not be inlined with --optimize=size, because the body is larger than the call.
|
|
return NoInlineWithOz();
|
|
}
|
|
|
|
fn VectorizedWithOptSpeed(a: array(i32, 65536)*) {
|
|
// Should be vectorized with --optimize=speed, but not in other modes.
|
|
var n: i32 = 0;
|
|
while (n < 65536) {
|
|
(*a)[n] *= 2;
|
|
++n;
|
|
}
|
|
}
|
|
|
|
// CHECK:STDOUT: ; ---
|
|
// CHECK:STDOUT: ; ModuleID = 'foo.carbon'
|
|
// CHECK:STDOUT: source_filename = "foo.carbon"
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: declare i32 @_CRand.Main()
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define i32 @_CNoInlineWithOz.Main() #0 !dbg !10 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %Rand.call.loc4_15 = call i32 @_CRand.Main(), !dbg !13
|
|
// CHECK:STDOUT: %Rand.call.loc4_24 = call i32 @_CRand.Main(), !dbg !14
|
|
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %Rand.call.loc4_15, %Rand.call.loc4_24, !dbg !13
|
|
// CHECK:STDOUT: ret i32 %Int.as.AddWith.impl.Op.call, !dbg !15
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define i32 @_CCallNoInlineWithOptSize.Main() #0 !dbg !16 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %NoInlineWithOz.call = call i32 @_CNoInlineWithOz.Main(), !dbg !19
|
|
// CHECK:STDOUT: ret i32 %NoInlineWithOz.call, !dbg !20
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define void @_CVectorizedWithOptSpeed.Main(ptr %a) #0 !dbg !21 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %n.var = alloca i32, align 4, !dbg !24
|
|
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %n.var), !dbg !24
|
|
// CHECK:STDOUT: store i32 0, ptr %n.var, align 4, !dbg !24
|
|
// CHECK:STDOUT: br label %while.cond, !dbg !26
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: while.cond: ; preds = %while.body, %entry
|
|
// CHECK:STDOUT: %.loc15_10 = load i32, ptr %n.var, align 4, !dbg !27
|
|
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Less.call = icmp slt i32 %.loc15_10, 65536, !dbg !27
|
|
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Less.call, label %while.body, label %while.done, !dbg !26
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: while.body: ; preds = %while.cond
|
|
// CHECK:STDOUT: %.loc16_10 = load i32, ptr %n.var, align 4, !dbg !30
|
|
// CHECK:STDOUT: %.loc16_11.array.index = getelementptr inbounds [65536 x i32], ptr %a, i32 0, i32 %.loc16_10, !dbg !31
|
|
// CHECK:STDOUT: %Int.as.MulAssignWith.impl.Op.call = load i32, ptr %.loc16_11.array.index, align 4, !dbg !31
|
|
// CHECK:STDOUT: %Int.as.MulAssignWith.impl.Op.call1 = mul i32 %Int.as.MulAssignWith.impl.Op.call, 2, !dbg !31
|
|
// CHECK:STDOUT: store i32 %Int.as.MulAssignWith.impl.Op.call1, ptr %.loc16_11.array.index, align 4, !dbg !31
|
|
// CHECK:STDOUT: call void @"_COp.Int.9452f4c51951679b.Core:Inc.Core.be1e879c1ad406d8"(ptr %n.var), !dbg !33
|
|
// CHECK:STDOUT: br label %while.cond, !dbg !34
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: while.done: ; preds = %while.cond
|
|
// CHECK:STDOUT: call void @"_CSelfDestruct.72395be3dbbe8946:core.Destroy.Core"(ptr %n.var), !dbg !24
|
|
// CHECK:STDOUT: ret void, !dbg !35
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define weak_odr void @"_CSelfDestruct.72395be3dbbe8946:core.Destroy.Core"(ptr %self) #0 !dbg !37 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: ret void, !dbg !39
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
|
|
// CHECK:STDOUT: declare void @llvm.lifetime.start.p0(ptr captures(none)) #1
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define linkonce_odr void @"_COp.Int.9452f4c51951679b.Core:Inc.Core.be1e879c1ad406d8"(ptr %self) #0 !dbg !42 {
|
|
// CHECK:STDOUT: call void @"_COp:thunk:AddAssignWith.b59e374b0649c9ad.Core:Int.9452f4c51951679b.Core:AddAssignWith.ab03190a9e911cb4.Core.306167be98c24f26"(ptr %self, i32 1), !dbg !45
|
|
// CHECK:STDOUT: ret void, !dbg !48
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: alwaysinline minsize nounwind optsize
|
|
// CHECK:STDOUT: define linkonce_odr void @"_COp:thunk:AddAssignWith.b59e374b0649c9ad.Core:Int.9452f4c51951679b.Core:AddAssignWith.ab03190a9e911cb4.Core.306167be98c24f26"(ptr %self, i32 %other) #2 !dbg !50 {
|
|
// CHECK:STDOUT: %1 = call i32 @"_CConvert.df8c28cb3df17b7d:ImplicitAs.c95da57eee1d2d0f.Core.25ef994321ea0701"(i32 %other), !dbg !54
|
|
// CHECK:STDOUT: %2 = load i32, ptr %self, align 4, !dbg !54
|
|
// CHECK:STDOUT: %3 = add i32 %2, %1, !dbg !54
|
|
// CHECK:STDOUT: store i32 %3, ptr %self, align 4, !dbg !54
|
|
// CHECK:STDOUT: ret void, !dbg !54
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define linkonce_odr i32 @"_CConvert.df8c28cb3df17b7d:ImplicitAs.c95da57eee1d2d0f.Core.25ef994321ea0701"(i32 %self) #0 !dbg !58 {
|
|
// CHECK:STDOUT: %1 = call i32 @"_CAsInt.Int.9452f4c51951679b.Core:AnyInt.Core.be1e879c1ad406d8"(i32 %self), !dbg !63
|
|
// CHECK:STDOUT: ret i32 %1, !dbg !65
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: minsize nounwind optsize
|
|
// CHECK:STDOUT: define linkonce_odr i32 @"_CAsInt.Int.9452f4c51951679b.Core:AnyInt.Core.be1e879c1ad406d8"(i32 %self) #0 !dbg !67 {
|
|
// CHECK:STDOUT: ret i32 %self, !dbg !73
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: attributes #0 = { minsize nounwind optsize }
|
|
// CHECK:STDOUT: attributes #1 = { nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
|
|
// CHECK:STDOUT: attributes #2 = { alwaysinline minsize nounwind optsize }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !llvm.dbg.cu = !{!1}
|
|
// CHECK:STDOUT: !llvm.module.flags = !{!75, !76}
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !0 = !DIFile(filename: "foo.carbon", directory: "")
|
|
// CHECK:STDOUT: !1 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !0, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
|
|
// CHECK:STDOUT: !2 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
// CHECK:STDOUT: !3 = !{!2}
|
|
// CHECK:STDOUT: !4 = !DISubroutineType(types: !3)
|
|
// CHECK:STDOUT: !5 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: null, size: 64)
|
|
// CHECK:STDOUT: !6 = !{null, !5}
|
|
// CHECK:STDOUT: !7 = !DISubroutineType(types: !6)
|
|
// CHECK:STDOUT: !8 = !{null, !2}
|
|
// CHECK:STDOUT: !9 = !DISubroutineType(types: !8)
|
|
// CHECK:STDOUT: !10 = distinct !DISubprogram(name: "NoInlineWithOz", linkageName: "_CNoInlineWithOz.Main", scope: null, file: !0, line: 3, type: !4, spFlags: DISPFlagDefinition, unit: !1)
|
|
// CHECK:STDOUT: !13 = !DILocation(line: 4, column: 10, scope: !10)
|
|
// CHECK:STDOUT: !14 = !DILocation(line: 4, column: 19, scope: !10)
|
|
// CHECK:STDOUT: !15 = !DILocation(line: 4, column: 3, scope: !10)
|
|
// CHECK:STDOUT: !16 = distinct !DISubprogram(name: "CallNoInlineWithOptSize", linkageName: "_CCallNoInlineWithOptSize.Main", scope: null, file: !0, line: 7, type: !4, spFlags: DISPFlagDefinition, unit: !1)
|
|
// CHECK:STDOUT: !19 = !DILocation(line: 9, column: 10, scope: !16)
|
|
// CHECK:STDOUT: !20 = !DILocation(line: 9, column: 3, scope: !16)
|
|
// CHECK:STDOUT: !21 = distinct !DISubprogram(name: "VectorizedWithOptSpeed", linkageName: "_CVectorizedWithOptSpeed.Main", scope: null, file: !0, line: 12, type: !7, spFlags: DISPFlagDefinition, unit: !1, retainedNodes: !36)
|
|
// CHECK:STDOUT: !22 = !DILocalVariable(arg: 1, scope: !21, type: !5)
|
|
// CHECK:STDOUT: !24 = !DILocation(line: 14, column: 3, scope: !21)
|
|
// CHECK:STDOUT: !26 = !DILocation(line: 15, column: 9, scope: !21)
|
|
// CHECK:STDOUT: !27 = !DILocation(line: 15, column: 10, scope: !21)
|
|
// CHECK:STDOUT: !30 = !DILocation(line: 16, column: 10, scope: !21)
|
|
// CHECK:STDOUT: !31 = !DILocation(line: 16, column: 5, scope: !21)
|
|
// CHECK:STDOUT: !33 = !DILocation(line: 17, column: 5, scope: !21)
|
|
// CHECK:STDOUT: !34 = !DILocation(line: 15, column: 3, scope: !21)
|
|
// CHECK:STDOUT: !35 = !DILocation(line: 12, column: 1, scope: !21)
|
|
// CHECK:STDOUT: !36 = !{!22}
|
|
// CHECK:STDOUT: !37 = distinct !DISubprogram(name: "SelfDestruct", linkageName: "_CSelfDestruct.72395be3dbbe8946:core.Destroy.Core", scope: null, file: !0, line: 14, type: !9, spFlags: DISPFlagDefinition, unit: !1, retainedNodes: !40)
|
|
// CHECK:STDOUT: !38 = !DILocalVariable(arg: 1, scope: !37, type: !2)
|
|
// CHECK:STDOUT: !39 = !DILocation(line: 14, column: 3, scope: !37)
|
|
// CHECK:STDOUT: !40 = !{!38}
|
|
// CHECK:STDOUT: !41 = !DIFile(filename: "{{.*}}/prelude/types/int.carbon", directory: "")
|
|
// CHECK:STDOUT: !42 = distinct !DISubprogram(name: "Op", linkageName: "_COp.Int.9452f4c51951679b.Core:Inc.Core.be1e879c1ad406d8", scope: null, file: !41, line: 396, type: !9, spFlags: DISPFlagDefinition, unit: !1, retainedNodes: !49)
|
|
// CHECK:STDOUT: !43 = !DILocalVariable(arg: 1, scope: !42, type: !2)
|
|
// CHECK:STDOUT: !45 = !DILocation(line: 398, column: 5, scope: !42)
|
|
// CHECK:STDOUT: !46 = !{null, !2, !2}
|
|
// CHECK:STDOUT: !47 = !DISubroutineType(types: !46)
|
|
// CHECK:STDOUT: !48 = !DILocation(line: 396, column: 3, scope: !42)
|
|
// CHECK:STDOUT: !49 = !{!43}
|
|
// CHECK:STDOUT: !50 = distinct !DISubprogram(name: "Op", linkageName: "_COp:thunk:AddAssignWith.b59e374b0649c9ad.Core:Int.9452f4c51951679b.Core:AddAssignWith.ab03190a9e911cb4.Core.306167be98c24f26", scope: null, file: !41, line: 331, type: !47, spFlags: DISPFlagDefinition, unit: !1, retainedNodes: !57)
|
|
// CHECK:STDOUT: !51 = !DILocalVariable(arg: 1, scope: !50, type: !2)
|
|
// CHECK:STDOUT: !52 = !DILocalVariable(arg: 2, scope: !50, type: !2)
|
|
// CHECK:STDOUT: !54 = !DILocation(line: 331, column: 3, scope: !50)
|
|
// CHECK:STDOUT: !55 = !{!2, !2}
|
|
// CHECK:STDOUT: !56 = !DISubroutineType(types: !55)
|
|
// CHECK:STDOUT: !57 = !{!51, !52}
|
|
// CHECK:STDOUT: !58 = distinct !DISubprogram(name: "Convert", linkageName: "_CConvert.df8c28cb3df17b7d:ImplicitAs.c95da57eee1d2d0f.Core.25ef994321ea0701", scope: null, file: !41, line: 64, type: !56, spFlags: DISPFlagDefinition, unit: !1, retainedNodes: !66)
|
|
// CHECK:STDOUT: !59 = !DILocalVariable(arg: 1, scope: !58, type: !2)
|
|
// CHECK:STDOUT: !63 = !DILocation(line: 66, column: 17, scope: !58)
|
|
// CHECK:STDOUT: !65 = !DILocation(line: 66, column: 5, scope: !58)
|
|
// CHECK:STDOUT: !66 = !{!59}
|
|
// CHECK:STDOUT: !67 = distinct !DISubprogram(name: "AsInt", linkageName: "_CAsInt.Int.9452f4c51951679b.Core:AnyInt.Core.be1e879c1ad406d8", scope: null, file: !41, line: 59, type: !56, spFlags: DISPFlagDefinition, unit: !1, retainedNodes: !74)
|
|
// CHECK:STDOUT: !68 = !DILocalVariable(arg: 1, scope: !67, type: !2)
|
|
// CHECK:STDOUT: !73 = !DILocation(line: 59, column: 28, scope: !67)
|
|
// CHECK:STDOUT: !74 = !{!68}
|
|
// CHECK:STDOUT: !75 = !{i32 7, !"Dwarf Version", i32 5}
|
|
// CHECK:STDOUT: !76 = !{i32 2, !"Debug Info Version", i32 3}
|
|
// CHECK:STDOUT:
|