mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 23:08:12 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
164 lines
6.1 KiB
Plaintext
164 lines
6.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/uint.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/primitives/string_literals.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/primitives/string_literals.carbon
|
|
|
|
// --- fail_no_string.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
fn F() {
|
|
// CHECK:STDERR: fail_no_string.carbon:[[@LINE+2]]:3-9: error: name `Core.String` implicitly referenced here, but not found [CoreNameNotFound]
|
|
// CHECK:STDERR:
|
|
"hello";
|
|
}
|
|
|
|
// --- unusual_string.carbon
|
|
|
|
package Core library "[[@TEST_NAME]]";
|
|
|
|
import library "prelude/parts/uint";
|
|
|
|
class String {
|
|
var begin: u8*;
|
|
var end: u8*;
|
|
}
|
|
|
|
// --- fail_use_unusual_string.carbon
|
|
|
|
import Core library "unusual_string";
|
|
|
|
// CHECK:STDERR: fail_use_unusual_string.carbon:[[@LINE+2]]:14-20: error: unexpected representation for type `str` [StringLiteralTypeUnexpected]
|
|
// CHECK:STDERR:
|
|
let x: str = "hello";
|
|
|
|
// --- incomplete_string.carbon
|
|
|
|
package Core library "[[@TEST_NAME]]";
|
|
|
|
class String;
|
|
|
|
// --- fail_use_incomplete_string.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Core library "incomplete_string";
|
|
|
|
fn F() {
|
|
// CHECK:STDERR: fail_use_incomplete_string.carbon:[[@LINE+3]]:3-9: error: type `Core.String` is incomplete [StringLiteralTypeIncomplete]
|
|
// CHECK:STDERR: incomplete_string.carbon:4:1-13: note: class was forward declared here [ClassForwardDeclaredHere]
|
|
// CHECK:STDERR:
|
|
"hello";
|
|
}
|
|
|
|
// --- small_string.carbon
|
|
|
|
package Core library "[[@TEST_NAME]]";
|
|
|
|
import library "prelude/parts/uint";
|
|
|
|
class String {
|
|
var ptr: u8*;
|
|
// An intentionally small `size` field to test the behavior when a string
|
|
// literal is large enough that its size can't be represented.
|
|
var size: u8;
|
|
}
|
|
|
|
// --- use_small_string.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Core library "small_string";
|
|
|
|
//@dump-sem-ir-begin
|
|
let x: str = "hello";
|
|
//@dump-sem-ir-end
|
|
|
|
// --- fail_overfill_small_string.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Core library "small_string";
|
|
|
|
//@dump-sem-ir-begin
|
|
// CHECK:STDERR: fail_overfill_small_string.carbon:[[@LINE+2]]:14-276: error: string literal is too long [StringLiteralTooLong]
|
|
// CHECK:STDERR:
|
|
let x: str = '''
|
|
A string so long its size does not fit in `u8`. This results in an error,
|
|
because we can't form a `Core.String` value that describes this string.
|
|
|
|
This string contains 256 characters. Among them are:
|
|
|
|
* 6 `g`s,
|
|
* 21 `s`s,
|
|
* 9 newlines,
|
|
* and only one `p`.
|
|
''';
|
|
//@dump-sem-ir-end
|
|
|
|
// CHECK:STDOUT: --- use_small_string.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
|
|
// CHECK:STDOUT: %str.3d4: type = class_type @String [concrete]
|
|
// CHECK:STDOUT: %int_8: Core.IntLiteral = int_value 8 [concrete]
|
|
// CHECK:STDOUT: %u8: type = class_type @UInt, @UInt(%int_8) [concrete]
|
|
// CHECK:STDOUT: %ptr.22f: type = ptr_type %u8 [concrete]
|
|
// CHECK:STDOUT: %pattern_type.adf: type = pattern_type %str.3d4 [concrete]
|
|
// CHECK:STDOUT: %x.patt: %pattern_type.adf = value_binding_pattern x [concrete]
|
|
// CHECK:STDOUT: %str.5d7: %ptr.22f = string_literal "hello" [concrete]
|
|
// CHECK:STDOUT: %int_5: %u8 = int_value 5 [concrete]
|
|
// CHECK:STDOUT: %String.val: %str.3d4 = struct_value (%str.5d7, %int_5) [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: %str: type = type_literal constants.%str.3d4 [concrete = constants.%str.3d4]
|
|
// CHECK:STDOUT: %x: %str.3d4 = wrapper_binding x, @__global_init.%String.val
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %x.patt: %pattern_type.adf = value_binding_pattern x [concrete = constants.%x.patt]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @__global_init() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %str: %ptr.22f = string_literal "hello" [concrete = constants.%str.5d7]
|
|
// CHECK:STDOUT: %int_5: %u8 = int_value 5 [concrete = constants.%int_5]
|
|
// CHECK:STDOUT: %String.val: %str.3d4 = struct_value (%str, %int_5) [concrete = constants.%String.val]
|
|
// CHECK:STDOUT: <elided>
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: --- fail_overfill_small_string.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
|
|
// CHECK:STDOUT: %str.3d4: type = class_type @String [concrete]
|
|
// CHECK:STDOUT: %int_8: Core.IntLiteral = int_value 8 [concrete]
|
|
// CHECK:STDOUT: %u8: type = class_type @UInt, @UInt(%int_8) [concrete]
|
|
// CHECK:STDOUT: %ptr.22f: type = ptr_type %u8 [concrete]
|
|
// CHECK:STDOUT: %pattern_type.adf: type = pattern_type %str.3d4 [concrete]
|
|
// CHECK:STDOUT: %x.patt: %pattern_type.adf = value_binding_pattern x [concrete]
|
|
// CHECK:STDOUT: %str.18e: %ptr.22f = string_literal "A string so long its size does not fit in `u8`. This results in an error,\nbecause we can't form a `Core.String` value that describes this string.\n\nThis string contains 256 characters. Among them are:\n\n* 6 `g`s,\n* 21 `s`s,\n* 9 newlines,\n* and only one `p`.\n" [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: %str: type = type_literal constants.%str.3d4 [concrete = constants.%str.3d4]
|
|
// CHECK:STDOUT: %x: %str.3d4 = wrapper_binding x, <error> [concrete = <error>]
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %x.patt: %pattern_type.adf = value_binding_pattern x [concrete = constants.%x.patt]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @__global_init() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %str: %ptr.22f = string_literal "A string so long its size does not fit in `u8`. This results in an error,\nbecause we can't form a `Core.String` value that describes this string.\n\nThis string contains 256 characters. Among them are:\n\n* 6 `g`s,\n* 21 `s`s,\n* 9 newlines,\n* and only one `p`.\n" [concrete = constants.%str.18e]
|
|
// CHECK:STDOUT: <elided>
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|