mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 23:18:14 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
391 lines
8.7 KiB
Plaintext
391 lines
8.7 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/orphan.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/orphan.carbon
|
|
|
|
// --- imports.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class ImportedC {}
|
|
class ImportedD(T: type) {}
|
|
|
|
interface ImportedY {}
|
|
interface ImportedZ(T: type) {}
|
|
|
|
constraint ImportedN(T: type) {}
|
|
|
|
class ImportedAnyParam[T: type](X: T) {}
|
|
|
|
// --- class_definition_missing.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// This is the first owning decl of C, so it can be an anchor name.
|
|
class C;
|
|
|
|
impl C as ImportedY {}
|
|
|
|
// --- class_definition_missing_for_self_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// This is the first owning decl of C, so it can be an anchor name.
|
|
class C;
|
|
|
|
impl ImportedD(C) as ImportedY {}
|
|
|
|
// --- class_definition_missing_for_interface_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// This is the first owning decl of C, so it can be an anchor name.
|
|
class C;
|
|
|
|
impl ImportedC as ImportedZ(C) {}
|
|
|
|
// --- fail_imported_class.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// CHECK:STDERR: fail_imported_class.carbon:[[@LINE+2]]:1-29: error: orphan `impl` found; something in the self-type or constraint must be defined in the same file [ImplIsOrphan]
|
|
// CHECK:STDERR:
|
|
impl ImportedC as ImportedY {}
|
|
|
|
// --- fail_imported_class_for_self_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// CHECK:STDERR: fail_imported_class_for_self_specific.carbon:[[@LINE+2]]:1-40: error: orphan `impl` found; something in the self-type or constraint must be defined in the same file [ImplIsOrphan]
|
|
// CHECK:STDERR:
|
|
impl ImportedD(ImportedC) as ImportedY {}
|
|
|
|
// --- fail_imported_class_for_interface_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// CHECK:STDERR: fail_imported_class_for_interface_specific.carbon:[[@LINE+2]]:1-40: error: orphan `impl` found; something in the self-type or constraint must be defined in the same file [ImplIsOrphan]
|
|
// CHECK:STDERR:
|
|
impl ImportedC as ImportedZ(ImportedC) {}
|
|
|
|
// --- class_definition_after.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C;
|
|
|
|
impl C as ImportedY {}
|
|
|
|
class C {}
|
|
|
|
// --- class_definition_after_for_self_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C;
|
|
|
|
impl ImportedD(C) as ImportedY {}
|
|
|
|
class C {}
|
|
|
|
// --- class_definition_after_for_interface_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C;
|
|
|
|
impl ImportedC as ImportedZ(C) {}
|
|
|
|
class C {}
|
|
|
|
// --- class_definition_before.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C {}
|
|
|
|
impl C as ImportedY {}
|
|
|
|
// --- class_definition_before_for_self_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C {}
|
|
|
|
impl ImportedD(C) as ImportedY {}
|
|
|
|
// --- class_definition_before_for_interface_specific.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C {}
|
|
|
|
impl ImportedC as ImportedZ(C) {}
|
|
|
|
// --- fail_generic_class_from_import.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// CHECK:STDERR: fail_generic_class_from_import.carbon:[[@LINE+2]]:1-47: error: orphan `impl` found; something in the self-type or constraint must be defined in the same file [ImplIsOrphan]
|
|
// CHECK:STDERR:
|
|
impl ImportedAnyParam(ImportedD) as ImportedY {}
|
|
|
|
// --- generic_class.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class D(T: type) {}
|
|
|
|
impl ImportedAnyParam(D) as ImportedY {}
|
|
|
|
// --- fail_generic_interface_from_import.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// CHECK:STDERR: fail_generic_interface_from_import.carbon:[[@LINE+2]]:1-47: error: orphan `impl` found; something in the self-type or constraint must be defined in the same file [ImplIsOrphan]
|
|
// CHECK:STDERR:
|
|
impl ImportedAnyParam(ImportedZ) as ImportedY {}
|
|
|
|
// --- generic_interface.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
interface Z(T: type) {}
|
|
|
|
impl ImportedAnyParam(Z) as ImportedY {}
|
|
|
|
// --- fail_generic_named_constraint_from_import.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// CHECK:STDERR: fail_generic_named_constraint_from_import.carbon:[[@LINE+2]]:1-47: error: orphan `impl` found; something in the self-type or constraint must be defined in the same file [ImplIsOrphan]
|
|
// CHECK:STDERR:
|
|
impl ImportedAnyParam(ImportedN) as ImportedY {}
|
|
|
|
// --- generic_named_constraint.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
constraint N(T: type) {}
|
|
|
|
impl ImportedAnyParam(N) as ImportedY {}
|
|
|
|
// --- todo_fail_orphan_in_class_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
// Neither {} nor Z are defined within or by the scope of `C`.
|
|
class C {
|
|
impl {} as Z {}
|
|
}
|
|
|
|
// --- valid_in_fn_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
fn F() {
|
|
class C {}
|
|
impl C as Z {}
|
|
}
|
|
|
|
// --- todo_fail_orphan_in_fn_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
// Neither {} nor Z are defined within or by the scope of `F`.
|
|
fn F() {
|
|
impl {} as Z {}
|
|
}
|
|
|
|
// --- valid_in_generic_fn_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
fn F(unused generic T: type) {
|
|
class C {}
|
|
impl C as Z {}
|
|
}
|
|
|
|
// --- fail_todo_orphan_in_generic_fn_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
// Neither {} nor Z are defined within or by the scope of `F`.
|
|
fn F(unused generic T: type) {
|
|
// TODO: The error should be about being an orphan, not an unused binding.
|
|
// CHECK:STDERR: fail_todo_orphan_in_generic_fn_scope.carbon:[[@LINE+2]]:3-16: error: `impl` with unused generic binding [ImplUnusedBinding]
|
|
// CHECK:STDERR:
|
|
impl {} as Z {}
|
|
}
|
|
|
|
// --- valid_in_block_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
fn F() {
|
|
if (true) {
|
|
class C {}
|
|
impl C as Z {}
|
|
}
|
|
}
|
|
|
|
// --- todo_fail_orphan_in_block_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {}
|
|
|
|
fn F() {
|
|
class C {}
|
|
// Neither C nor Z are defined within or by this if block scope.
|
|
if (true) {
|
|
impl C as Z {}
|
|
}
|
|
}
|
|
|
|
// --- name_defined_by_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C {
|
|
impl as ImportedY {}
|
|
};
|
|
|
|
// --- name_defined_in_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
fn F() {
|
|
class C {}
|
|
impl C as ImportedY {}
|
|
};
|
|
|
|
// --- name_defined_after_in_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
fn F() {
|
|
class C;
|
|
impl C as ImportedY {}
|
|
class C {}
|
|
};
|
|
|
|
// --- name_defined_in_nested_namespace_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
namespace N;
|
|
class N.C {}
|
|
|
|
impl N.C as ImportedY {}
|
|
|
|
// --- name_defined_after_in_nested_namespace_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
namespace N;
|
|
class N.C;
|
|
|
|
impl N.C as ImportedY {}
|
|
|
|
class N.C {}
|
|
|
|
// --- name_defined_in_nested_class_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C {
|
|
class D {}
|
|
}
|
|
impl C.D as ImportedY {}
|
|
|
|
// --- name_defined_after_in_nested_class_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
class C {
|
|
class D;
|
|
}
|
|
impl C.D as ImportedY {}
|
|
|
|
class C.D {}
|
|
|
|
// --- fail_todo_extern_class.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "use_extern_class";
|
|
|
|
// CHECK:STDERR: fail_todo_extern_class.carbon:[[@LINE+2]]:1-15: error: redeclaration of `class C` is redundant [RedeclRedundant]
|
|
// CHECK:STDERR: imported from: fail_todo_extern_class.carbon:[[@LINE-3]]:1 [InImport]
|
|
extern class C;
|
|
|
|
// --- fail_use_extern_class.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "imports";
|
|
|
|
// A non-owning decl of C.
|
|
// CHECK:STDERR: fail_use_extern_class.carbon:[[@LINE+4]]:1-38: note: previously declared here [RedeclPrevDecl]
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_use_extern_class.carbon:[[@LINE+2]]:1-38: error: semantics TODO: `extern library` [SemanticsTodo]
|
|
// CHECK:STDERR:
|
|
extern library "extern_class" class C;
|
|
|
|
// TODO: This should be an orphan `impl`. `C` is owned by `extern_class`, so it
|
|
// can't be an anchor name. No error will be emitted until `extern library` is
|
|
// implemented for classes.
|
|
impl C as ImportedY {}
|
|
|
|
// --- imported_first_owning_decl.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class ImportedClassDecl;
|
|
|
|
interface ImportedInterface {}
|
|
|
|
// --- todo_fail_imported_first_owning_decl.impl.carbon
|
|
impl library "[[@TEST_NAME]]";
|
|
|
|
// This is an owning decl, but not the first owning decl, which is in the api
|
|
// file. So it can not be an anchor name.
|
|
class ImportedClassDecl {}
|
|
|
|
// TODO: This should fail, there is no anchor name.
|
|
impl ImportedClassDecl as ImportedInterface {}
|