Files
carbon-lang/toolchain/check/testdata/impl/lookup/unused_generic_binding.carbon
T
Chandler Carruth 2c9739799b Render diagnostics through the terminal library (#7683)
Diagnostic rendering was part of the data model: `Loc::FormatLocation`
and
`Loc::FormatSnippet` wrote plain text to a stream, so no capability,
color, or
terminal width could reach them.

A diagnostic is now one message with labels, contexts, and location
information
attached, and `Diagnostics::Renderer` draws it into a
`Terminal::Buffer`. The
design is in `toolchain/docs/diagnostics_rendering.md` (#7668),
authoring in
`toolchain/docs/diagnostics.md`.

Before:

```
example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments
  Run0(1);
  ^~~~~~~
example.carbon:3:1: note: calling function declared here
fn Run0() {}
^~~~~~~~~~~
```

After:

```
error: 1 argument passed to function expecting 0 arguments
       ╭─┤ example.carbon:6:3
       ┆
     3 │ fn Run0() {}
       · ─────┬─────
       ·      ╰──┤ calling function declared here
       ┆
->   6 │   Run0(1);
       ·   ───────
       ╰────────────
```

`--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`.
File
tests use it; the rendering tests under `toolchain/diagnostics/testdata`
ask for
snippets.

C++ interop diagnostics are data now rather than text Clang drew:
`SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang
location is
marked as the point it names.

`StreamConsumer` moves to a `:renderer` target that `:emitter` does not
depend
on, keeping `common/terminal` out of `consumer.h`. Capabilities come
from the
file behind the error stream, so tests get plain ASCII.

`renderer_fuzzer` draws diagnostics built from fuzzer bytes with every
capability combination, since a shape the renderer doesn't expect must
never be
why the compiler dies while reporting a problem.

TODOs mark the follow-ups: line weights and crossing lines, wrapping
that keeps
a quoted type whole, and ordering diagnostics that share a byte offset.

Also: `IncorrectExtension`'s hint moves into its message, since its note
had no
location of its own, and `strip_noise` in `check_diagnostics.py` blanks
multi-line `#define`s instead of deleting them.

Assisted-by: Claude Code
2026-10-15 06:08:57 +00:00

150 lines
4.0 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/lookup/unused_generic_binding.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/lookup/unused_generic_binding.carbon
// --- fail_no_binding_used.carbon
library "[[@TEST_NAME]]";
interface I {
let T: type;
}
impl forall [U: type] U as I where .T = () {}
class C {}
// This impl can never deduce its implicit generic parameter `V`, which
// should be diagnosed.
//
// CHECK:STDERR: fail_no_binding_used.carbon:[[@LINE+2]]:13-21: error: `impl` with unused generic binding [ImplUnusedBinding]
// CHECK:STDERR:
impl forall [V: type] C as I where .T = {.unmatched: ()} {}
fn F() {
// This shows that the first impl declaration was matched even though the
// second is more specific. But since it has an unused generic parameter, it
// will never match. If the second was matched, this line would not type
// check.
let unused x: C.(I.T) = ();
}
// --- fail_one_binding_unused.carbon
library "[[@TEST_NAME]]";
interface I {
let T: type;
}
impl forall [U: type] U as I where .T = () {}
class C {}
// This impl can never deduce its implicit generic parameter `W`, which
// should be diagnosed.
// https://discord.com/channels/655572317891461132/941071822756143115/1354563497731686550
//
// CHECK:STDERR: fail_one_binding_unused.carbon:[[@LINE+2]]:13-30: error: `impl` with unused generic binding [ImplUnusedBinding]
// CHECK:STDERR:
impl forall [V: type, W: type] V as I where .T = {.unmatched: ()} {}
fn F() {
// This shows that the first impl declaration was matched even though the
// second is more specific. If the second was matched, it would not type
// check.
let unused x: C.(I.T) = ();
}
// --- fail_inherited_binding_unused.carbon
library "[[@TEST_NAME]]";
interface I {
let T: type;
}
impl forall [U: type] U as I where .T = () {}
class C(U: type) {
// This impl can never deduce its inherited generic binding `U`, which
// should be diagnosed.
//
// TODO: We should point the diagnostic at the binding `U` in C.
//
// CHECK:STDERR: fail_inherited_binding_unused.carbon:[[@LINE+2]]:3-47: error: `impl` with unused generic binding [ImplUnusedBinding]
// CHECK:STDERR:
impl C(()) as I where .T = {.unmatched: ()} {}
}
fn F() {
let unused x: C(()).(I.T) = ();
}
// --- fail_inherited_binding_in_forall_unused.carbon
library "[[@TEST_NAME]]";
interface I {
let T: type;
}
impl forall [U: type] U as I where .T = () {}
class C(U: type) {
// This impl can never deduce its inherited generic binding `U`, which
// should be diagnosed.
//
// TODO: We should point the diagnostic at the binding `U` in C.
//
// CHECK:STDERR: fail_inherited_binding_in_forall_unused.carbon:[[@LINE+2]]:15-23: error: `impl` with unused generic binding [ImplUnusedBinding]
// CHECK:STDERR:
impl forall [V: type] C(V) as I where .T = {.unmatched: ()} {}
}
fn F() {
let unused x: C(()).(I.T) = ();
}
// --- inherited_binding_used.carbon
library "[[@TEST_NAME]]";
interface I {
let T: type;
}
impl forall [U: type] U as I where .T = {.unmatched: ()} {}
class C(U: type) {
// `U` can be deduced here, so no diagnostic issued.
impl C(U) as I where .T = () {}
}
fn F() {
// The `impl` inside C is matched here.
let unused x: C(()).(I.T) = ();
}
// --- inherited_binding_in_forall_used.carbon
library "[[@TEST_NAME]]";
interface I(W: type) {
let T: type;
}
impl forall [U: type] U as I(U) where .T = {.unmatched: ()} {}
class C(U: type) {
// `U` can be deduced here, so no diagnostic issued.
impl forall [V: type] C(U) as I(V) where .T = () {}
}
fn F() {
// The `impl` inside C is matched here.
let unused x: C(()).(I({}).T) = ();
}