Files
carbon-lang/toolchain/check/testdata/impl/impl_where_redecl.carbon
T
Chandler Carruth 2c9739799b Render diagnostics through the terminal library (#7683)
Diagnostic rendering was part of the data model: `Loc::FormatLocation`
and
`Loc::FormatSnippet` wrote plain text to a stream, so no capability,
color, or
terminal width could reach them.

A diagnostic is now one message with labels, contexts, and location
information
attached, and `Diagnostics::Renderer` draws it into a
`Terminal::Buffer`. The
design is in `toolchain/docs/diagnostics_rendering.md` (#7668),
authoring in
`toolchain/docs/diagnostics.md`.

Before:

```
example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments
  Run0(1);
  ^~~~~~~
example.carbon:3:1: note: calling function declared here
fn Run0() {}
^~~~~~~~~~~
```

After:

```
error: 1 argument passed to function expecting 0 arguments
       ╭─┤ example.carbon:6:3
       ┆
     3 │ fn Run0() {}
       · ─────┬─────
       ·      ╰──┤ calling function declared here
       ┆
->   6 │   Run0(1);
       ·   ───────
       ╰────────────
```

`--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`.
File
tests use it; the rendering tests under `toolchain/diagnostics/testdata`
ask for
snippets.

C++ interop diagnostics are data now rather than text Clang drew:
`SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang
location is
marked as the point it names.

`StreamConsumer` moves to a `:renderer` target that `:emitter` does not
depend
on, keeping `common/terminal` out of `consumer.h`. Capabilities come
from the
file behind the error stream, so tests get plain ASCII.

`renderer_fuzzer` draws diagnostics built from fuzzer bytes with every
capability combination, since a shape the renderer doesn't expect must
never be
why the compiler dies while reporting a problem.

TODOs mark the follow-ups: line weights and crossing lines, wrapping
that keeps
a quoted type whole, and ordering diagnostics that share a byte offset.

Also: `IncorrectExtension`'s hint moves into its message, since its note
had no
location of its own, and `strip_noise` in `check_diagnostics.py` blanks
multi-line `#define`s instead of deleting them.

Assisted-by: Claude Code
2026-10-15 06:08:57 +00:00

71 lines
2.6 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/impl_where_redecl.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/impl_where_redecl.carbon
// `impl` declarations only match when they are the same syntactically.
// --- fail_match_with_associated_type.carbon
library "[[@TEST_NAME]]";
interface I { let T: type; }
constraint N(U: type) {}
// CHECK:STDERR: fail_match_with_associated_type.carbon:[[@LINE+2]]:1-27: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl () as I where .T = {};
impl () as I where .T = {} and .T impls N(.Self) {}
// CHECK:STDERR: fail_match_with_associated_type.carbon:[[@LINE+2]]:1-13: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl {} as I;
impl {} as I where .T = {} and .T impls N(.Self) {}
// CHECK:STDERR: fail_match_with_associated_type.carbon:[[@LINE+2]]:1-52: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl ({},) as I where .T = {} and .T impls N(.Self);
impl ({},) as I where .T = {} {}
// --- fail_match_with_empty_interface.carbon
library "[[@TEST_NAME]]";
interface J {}
constraint N {}
// CHECK:STDERR: fail_match_with_empty_interface.carbon:[[@LINE+2]]:1-13: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl () as J;
impl () as J where .Self impls type and .Self impls N {}
// CHECK:STDERR: fail_match_with_empty_interface.carbon:[[@LINE+2]]:1-54: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl {} as J where .Self impls type and .Self impls N;
impl {} as J {}
// --- fail_parens_other_nesting.carbon
library "[[@TEST_NAME]]";
interface K {}
// CHECK:STDERR: fail_parens_other_nesting.carbon:[[@LINE+2]]:1-61: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl {} as (K where .Self impls type) where .Self impls type;
impl {} as (K where .Self impls type) {}
// --- fail_other_nesting.carbon
library "[[@TEST_NAME]]";
interface L {}
// CHECK:STDERR: fail_other_nesting.carbon:[[@LINE+2]]:1-61: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR:
impl () as (L where .Self impls type) where .Self impls type;
impl () as L {}