mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-17 00:28:25 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
185 lines
5.6 KiB
Plaintext
185 lines
5.6 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/facet/require_invalid.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/facet/require_invalid.carbon
|
|
|
|
// --- fail_require_outside_scope.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
// CHECK:STDERR: fail_require_outside_scope.carbon:[[@LINE+2]]:1-7: error: `require` can only be used in an `interface` or `constraint` [RequireInWrongScope]
|
|
// CHECK:STDERR:
|
|
require impls Y;
|
|
|
|
// --- fail_require_in_class.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
class C {
|
|
// CHECK:STDERR: fail_require_in_class.carbon:[[@LINE+2]]:3-9: error: `require` can only be used in an `interface` or `constraint` [RequireInWrongScope]
|
|
// CHECK:STDERR:
|
|
require impls Y;
|
|
}
|
|
|
|
// --- fail_require_in_fn.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
fn F() {
|
|
// require is not allowed outside of `interface` or `constraint`.
|
|
//
|
|
// CHECK:STDERR: fail_require_in_fn.carbon:[[@LINE+4]]:3-9: error: expected expression [ExpectedExpr]
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_require_in_fn.carbon:[[@LINE+2]]:3-9: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
|
|
// CHECK:STDERR:
|
|
require impls Y;
|
|
}
|
|
|
|
// --- fail_require_in_nested_class.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
interface Z {
|
|
// TODO: Add `default` modifier.
|
|
fn F() {
|
|
class C {
|
|
// CHECK:STDERR: fail_require_in_nested_class.carbon:[[@LINE+2]]:7-13: error: `require` can only be used in an `interface` or `constraint` [RequireInWrongScope]
|
|
// CHECK:STDERR:
|
|
require impls Y;
|
|
}
|
|
}
|
|
}
|
|
|
|
// --- fail_require_in_nested_fn.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
interface Z {
|
|
// TODO: Add `default` modifier.
|
|
fn F() {
|
|
// require is not allowed outside of `interface` or `constraint`.
|
|
//
|
|
// CHECK:STDERR: fail_require_in_nested_fn.carbon:[[@LINE+4]]:5-11: error: expected expression [ExpectedExpr]
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_require_in_nested_fn.carbon:[[@LINE+2]]:5-11: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
|
|
// CHECK:STDERR:
|
|
require impls Y;
|
|
}
|
|
}
|
|
|
|
// --- fail_errors_in_require_still_found.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class C {
|
|
// The `require` is diagnosed as being in the wrong place. But we can still
|
|
// diagnose issues inside the decl too.
|
|
//
|
|
// CHECK:STDERR: fail_errors_in_require_still_found.carbon:[[@LINE+4]]:3-9: error: `require` can only be used in an `interface` or `constraint` [RequireInWrongScope]
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_errors_in_require_still_found.carbon:[[@LINE+2]]:17: error: name `Y` not found [NameNotFound]
|
|
// CHECK:STDERR:
|
|
require impls Y;
|
|
}
|
|
|
|
// --- fail_extend_require_type.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
interface Z {
|
|
// CHECK:STDERR: fail_extend_require_type.carbon:[[@LINE+2]]:18-19: error: `extend require impls` with explicit type [RequireImplsExtendWithExplicitSelf]
|
|
// CHECK:STDERR:
|
|
extend require () impls Y;
|
|
|
|
fn F() {
|
|
// The erroneous self-type for an `extend` causes the error to be propagated
|
|
// into the interface scope, which prevents errors if we fail to find a name
|
|
// in that scope.
|
|
Self.A;
|
|
}
|
|
}
|
|
|
|
// --- fail_require_with_nonexistent_type.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
interface Z {
|
|
// CHECK:STDERR: fail_require_with_nonexistent_type.carbon:[[@LINE+2]]:11-21: error: name `nonexistent` not found [NameNotFound]
|
|
// CHECK:STDERR:
|
|
require nonexistent impls Y;
|
|
|
|
fn F() {
|
|
// The name lookup error still happens, since the `require` is not `extend`.
|
|
// CHECK:STDERR: fail_require_with_nonexistent_type.carbon:[[@LINE+2]]:5-10: error: member name `A` not found in `Z` [MemberNameNotFoundInSpecificScope]
|
|
// CHECK:STDERR:
|
|
Self.A;
|
|
}
|
|
}
|
|
|
|
// --- fail_extend_require_with_nonexistent_type.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
interface Z {
|
|
// CHECK:STDERR: fail_extend_require_with_nonexistent_type.carbon:[[@LINE+2]]:18-28: error: name `nonexistent` not found [NameNotFound]
|
|
// CHECK:STDERR:
|
|
extend require nonexistent impls Y;
|
|
|
|
fn F() {
|
|
// The erroneous self-type for an `extend` causes the error to be propagated
|
|
// into the interface scope, which prevents errors if we fail to find a name
|
|
// in that scope.
|
|
Self.A;
|
|
}
|
|
}
|
|
|
|
// --- fail_extend_require_with_nonexistent_type_pointer.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Y {}
|
|
|
|
interface Z {
|
|
// CHECK:STDERR: fail_extend_require_with_nonexistent_type_pointer.carbon:[[@LINE+2]]:18-28: error: name `nonexistent` not found [NameNotFound]
|
|
// CHECK:STDERR:
|
|
extend require nonexistent* impls Y;
|
|
|
|
fn F() {
|
|
// The erroneous self-type for an `extend` causes the error to be propagated
|
|
// into the interface scope, which prevents errors if we fail to find a name
|
|
// in that scope.
|
|
Self.A;
|
|
}
|
|
}
|
|
|
|
// --- fail_impl_mismatch_named_constraint_rewrites.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z { let Z0: type; }
|
|
|
|
constraint M {
|
|
require impls Z where .Z0 = {};
|
|
}
|
|
|
|
fn G() {
|
|
class C {}
|
|
// .Z0 has the wrong type for M.
|
|
impl C as Z where .Z0 = () {}
|
|
// CHECK:STDERR: fail_impl_mismatch_named_constraint_rewrites.carbon:[[@LINE+2]]:3-8: error: cannot convert type `C` into type implementing `M` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR:
|
|
C as M;
|
|
}
|