Files
carbon-lang/toolchain/check/testdata/class/fail_incomplete.carbon
T
Chandler Carruth 2c9739799b Render diagnostics through the terminal library (#7683)
Diagnostic rendering was part of the data model: `Loc::FormatLocation`
and
`Loc::FormatSnippet` wrote plain text to a stream, so no capability,
color, or
terminal width could reach them.

A diagnostic is now one message with labels, contexts, and location
information
attached, and `Diagnostics::Renderer` draws it into a
`Terminal::Buffer`. The
design is in `toolchain/docs/diagnostics_rendering.md` (#7668),
authoring in
`toolchain/docs/diagnostics.md`.

Before:

```
example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments
  Run0(1);
  ^~~~~~~
example.carbon:3:1: note: calling function declared here
fn Run0() {}
^~~~~~~~~~~
```

After:

```
error: 1 argument passed to function expecting 0 arguments
       ╭─┤ example.carbon:6:3
       ┆
     3 │ fn Run0() {}
       · ─────┬─────
       ·      ╰──┤ calling function declared here
       ┆
->   6 │   Run0(1);
       ·   ───────
       ╰────────────
```

`--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`.
File
tests use it; the rendering tests under `toolchain/diagnostics/testdata`
ask for
snippets.

C++ interop diagnostics are data now rather than text Clang drew:
`SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang
location is
marked as the point it names.

`StreamConsumer` moves to a `:renderer` target that `:emitter` does not
depend
on, keeping `common/terminal` out of `consumer.h`. Capabilities come
from the
file behind the error stream, so tests get plain ASCII.

`renderer_fuzzer` draws diagnostics built from fuzzer bytes with every
capability combination, since a shape the renderer doesn't expect must
never be
why the compiler dies while reporting a problem.

TODOs mark the follow-ups: line weights and crossing lines, wrapping
that keeps
a quoted type whole, and ordering diagnostics that share a byte offset.

Also: `IncorrectExtension`'s hint moves into its message, since its note
had no
location of its own, and `strip_noise` in `check_diagnostics.py` blanks
multi-line `#define`s instead of deleting them.

Assisted-by: Claude Code
2026-10-15 06:08:57 +00:00

105 lines
5.2 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/class/fail_incomplete.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/class/fail_incomplete.carbon
// --- fail_forward_decl.carbon
library "[[@TEST_NAME]]";
class Class;
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:4-8: error: cannot declare a member of incomplete class `Class` [QualifiedDeclInIncompleteClassScope]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-3]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
fn Class.Function() {}
fn CallClassFunction() {
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:3-16: error: member access into incomplete class `Class` [QualifiedExprInIncompleteClassScope]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-9]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
Class.Function();
}
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:17-21: error: binding pattern has incomplete type `Class` in name binding declaration [IncompleteTypeInBindingDecl]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-15]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
var global_var: Class;
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:24-31: error: function returns incomplete type `Class` [IncompleteTypeInFunctionReturnType]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-20]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
fn ConvertFromStruct() -> Class { return {}; }
fn G(p: Class*) -> () {
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:10-13: error: member access into object of incomplete type `Class` [IncompleteTypeInMemberAccess]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-26]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
return p->n;
}
fn MemberAccess(p: Class*) -> () {
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:11-12: error: member access into object of incomplete type `Class` [IncompleteTypeInMemberAccess]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-33]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
return (*p).n;
}
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:20-27: error: function returns incomplete type `Class` [IncompleteTypeInFunctionReturnType]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-39]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
fn Copy(p: Class*) -> Class {
return *p;
}
fn Let(p: Class*) {
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+3]]:17-21: error: binding pattern has incomplete type `Class` in name binding declaration [IncompleteTypeInBindingDecl]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-47]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR:
let unused c: Class = *p;
}
fn TakeIncomplete(c: Class);
fn ReturnIncomplete() -> Class;
fn CallTakeIncomplete(p: Class*) {
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+4]]:18-19: error: forming value of incomplete type `Class` [IncompleteTypeInValueConversion]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-58]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-7]]:19-26: note: initializing function parameter [InCallToFunctionParam]
// CHECK:STDERR:
TakeIncomplete(*p);
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+4]]:18-19: error: forming value of incomplete type `Class` [IncompleteTypeInValueConversion]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-64]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-13]]:19-26: note: initializing function parameter [InCallToFunctionParam]
// CHECK:STDERR:
TakeIncomplete({});
}
fn CallReturnIncomplete() {
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE+4]]:3-20: error: function returns incomplete type `Class` [IncompleteTypeInFunctionReturnType]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-72]]:1-12: note: class was forward declared here [ClassForwardDeclaredHere]
// CHECK:STDERR: fail_forward_decl.carbon:[[@LINE-19]]:23-30: note: return type declared here [IncompleteReturnTypeHere]
// CHECK:STDERR:
ReturnIncomplete();
}
// --- fail_in_definition.carbon
library "[[@TEST_NAME]]";
class C {
// CHECK:STDERR: fail_in_definition.carbon:[[@LINE+3]]:10: error: binding pattern has incomplete type `C` in name binding declaration [IncompleteTypeInBindingDecl]
// CHECK:STDERR: fail_in_definition.carbon:[[@LINE-2]]:1-9: note: class is incomplete within its definition [ClassIncompleteWithinDefinition]
// CHECK:STDERR:
var c: C;
}