mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 08:05:49 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
45 lines
1.5 KiB
C++
45 lines
1.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/handle.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
auto HandleTupleLiteralStart(Context& context,
|
|
Parse::TupleLiteralStartId node_id) -> bool {
|
|
context.node_stack().Push(node_id);
|
|
context.param_and_arg_refs_stack().Push();
|
|
return true;
|
|
}
|
|
|
|
auto HandleTupleLiteralComma(Context& context,
|
|
Parse::TupleLiteralCommaId /*node_id*/) -> bool {
|
|
context.param_and_arg_refs_stack().ApplyComma();
|
|
return true;
|
|
}
|
|
|
|
auto HandleTupleLiteral(Context& context, Parse::TupleLiteralId node_id)
|
|
-> bool {
|
|
auto refs_id = context.param_and_arg_refs_stack().EndAndPop(
|
|
Parse::NodeKind::TupleLiteralStart);
|
|
|
|
context.node_stack()
|
|
.PopAndDiscardSoloNodeId<Parse::NodeKind::TupleLiteralStart>();
|
|
const auto& inst_block = context.inst_blocks().Get(refs_id);
|
|
llvm::SmallVector<SemIR::TypeId> type_ids;
|
|
type_ids.reserve(inst_block.size());
|
|
for (auto inst : inst_block) {
|
|
type_ids.push_back(context.insts().Get(inst).type_id());
|
|
}
|
|
auto type_id = context.GetTupleType(type_ids);
|
|
|
|
auto value_id = context.AddInst<SemIR::TupleLiteral>(
|
|
node_id, {.type_id = type_id, .elements_id = refs_id});
|
|
context.node_stack().Push(node_id, value_id);
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|