mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 13:31:04 +01:00
Jon Ross-Perkins
db324c7247
This doesn't actually track whether a declaration is `extern`. It does, however: - Factor out and expand merge support for classes, sharing handling with functions. - This makes the ClassRedefinition diagnostic redundant, as the redeclaration checking overlaps. - Add partial `extern` handling to class handling; just some verifications of correct use. - Factor out `extern` on member handling for sharing with `fn`. - Fixes a bug in import_ref where a class's definition_id wasn't assigned when defining. This changes how a redefinition is handled (replaced, rather than merged). I don't know whether that's ideal, but I think it results in easy-to-understand consequences, and it's more consistent with how `fn` works. There's enough work here that this felt like a decent cut point, particularly as the amount of work to actually add `extern` tracking will be significant.
67 lines
2.9 KiB
C++
67 lines
2.9 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_CHECK_MODIFIERS_H_
|
|
#define CARBON_TOOLCHAIN_CHECK_MODIFIERS_H_
|
|
|
|
#include "toolchain/check/context.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
// Reports a diagnostic if access control modifiers on this are not allowed for
|
|
// a declaration in `target_scope_id`, and updates the declaration state in
|
|
// `context`.
|
|
//
|
|
// `target_scope_id` may be Invalid for a declaration in a block scope.
|
|
auto CheckAccessModifiersOnDecl(Context& context, Lex::TokenKind decl_kind,
|
|
SemIR::NameScopeId target_scope_id) -> void;
|
|
|
|
// Reports a diagnostic if the method function modifiers `abstract`, `virtual`,
|
|
// or `impl` are present but not permitted on a function declaration in
|
|
// `target_scope_id`.
|
|
//
|
|
// `target_scope_id` may be Invalid for a declaration in a block scope.
|
|
auto CheckMethodModifiersOnFunction(Context& context,
|
|
SemIR::NameScopeId target_scope_id) -> void;
|
|
|
|
// Like `LimitModifiersOnDecl`, except says which modifiers are forbidden, and a
|
|
// `context_string` (and optional `context_loc_id`) specifying the context in
|
|
// which those modifiers are forbidden.
|
|
// TODO: Take another look at diagnostic phrasing for callers.
|
|
auto ForbidModifiersOnDecl(Context& context, KeywordModifierSet forbidden,
|
|
Lex::TokenKind decl_kind,
|
|
llvm::StringRef context_string,
|
|
SemIR::LocId context_loc_id = SemIR::LocId::Invalid)
|
|
-> void;
|
|
|
|
// Reports a diagnostic (using `decl_kind`) if modifiers on this declaration are
|
|
// not in `allowed`. Updates the declaration state in
|
|
// `context.decl_state_stack()`.
|
|
inline auto LimitModifiersOnDecl(Context& context, KeywordModifierSet allowed,
|
|
Lex::TokenKind decl_kind) -> void {
|
|
ForbidModifiersOnDecl(context, ~allowed, decl_kind, "");
|
|
}
|
|
|
|
// Restricts the `extern` modifier to only be used on namespace-scoped
|
|
// declarations, diagnosing and removing it on:
|
|
// - `extern` on a definition.
|
|
// - `extern` on a scoped entity.
|
|
auto RestrictExternModifierOnDecl(Context& context, Lex::TokenKind decl_kind,
|
|
SemIR::NameScopeId target_scope_id,
|
|
bool is_definition) -> void;
|
|
|
|
// Report a diagonostic if `default` and `final` modifiers are used on
|
|
// declarations where they are not allowed. Right now they are only allowed
|
|
// inside interfaces.
|
|
//
|
|
// `target_scope_id` may be Invalid for a declaration in a block scope.
|
|
auto RequireDefaultFinalOnlyInInterfaces(Context& context,
|
|
Lex::TokenKind decl_kind,
|
|
SemIR::NameScopeId target_scope_id)
|
|
-> void;
|
|
|
|
} // namespace Carbon::Check
|
|
|
|
#endif // CARBON_TOOLCHAIN_CHECK_MODIFIERS_H_
|