mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 15:48:10 +00:00
Jon Ross-PerkinsandDana Jansens
c3b0c2e425
Suggested by zygoloid while looking at #5678 ``` CHECK failure at toolchain/lower/context.cpp:62: !llvm::verifyModule(*llvm_module_, &errs): Verifier errors: Instruction does not dominate all uses! %.loc17_46.1.temp = alloca { i1, i32, i32 }, align 8, !dbg !13 %tuple.elem0.loc17_46.2.tuple.elem = getelementptr inbounds nuw { i1, i32, i32 }, ptr %.loc17_46.1.temp, i32 0, i32 0, !dbg !13 Instruction does not dominate all uses! %.loc17_46.1.temp = alloca { i1, i32, i32 }, align 8, !dbg !13 %tuple.elem1.loc17_46.2.tuple.elem = getelementptr inbounds nuw { i1, i32, i32 }, ptr %.loc17_46.1.temp, i32 0, i32 1, !dbg !13 Instruction does not dominate all uses! %.loc17_46.1.temp = alloca { i1, i32, i32 }, align 8, !dbg !13 %tuple.elem2.loc17_46.2.tuple.elem = getelementptr inbounds nuw { i1, i32, i32 }, ptr %.loc17_46.1.temp, i32 0, i32 2, !dbg !13 ``` Adds a `--llvm-verifier` flag to be able to turn this off easily, particularly for debugging the LLVM IR. The call workaround is due to a verifier requirement `inlinable function call in a function with debug info must have a !dbg location`. It specifically comes up for the `++x` case, with `%1 = call i32 @"_CConvert.8b3d5d6a6c17be04:ImplicitAs.Core.b88d1103f417c6d4"(i32 %other)`. I think #5397 is in the direction of a fix for that, but #5397 was set aside because it puts the debug info in too many places. Instead, address this by adding a stub location for calls that don't have a good location. I'm deliberately putting this next to the TODO so that it's easier to understand the association. --------- Co-authored-by: Dana Jansens <danakj@orodu.net>
96 lines
2.5 KiB
C++
96 lines
2.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_DRIVER_COMPILE_SUBCOMMAND_H_
|
|
#define CARBON_TOOLCHAIN_DRIVER_COMPILE_SUBCOMMAND_H_
|
|
|
|
#include "common/command_line.h"
|
|
#include "common/error.h"
|
|
#include "common/ostream.h"
|
|
#include "llvm/ADT/SmallVector.h"
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "toolchain/driver/codegen_options.h"
|
|
#include "toolchain/driver/driver_env.h"
|
|
#include "toolchain/driver/driver_subcommand.h"
|
|
|
|
namespace Carbon {
|
|
|
|
// Options for the compile subcommand.
|
|
//
|
|
// See the implementation of `Build` for documentation on members.
|
|
struct CompileOptions {
|
|
enum class Phase : int8_t {
|
|
Lex,
|
|
Parse,
|
|
Check,
|
|
Lower,
|
|
CodeGen,
|
|
};
|
|
|
|
enum class DumpSemIRRanges : int8_t {
|
|
IfPresent,
|
|
Only,
|
|
Ignore,
|
|
};
|
|
|
|
friend auto operator<<(llvm::raw_ostream& out, Phase phase)
|
|
-> llvm::raw_ostream&;
|
|
|
|
auto Build(CommandLine::CommandBuilder& b) -> void;
|
|
|
|
CodegenOptions codegen_options;
|
|
|
|
Phase phase;
|
|
DumpSemIRRanges dump_sem_ir_ranges;
|
|
|
|
llvm::StringRef output_filename;
|
|
llvm::SmallVector<llvm::StringRef> input_filenames;
|
|
|
|
bool asm_output = false;
|
|
bool force_obj_output = false;
|
|
bool custom_core = false;
|
|
bool dump_shared_values = false;
|
|
bool dump_tokens = false;
|
|
bool omit_file_boundary_tokens = false;
|
|
bool dump_parse_tree = false;
|
|
bool dump_raw_sem_ir = false;
|
|
bool dump_sem_ir = false;
|
|
bool dump_llvm_ir = false;
|
|
bool dump_asm = false;
|
|
bool dump_mem_usage = false;
|
|
bool dump_timings = false;
|
|
bool stream_errors = false;
|
|
bool preorder_parse_tree = false;
|
|
bool builtin_sem_ir = false;
|
|
bool prelude_import = false;
|
|
bool include_debug_info = true;
|
|
bool run_llvm_verifier = true;
|
|
|
|
llvm::SmallVector<llvm::StringRef> exclude_dump_file_prefixes;
|
|
};
|
|
|
|
// Implements the compile subcommand of the driver.
|
|
class CompileSubcommand : public DriverSubcommand {
|
|
public:
|
|
explicit CompileSubcommand();
|
|
|
|
auto BuildOptions(CommandLine::CommandBuilder& b) -> void override {
|
|
options_.Build(b);
|
|
}
|
|
|
|
auto Run(DriverEnv& driver_env) -> DriverResult override;
|
|
|
|
private:
|
|
// Does custom validation of the compile-subcommand options structure beyond
|
|
// what the command line parsing library supports. Diagnoses and returns false
|
|
// on failure.
|
|
auto ValidateOptions(Diagnostics::NoLocEmitter& emitter) const -> bool;
|
|
|
|
CompileOptions options_;
|
|
};
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_DRIVER_COMPILE_SUBCOMMAND_H_
|