josh11bandJosh L 6dbeda612a where check stage, step 3: some type checking (#4364) ...

With this, we now check:

* The left argument to `where` is a facet type
* The right argument of a rewrite (`=`) requirement converts to the type
of the left argument.
* The left argument of an `impls` requirement is a type and the right
argument is a facet type.

No checking is done for `==` constraints yet.

In addition, make the "is facet type" query into its own function and
fix some comments noticed as part of this change.

This change reveals that accessing the members of a facet, like `.Self`,
isn't doing the right thing, and will have to be fixed in a follow-on
PR. Some tests have been adjusted or disabled as a result.

---------

Co-authored-by: Josh L <josh11b@users.noreply.github.com>

2024-10-05 01:03:43 +00:00

..

alias

Add comma between the arguments to the bind_symbolic_name instruction (#4358)

2024-10-01 23:58:30 +00:00

array

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

as

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

basics

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

builtins

Add comma between the arguments to the bind_symbolic_name instruction (#4358)

2024-10-01 23:58:30 +00:00

class

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

const

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

eval

Add comma between the arguments to the bind_symbolic_name instruction (#4358)

2024-10-01 23:58:30 +00:00

expr_category

Initial support for binding patterns in SemIR (#4221)

2024-09-25 19:12:58 +00:00

function

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

global

Initial support for binding patterns in SemIR (#4221)

2024-09-25 19:12:58 +00:00

if

Initial support for binding patterns in SemIR (#4221)

2024-09-25 19:12:58 +00:00

if_expr

Initial support for binding patterns in SemIR (#4221)

2024-09-25 19:12:58 +00:00

impl

where check stage, step 3: some type checking (#4364)

2024-10-05 01:03:43 +00:00

index

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

interface

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

ir

Initial support for binding patterns in SemIR (#4221)

2024-09-25 19:12:58 +00:00

let

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

namespace

Add comma between the arguments to the bind_symbolic_name instruction (#4358)

2024-10-01 23:58:30 +00:00

operators

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

package_expr

Initial support for binding patterns in SemIR (#4221)

2024-09-25 19:12:58 +00:00

packages

Add comma between the arguments to the bind_symbolic_name instruction (#4358)

2024-10-01 23:58:30 +00:00

pointer

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

return

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

struct

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

tuple

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

var

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00

where_expr

where check stage, step 3: some type checking (#4364)

2024-10-05 01:03:43 +00:00

while

Assign a name to interface_type instructions. (#4369)

2024-10-04 23:06:24 +00:00