mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 06:15:08 +01:00
Jon Ross-Perkins
6b5eb1a101
High level, replacing `Id::Invalid` with `Id::None` and `Id::is_valid` with `Id::has_value` for clarity, as discussed [here](https://discord.com/channels/655572317891461132/655578254970716160/1331664574545395794). The `IntId` refactoring is needed together with `AnyIdBase` because it's also used with `ValueStore`. Note, trying to be careful not to rewrite `EnumBase::InvalidIndex`, or `is_valid` in general (e.g., `IdKind::is_valid`). I've tried to sequence commits here: 1. Automatic replacements: - `((?:Id|Index)(?: |::|\(|Base(?:\(|::)))Invalid((?:Index)?\W)` -> `$1None$2` - `<invalid>` -> `<none>` - `InvalidNodeId` -> `NoneNodeId` - `/\*invalid\*/` -> `/*none*/` - `id((?:_|\(\))(?:\.|->))is_valid` -> `id$1has_value` 2. Manual edits: - In `int.h` and `int_test.cpp` - `IntT` has `is_value`, which I'm renaming to `is_embedded_value`. - Manual edits to comments in this file. - `AnyIdBase` and `IdBase` - Declaration of `is_valid` -> `has_value`, `InvalidIndex` -> `NoneIndex`. - In `ids.h` and `ids.cpp` - `is_valid` -> `has_value` - `// An explicitly invalid ID.` -> `// An ID with no value.`; similar for index - Various math on `InvalidIndex` -> `NoneIndex` - Various mentions of "valid" in comments - In `value_store.h`, for `IdT::Invalid`, plus one comment - In `impl.h` and `tokenized_buffer.h`, we had different initialization of `::None` values (versus `ids.h` syntax) that I fixed manually. - Spot checks to compile - Particularly where `is_valid` replacements didn't catch spots due to different naming. 3. Autoupdate tests 4. verbose.carbon (NOAUTOUPDATE) 5. Comment spot checks Note there are probably other mentions of "Invalid" that should be swept up, but I'd like to argue for merging and separating out remaining cleanup since this is so sweeping (and likely to hit merge conflicts from churn). We'll probably have lingering mentions of "invalid" for a bit regardless, just because there are uses of "invalid" in non-Id APIs.
115 lines
3.7 KiB
C++
115 lines
3.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/sem_ir/function.h"
|
|
|
|
#include "toolchain/sem_ir/file.h"
|
|
#include "toolchain/sem_ir/generic.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
auto GetCalleeFunction(const File& sem_ir, InstId callee_id) -> CalleeFunction {
|
|
CalleeFunction result = {.function_id = FunctionId::None,
|
|
.enclosing_specific_id = SpecificId::None,
|
|
.resolved_specific_id = SpecificId::None,
|
|
.self_id = InstId::None,
|
|
.is_error = false};
|
|
|
|
if (auto specific_function =
|
|
sem_ir.insts().TryGetAs<SpecificFunction>(callee_id)) {
|
|
result.resolved_specific_id = specific_function->specific_id;
|
|
callee_id = specific_function->callee_id;
|
|
}
|
|
|
|
if (auto bound_method = sem_ir.insts().TryGetAs<BoundMethod>(callee_id)) {
|
|
result.self_id = bound_method->object_id;
|
|
callee_id = bound_method->function_decl_id;
|
|
}
|
|
|
|
// Identify the function we're calling.
|
|
auto val_id = sem_ir.constant_values().GetConstantInstId(callee_id);
|
|
if (!val_id.has_value()) {
|
|
return result;
|
|
}
|
|
auto val_inst = sem_ir.insts().Get(val_id);
|
|
auto struct_val = val_inst.TryAs<StructValue>();
|
|
if (!struct_val) {
|
|
result.is_error = val_inst.type_id() == SemIR::ErrorInst::SingletonTypeId;
|
|
return result;
|
|
}
|
|
auto fn_type = sem_ir.types().TryGetAs<FunctionType>(struct_val->type_id);
|
|
if (!fn_type) {
|
|
return result;
|
|
}
|
|
|
|
result.function_id = fn_type->function_id;
|
|
result.enclosing_specific_id = fn_type->specific_id;
|
|
return result;
|
|
}
|
|
|
|
auto Function::ParamPatternInfo::GetNameId(const File& sem_ir) -> NameId {
|
|
return sem_ir.entity_names().Get(entity_name_id).name_id;
|
|
}
|
|
|
|
auto Function::GetParamPatternInfoFromPatternId(const File& sem_ir,
|
|
InstId pattern_id)
|
|
-> ParamPatternInfo {
|
|
auto inst_id = pattern_id;
|
|
auto inst = sem_ir.insts().Get(inst_id);
|
|
|
|
if (auto addr_pattern = inst.TryAs<SemIR::AddrPattern>()) {
|
|
inst_id = addr_pattern->inner_id;
|
|
inst = sem_ir.insts().Get(inst_id);
|
|
}
|
|
|
|
auto param_pattern_id = inst_id;
|
|
auto param_pattern_inst = inst.As<SemIR::AnyParamPattern>();
|
|
|
|
inst_id = param_pattern_inst.subpattern_id;
|
|
inst = sem_ir.insts().Get(inst_id);
|
|
|
|
auto binding_pattern = inst.As<AnyBindingPattern>();
|
|
return {.inst_id = param_pattern_id,
|
|
.inst = param_pattern_inst,
|
|
.entity_name_id = binding_pattern.entity_name_id};
|
|
}
|
|
|
|
auto Function::GetNameFromPatternId(const File& sem_ir, InstId pattern_id)
|
|
-> SemIR::NameId {
|
|
auto inst_id = pattern_id;
|
|
auto inst = sem_ir.insts().Get(inst_id);
|
|
|
|
if (auto addr_pattern = inst.TryAs<SemIR::AddrPattern>()) {
|
|
inst_id = addr_pattern->inner_id;
|
|
inst = sem_ir.insts().Get(inst_id);
|
|
}
|
|
|
|
if (inst_id == SemIR::ErrorInst::SingletonInstId) {
|
|
return SemIR::NameId::None;
|
|
}
|
|
|
|
auto param_pattern_inst = inst.As<SemIR::AnyParamPattern>();
|
|
|
|
inst_id = param_pattern_inst.subpattern_id;
|
|
inst = sem_ir.insts().Get(inst_id);
|
|
|
|
if (inst.Is<ReturnSlotPattern>()) {
|
|
return SemIR::NameId::ReturnSlot;
|
|
}
|
|
auto binding_pattern = inst.As<AnyBindingPattern>();
|
|
return sem_ir.entity_names().Get(binding_pattern.entity_name_id).name_id;
|
|
}
|
|
|
|
auto Function::GetDeclaredReturnType(const File& file,
|
|
SpecificId specific_id) const -> TypeId {
|
|
if (!return_slot_pattern_id.has_value()) {
|
|
return TypeId::None;
|
|
}
|
|
return GetTypeInSpecific(file, specific_id,
|
|
file.insts().Get(return_slot_pattern_id).type_id());
|
|
}
|
|
|
|
} // namespace Carbon::SemIR
|