mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-02 22:02:51 +01:00
Jon Ross-PerkinsandRichard Smith
b5a837aa89
I'm taking the approach of making DiagnosticBase an API so that we can pass similar diagnostics as parameters. An alternative would be to do the function_ref approach we've done elsewhere, but these felt more boilerplate to me. Note I'm also modifying messages here. Let me know if you'd like different changes and/or just keeping current formatting (keeping current formatting would also allow removing some of the templating I've added, but it felt helpful putting explicit tokens where possible). But also, things like "`protected` not allowed on `interface` declaration at file scope" were part of the phrasing issue, I think. --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>