mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 11:40:14 +01:00
Chandler Carruth
681b3b10c4
`scripts/jj_push.sh` takes the same arguments as `jj git push`, runs prek over the commits that push would send, and pushes only if they pass. It learns what is being sent by running `jj git push --dry-run` and reading back the plan, so `--bookmark`, `--change`, `--all` and the rest work without reimplementing how they select commits. Hooks that rewrite files need a commit to write into, so the checks run with the working copy on top of the commit being pushed. When the working copy is already an empty commit there, which is the common case, it is used directly; otherwise one is created, and named in the error so the fixes can be squashed. `scripts/jj_prek.sh` gets two changes. It forwards its arguments to `prek run`, so `jj_push.sh` can ask for a specific range, and it now changes to the workspace root before running. It exports `GIT_DIR`, which makes git treat the current directory as the work tree, so prek could not find its configuration from a subdirectory. `jj` does not expand aliases when completing arguments, so `jj push` completed file names. `scripts/completions` has Bash, Zsh, and Fish completions that give it the same completions as `jj git push`. `docs/project/contribution_tools.md` documents the `push` alias, and a `prek` alias for `jj_prek.sh`, with the other per-repository `jj` configuration. Both are opt-in. Assisted-by: Claude Code
38 lines
1.5 KiB
Fish
38 lines
1.5 KiB
Fish
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
#
|
|
# Fish completions for a `jj push` alias that runs `scripts/jj_push.sh`. See
|
|
# `scripts/completions/README.md` for how to install this.
|
|
#
|
|
# `jj` only knows the name of an alias, not what it expands to, so it completes
|
|
# file names after `jj push`. Rewriting `push` to `git push` in the command line
|
|
# before passing it to `jj` gets the completions of `jj git push`.
|
|
#
|
|
# This replaces the completions fish loads for `jj`, so it has to be installed
|
|
# with that file's name. Loading both leaves `jj`'s file-name completion
|
|
# registered.
|
|
|
|
function __jj_completion_tokens --description 'Command line tokens, with the `push` alias expanded'
|
|
# `--cut-at-cursor` drops the token being completed, so any `push` here is
|
|
# a complete word.
|
|
set -l tokens (commandline --current-process --tokenize --cut-at-cursor)
|
|
for i in (seq 2 (count $tokens))
|
|
switch $tokens[$i]
|
|
case '-*'
|
|
continue
|
|
case push
|
|
printf '%s\n' $tokens[1..(math $i - 1)] git push \
|
|
$tokens[(math $i + 1)..-1]
|
|
return
|
|
case '*'
|
|
break
|
|
end
|
|
end
|
|
printf '%s\n' $tokens
|
|
end
|
|
|
|
complete -e -c jj
|
|
complete --keep-order --exclusive --command jj \
|
|
--arguments "(COMPLETE=fish jj -- (__jj_completion_tokens) (commandline --current-token))"
|