mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 19:58:11 +00:00
This allows a generic class to inherit from a virtual C++ class as long as the subclass doesn't override any methods. See toolchain/lower/testdata/interop/cpp/class/import/inherit.carbon for a working example. The TODO in `CheckCompleteClassType` is now in `CarbonExternalASTSource::CompleteType`, and only triggers if virtual function thunks need to be defined. A fix in `FileContext::BuildVtable` is also needed: when looking up the clang decl associated with the vtable, if the class is generic then the `ClassTemplateSpecializationDecl` associated with the specific is needed. This required adding `ConstantStore::Get`, since only `const` access is allowed during lowering.
88 lines
1.9 KiB
Plaintext
88 lines
1.9 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/destroy.carbon
|
|
// EXTRA-ARGS: --share-cpp-ast
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/class/export/override.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/class/export/override.carbon
|
|
|
|
// --- const_ref_param.carbon
|
|
library "[[@TEST_NAME]]";
|
|
import Cpp;
|
|
|
|
inline Cpp '''
|
|
struct X {};
|
|
|
|
struct A {
|
|
virtual void f(const X& x) = 0;
|
|
};
|
|
''';
|
|
|
|
class B {
|
|
extend base: Cpp.A;
|
|
override fn f(unused self, unused x: Cpp.X) {}
|
|
}
|
|
|
|
inline Cpp '''
|
|
Carbon::B b;
|
|
''';
|
|
|
|
// --- base.h
|
|
struct Base {
|
|
virtual ~Base();
|
|
virtual void F() = 0;
|
|
};
|
|
|
|
// --- derived.carbon
|
|
library "derived";
|
|
import Cpp library "base.h";
|
|
|
|
class Derived {
|
|
extend base: Cpp.Base;
|
|
override fn F(unused self) {}
|
|
}
|
|
|
|
// --- imported.carbon
|
|
library "imported";
|
|
import Cpp library "base.h";
|
|
import library "derived";
|
|
|
|
inline Cpp '''
|
|
void Test() {
|
|
Carbon::Derived d;
|
|
}
|
|
''';
|
|
|
|
// --- fail_todo_generic.carbon
|
|
// TODO: Test in `toolchain/lower/testdata/` once generic classes deriving from
|
|
// C++ virtual classes pass check.
|
|
library "[[@TEST_NAME]]";
|
|
import Cpp;
|
|
|
|
inline Cpp '''
|
|
struct VBase {
|
|
virtual void f() {}
|
|
};
|
|
''';
|
|
|
|
class A {}
|
|
|
|
// CHECK:STDERR: fail_todo_generic.carbon:[[@LINE+2]]:1-25: error: semantics TODO: `generic class overriding methods from a C++ virtual class` [SemanticsTodo]
|
|
// CHECK:STDERR:
|
|
class GenericZ(T: type) {
|
|
extend base: Cpp.VBase;
|
|
override fn f(unused self) {}
|
|
}
|
|
|
|
fn G() {
|
|
var z: GenericZ(A) = {
|
|
.base = Cpp.VBase.VBase(),
|
|
};
|
|
z.f();
|
|
}
|