Files
carbon-lang/toolchain/testing/compile_helper.cpp
T
Jon Ross-Perkins 2de746e83c Switch compile functions to use options structs (#5742)
I've been mulling this mainly for the parameter complexity of
check/lower, but doing lex/parse for symmetry.

I'm motivated by the plan to move dumping for all of them into the
respective functions, because of discussion about llvm-verifier. That
basically would add another bool parameter (or more) to each of these.
My instinct is we're going to probably accrue a little more over time,
so I'm suggesting this as maybe adding the boundary a little simpler
and/or easier to read.

Note it may make sense to refactor a little further, e.g. maybe
Lower::Context could receive the full set of options and pick out what
it wants, but I figured creating the struct itself would be a decent
start.

I'm trying to put things into options when we can produce a reasonable
default if the user doesn't assign a value. I'm using an explicit
constructor so that values can be added without affecting every caller.

A different factoring would be to pass in everything through the param
struct, but that just felt weird when I was trying it out.

Removing `inst_namer` and `module_name` from `LowerToLLVM` params --
both of these can be inferred from `sem_ir`, and I'm not seeing a
particular reason to maintain them at the call site.
2025-06-27 22:08:47 +00:00

66 lines
2.3 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/testing/compile_helper.h"
#include <string>
#include <utility>
namespace Carbon::Testing {
auto CompileHelper::GetTokenizedBuffer(llvm::StringRef text,
Diagnostics::Consumer* consumer)
-> Lex::TokenizedBuffer& {
auto& source = GetSourceBuffer(text);
value_store_storage_.emplace_front();
Lex::LexOptions options;
options.consumer = consumer ? consumer : &consumer_;
token_storage_.push_front(
Lex::Lex(value_store_storage_.front(), source, options));
return token_storage_.front();
}
auto CompileHelper::GetTokenizedBufferWithSharedValueStore(
llvm::StringRef text, Diagnostics::Consumer* consumer)
-> std::pair<Lex::TokenizedBuffer&, SharedValueStores&> {
auto& tokens = GetTokenizedBuffer(text, consumer);
return {tokens, value_store_storage_.front()};
}
auto CompileHelper::GetTree(llvm::StringRef text) -> Parse::Tree& {
auto& tokens = GetTokenizedBuffer(text);
Parse::ParseOptions options;
options.consumer = &consumer_;
tree_storage_.push_front(Parse::Parse(tokens, options));
return tree_storage_.front();
}
auto CompileHelper::GetTreeAndSubtrees(llvm::StringRef text)
-> Parse::TreeAndSubtrees& {
auto& tree = GetTree(text);
tree_and_subtrees_storage_.push_front(
Parse::TreeAndSubtrees(token_storage_.front(), tree));
return tree_and_subtrees_storage_.front();
}
auto CompileHelper::GetTokenizedBufferWithTreeAndSubtrees(llvm::StringRef text)
-> std::pair<Lex::TokenizedBuffer&, Parse::TreeAndSubtrees&> {
auto& tree_and_subtrees = GetTreeAndSubtrees(text);
return {token_storage_.front(), tree_and_subtrees};
}
auto CompileHelper::GetSourceBuffer(llvm::StringRef text) -> SourceBuffer& {
std::string filename = llvm::formatv("test{0}.carbon", ++file_index_);
CARBON_CHECK(
fs_.addFile(filename, /*ModificationTime=*/0,
llvm::MemoryBuffer::getMemBuffer(
text, filename, /*RequiresNullTerminator=*/false)));
source_storage_.push_front(
std::move(*SourceBuffer::MakeFromFile(fs_, filename, consumer_)));
return source_storage_.front();
}
} // namespace Carbon::Testing