mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 20:58:13 +00:00
There are a world of reasons why the dependent state check can be wrong or get stuck. We need ways to manually override inaccurate findings or trigger a re-check when things change. Overriding: removing the `dependent` label causes the job to run and immediately report success to unblock merging. The `workflow_dispatch` can also run with an `override` mode. This requires adding more tracked state in the form of _ignored_ PRs that would otherwise be considered dependencies. Re-checking: the job now makes the status have a `Details` link that can be used to re-run it, and editing the PR description also re-runs it. However, adding the `dependent` label or doing an explicit `workflow_dispatch` with mode `recheck` goes further: it drops any overrides and recomputes the open dependencies from the current commits, keeping the record of merged dependencies. Hiding the comment still clears _all_ of the tracked state for the PR, so the next check starts completely from scratch. Lastly, this extends the workflow to support being marked as required by letting it run in the merge queue and report success. Works to keep the changes to `_process_pr` organized so that we first collect and analyze the state, and only at the end mutate the PR's state to the new configuration. Adds relevant unit tests for the new features. Also added some basic documentation of this so that folks have a reference when it has issues. I considered the alternative of parsing mentions out of comments (dependabot-style), but it ended up significantly more complicated and brittle, so instead went with basing each change on an operation on the PR that is already mechanically available. Assisted-by: Antigravity with Opus
Project
This directory contains project-related documentation for Carbon. Information about how the project works, goals, and community information belong here.
- Goals, and principles derived from those goals
- Roadmap and the process for updating it
- Carbon's process for evolution and governance
- Groups used for contacting key contributors and determining access
- Contributing to Carbon:
- Tools used when contributing to Carbon
- Style guides for language design and C++ code
- How Carbon does code review
- Trunk-based pull-request GitHub workflow used by Carbon