Files
carbon-lang/toolchain/check
Jon Ross-Perkins bd2fa3ace7 Remove CalleeParamsInfo (#4452)
I'm seeing three issues with CalleeParamsInfo:

1. Although ResolveCalleeInCall had been extracted out and the
EntityWithParamsBase could be used directly, that had not been cleaned
up.
2. implicit_param_refs_id is unused; param_refs_id was only used by
ResolveCalleeInCall. The factoring as a struct seems to be obscuring
what's used and what isn't (creating unnecessary copies).
3. On #4446, CalleeParamsInfo seemed to be obfuscating what
ConvertCallArgs actually worked with (a Function, not a generic entity).

I'm thinking that just removing CalleeParamsInfo is the best resolution
here, it looks like it's tripping people up more than it's helping.

Note, I think Function used to be named Callable, which was where the
"callable" name originally came from (I might be wrong about this). But
"function" seems clearer about the type now.
2024-11-04 16:47:40 +00:00
..
2024-11-04 16:47:40 +00:00
2024-11-04 16:47:40 +00:00
2024-11-04 16:47:40 +00:00
2024-03-09 00:21:29 +00:00