mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 22:02:52 +01:00
Jon Ross-Perkins
9704dc670e
The main direction of this change is the edits to `destroy.carbon` (matching in both prelude and min_prelude). Previously there was a no-op blanket impl for `Destroy`, which hid all missing implementations of `Destroy`. This does a few things: - Sets up builtin aggregate destruction for struct and tuple types as before, but also adds C++ class types and array types to the same handling. (all as a TODO for actual implementation) - Also maybe-unformed destruction, for now at least. (there's a chance I may try a different approach on this, but the impl lookup wasn't working as I'd hope in order to write it in code) - Adds handlers for simple things that are easy to do in code: `type`, `bool`, pointers. (because these are no-op destruction) - Redirect `const T` destruction to `T` destruction. This leaves as future issues: - `partial T` destruction. (this can't be done similar to `const` because it only works for non-`final` class types; I think `class` definitions should just generate what's needed) - Destruction of other prelude-provided types. (will probably come up as we implement class destruction, that the adapted builtin type doesn't implement `Destroy` -- but may end up special-casing that in a way that moots it) This moves the `&` operator from `facet_types.carbon` to `convert.carbon` because more things need to handle type and now that we're getting separate copy and destroy interfaces. It should be low-cost (an interface and builtin) so hopefully this is the right balance for complexity and re-use. A few tests are also edited in order to focus them more on what they intend to test, and avoid a `Destroy` dependency.
158 lines
4.5 KiB
Plaintext
158 lines
4.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/lookup/unused_generic_binding.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/lookup/unused_generic_binding.carbon
|
|
|
|
// --- fail_no_binding_used.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
let T:! type;
|
|
}
|
|
|
|
impl forall [U:! type] U as I where .T = () {}
|
|
|
|
class C {}
|
|
|
|
// This impl can never deduce its implicit generic parameter `V`, which
|
|
// should be diagnosed.
|
|
//
|
|
// CHECK:STDERR: fail_no_binding_used.carbon:[[@LINE+4]]:13: error: `impl` with unused generic binding [ImplUnusedBinding]
|
|
// CHECK:STDERR: impl forall [V:! type] C as I where .T = {.unmatched: ()} {}
|
|
// CHECK:STDERR: ^~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [V:! type] C as I where .T = {.unmatched: ()} {}
|
|
|
|
fn F() {
|
|
// This shows that the first impl declaration was matched even though the
|
|
// second is more specific. But since it has an unused generic parameter, it
|
|
// will never match. If the second was matched, this line would not type
|
|
// check.
|
|
let x: C.(I.T) = ();
|
|
}
|
|
|
|
// --- fail_one_binding_unused.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
let T:! type;
|
|
}
|
|
|
|
impl forall [U:! type] U as I where .T = () {}
|
|
|
|
class C {}
|
|
|
|
// This impl can never deduce its implicit generic parameter `W`, which
|
|
// should be diagnosed.
|
|
// https://discord.com/channels/655572317891461132/941071822756143115/1354563497731686550
|
|
//
|
|
// CHECK:STDERR: fail_one_binding_unused.carbon:[[@LINE+4]]:13: error: `impl` with unused generic binding [ImplUnusedBinding]
|
|
// CHECK:STDERR: impl forall [V:! type, W:! type] V as I where .T = {.unmatched: ()} {}
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [V:! type, W:! type] V as I where .T = {.unmatched: ()} {}
|
|
|
|
fn F() {
|
|
// This shows that the first impl declaration was matched even though the
|
|
// second is more specific. If the second was matched, it would not type
|
|
// check.
|
|
let x: C.(I.T) = ();
|
|
}
|
|
|
|
// --- fail_inherited_binding_unused.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
let T:! type;
|
|
}
|
|
|
|
impl forall [U:! type] U as I where .T = () {}
|
|
|
|
class C(U:! type) {
|
|
// This impl can never deduce its inherited generic binding `U`, which
|
|
// should be diagnosed.
|
|
//
|
|
// TODO: We should point the diagnostic at the binding `U` in C.
|
|
//
|
|
// CHECK:STDERR: fail_inherited_binding_unused.carbon:[[@LINE+4]]:3: error: `impl` with unused generic binding [ImplUnusedBinding]
|
|
// CHECK:STDERR: impl C(()) as I where .T = {.unmatched: ()} {}
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl C(()) as I where .T = {.unmatched: ()} {}
|
|
}
|
|
|
|
fn F() {
|
|
let x: C(()).(I.T) = ();
|
|
}
|
|
|
|
// --- fail_inherited_binding_in_forall_unused.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
let T:! type;
|
|
}
|
|
|
|
impl forall [U:! type] U as I where .T = () {}
|
|
|
|
class C(U:! type) {
|
|
// This impl can never deduce its inherited generic binding `U`, which
|
|
// should be diagnosed.
|
|
//
|
|
// TODO: We should point the diagnostic at the binding `U` in C.
|
|
//
|
|
// CHECK:STDERR: fail_inherited_binding_in_forall_unused.carbon:[[@LINE+4]]:15: error: `impl` with unused generic binding [ImplUnusedBinding]
|
|
// CHECK:STDERR: impl forall [V:! type] C(V) as I where .T = {.unmatched: ()} {}
|
|
// CHECK:STDERR: ^~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [V:! type] C(V) as I where .T = {.unmatched: ()} {}
|
|
}
|
|
|
|
fn F() {
|
|
let x: C(()).(I.T) = ();
|
|
}
|
|
|
|
// --- inherited_binding_used.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
let T:! type;
|
|
}
|
|
|
|
impl forall [U:! type] U as I where .T = {.unmatched: ()} {}
|
|
|
|
class C(U:! type) {
|
|
// `U` can be deduced here, so no diagnostic issued.
|
|
impl C(U) as I where .T = () {}
|
|
}
|
|
|
|
fn F() {
|
|
// The `impl` inside C is matched here.
|
|
let x: C(()).(I.T) = ();
|
|
}
|
|
|
|
// --- inherited_binding_in_forall_used.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I(W:! type) {
|
|
let T:! type;
|
|
}
|
|
|
|
impl forall [U:! type] U as I(U) where .T = {.unmatched: ()} {}
|
|
|
|
class C(U:! type) {
|
|
// `U` can be deduced here, so no diagnostic issued.
|
|
impl forall [V:! type] C(U) as I(V) where .T = () {}
|
|
}
|
|
|
|
fn F() {
|
|
// The `impl` inside C is matched here.
|
|
let x: C(()).(I({}).T) = ();
|
|
}
|