mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 22:02:41 +01:00
Jon Ross-Perkins
9704dc670e
The main direction of this change is the edits to `destroy.carbon` (matching in both prelude and min_prelude). Previously there was a no-op blanket impl for `Destroy`, which hid all missing implementations of `Destroy`. This does a few things: - Sets up builtin aggregate destruction for struct and tuple types as before, but also adds C++ class types and array types to the same handling. (all as a TODO for actual implementation) - Also maybe-unformed destruction, for now at least. (there's a chance I may try a different approach on this, but the impl lookup wasn't working as I'd hope in order to write it in code) - Adds handlers for simple things that are easy to do in code: `type`, `bool`, pointers. (because these are no-op destruction) - Redirect `const T` destruction to `T` destruction. This leaves as future issues: - `partial T` destruction. (this can't be done similar to `const` because it only works for non-`final` class types; I think `class` definitions should just generate what's needed) - Destruction of other prelude-provided types. (will probably come up as we implement class destruction, that the adapted builtin type doesn't implement `Destroy` -- but may end up special-casing that in a way that moots it) This moves the `&` operator from `facet_types.carbon` to `convert.carbon` because more things need to handle type and now that we're getting separate copy and destroy interfaces. It should be low-cost (an interface and builtin) so hopefully this is the right balance for complexity and re-use. A few tests are also edited in order to focus them more on what they intend to test, and avoid a `Destroy` dependency.
49 lines
1.5 KiB
Plaintext
49 lines
1.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/lookup/struct.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/lookup/struct.carbon
|
|
|
|
interface Z {
|
|
let X:! type;
|
|
fn ZZ() -> X;
|
|
}
|
|
|
|
class C { adapt (); }
|
|
class D { adapt (); }
|
|
|
|
impl {.a: (), .b: ()} as Z where .X = C {
|
|
fn ZZ() -> C { return () as C; }
|
|
}
|
|
|
|
// A struct with different field names. Structs with different field names are
|
|
// different types and can be matched by an impl lookup with matching field
|
|
// names.
|
|
impl {.aa: (), .bb: ()} as Z where .X = D {
|
|
fn ZZ() -> D { return () as D; }
|
|
}
|
|
|
|
// Structs with different field orders are different types too, for impl
|
|
// lookup. See https://github.com/carbon-language/carbon-lang/issues/5413.
|
|
impl {.b: (), .a: ()} as Z where .X = D {
|
|
fn ZZ() -> D { return () as D; }
|
|
}
|
|
|
|
fn F(T:! Z) -> T.X {
|
|
return T.ZZ();
|
|
}
|
|
|
|
fn G() {
|
|
// Check which impl is selected for struct literals with different field
|
|
// names.
|
|
let c1: C = F({.a: (), .b: ()});
|
|
let d1: D = F({.aa: (), .bb: ()});
|
|
let d2: D = F({.b: (), .a: ()});
|
|
}
|