mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 18:31:08 +01:00
Richard Smith
d60900cbeb
When returning a value from a function whose return type has a by-copy initializing representation, perform initialization like we do when the return type has an in-place initializing representation. This makes our SemIR representation more uniform, as the return expression will now always be an initializing expression rather than a value expression, but more importantly it means that attempts to return a non-copyable type by value now fail, even if the type has a by-copy initializing representation. This catches a bunch of places where we were returning a value of an unconstrained template parameter `T:! type`, which we were incorrectly allowing because we didn't notice it was not copyable. Unfortunately this then requires quite a few test updates. Like #6034, this exposes a lowering issue where lowering crashes when attempting to lower a specific copy operation for certain types; a couple more tests are temporarily disabled here. An upcoming PR dependent on this one will fix the issue and re-enable those tests.
68 lines
1.7 KiB
Plaintext
68 lines
1.7 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
package Core library "prelude/copy";
|
|
|
|
// Copying an object, which is a conversion from a value representation to an
|
|
// initializing representation.
|
|
interface Copy {
|
|
fn Op[self: Self]() -> Self;
|
|
}
|
|
|
|
private fn Bool() -> type = "bool.make_type";
|
|
private fn CharLiteral() -> type = "char_literal.make_type";
|
|
private fn FloatLiteral() -> type = "float_literal.make_type";
|
|
private fn IntLiteral() -> type = "int_literal.make_type";
|
|
|
|
impl forall [T:! Copy] const T as Copy {
|
|
fn Op[self: Self]() -> Self { return (self as T).(Copy.Op)() as const T; }
|
|
}
|
|
|
|
impl Bool() as Copy {
|
|
fn Op[self: Self]() -> Self = "primitive_copy";
|
|
}
|
|
|
|
impl CharLiteral() as Copy {
|
|
fn Op[self: Self]() -> Self = "primitive_copy";
|
|
}
|
|
|
|
impl FloatLiteral() as Copy {
|
|
fn Op[self: Self]() -> Self = "primitive_copy";
|
|
}
|
|
|
|
impl IntLiteral() as Copy {
|
|
fn Op[self: Self]() -> Self = "primitive_copy";
|
|
}
|
|
|
|
impl type as Copy {
|
|
fn Op[self: Self]() -> Self = "primitive_copy";
|
|
}
|
|
|
|
impl forall [T:! type] T* as Copy {
|
|
fn Op[self: Self]() -> Self = "primitive_copy";
|
|
}
|
|
|
|
// TODO: Implement tuple copy as a variadic generic impl.
|
|
impl () as Copy {
|
|
fn Op[self: Self]() -> Self = "no_op";
|
|
}
|
|
|
|
impl forall [T:! Copy] (T,) as Copy {
|
|
fn Op[self: Self]() -> Self {
|
|
return (self.0.Op(),);
|
|
}
|
|
}
|
|
|
|
impl forall [T:! Copy, U:! Copy] (T, U) as Copy {
|
|
fn Op[self: Self]() -> Self {
|
|
return (self.0.Op(), self.1.Op());
|
|
}
|
|
}
|
|
|
|
impl forall [T:! Copy, U:! Copy, V:! Copy] (T, U, V) as Copy {
|
|
fn Op[self: Self]() -> Self {
|
|
return (self.0.Op(), self.1.Op(), self.2.Op());
|
|
}
|
|
}
|