mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-Perkins
03347793cc
This undoes parts of #3515 in order to allow PushGlobalInit to be called when the initializer is called, instead of at the end of the binding pattern. The current approach is fragile because supported patterns will become more complex. We also will likely want similar support in `let`, which puts the initializer first, so this offers a consistent approach for both. [Looking back](https://discord.com/channels/655572317891461132/655578254970716160/1184237511766179840), this is more or less the second option in that message, but using the PeekNextIs to avoid vagueness about what's being popped first. Note I'm putting in PeekNextIs for what I'm hoping will be a pretty narrow use-case. I could've added depth arguments to the Peek functions, but that would've rippled through a number of APIs and it's not clear to me that this has generic utility. I mean, right now it could just be PeekNextIsVariableInitializer, since it's only optional in that case.
37 lines
1.9 KiB
Plaintext
37 lines
1.9 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
fn F() {
|
|
// CHECK:STDERR: fail_else_expr_missing.carbon:[[@LINE+3]]:35: ERROR: Expected expression.
|
|
// CHECK:STDERR: var n: i32 = if true then 1 else;
|
|
// CHECK:STDERR: ^
|
|
var n: i32 = if true then 1 else;
|
|
}
|
|
|
|
// CHECK:STDOUT: - filename: fail_else_expr_missing.carbon
|
|
// CHECK:STDOUT: parse_tree: [
|
|
// CHECK:STDOUT: {kind: 'FileStart', text: ''},
|
|
// CHECK:STDOUT: {kind: 'FunctionIntroducer', text: 'fn'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierName', text: 'F'},
|
|
// CHECK:STDOUT: {kind: 'TuplePatternStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'TuplePattern', text: ')', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'FunctionDefinitionStart', text: '{', subtree_size: 5},
|
|
// CHECK:STDOUT: {kind: 'VariableIntroducer', text: 'var'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierName', text: 'n'},
|
|
// CHECK:STDOUT: {kind: 'IntTypeLiteral', text: 'i32'},
|
|
// CHECK:STDOUT: {kind: 'BindingPattern', text: ':', subtree_size: 3},
|
|
// CHECK:STDOUT: {kind: 'VariableInitializer', text: '='},
|
|
// CHECK:STDOUT: {kind: 'BoolLiteralTrue', text: 'true'},
|
|
// CHECK:STDOUT: {kind: 'IfExprIf', text: 'if', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '1'},
|
|
// CHECK:STDOUT: {kind: 'IfExprThen', text: 'then', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'InvalidParse', text: ';', has_error: yes},
|
|
// CHECK:STDOUT: {kind: 'IfExprElse', text: 'else', has_error: yes, subtree_size: 6},
|
|
// CHECK:STDOUT: {kind: 'VariableDecl', text: ';', subtree_size: 12},
|
|
// CHECK:STDOUT: {kind: 'FunctionDefinition', text: '}', subtree_size: 18},
|
|
// CHECK:STDOUT: {kind: 'FileEnd', text: ''},
|
|
// CHECK:STDOUT: ]
|