Files
carbon-lang/toolchain/check/handle_export.cpp
T
Jon Ross-Perkins 57c0a6c076 Handling for cross-package imports of "export name". (#3967)
Starts warning on duplicate "export name" because I'm updating name
lookup to make it work.

Need to think harder about how to handle cross-package "export import".
But adding some failing tests to sketch out what *should* work.
2024-05-21 21:02:09 +00:00

86 lines
3.1 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/check/context.h"
#include "toolchain/check/decl_name_stack.h"
#include "toolchain/check/modifiers.h"
#include "toolchain/parse/typed_nodes.h"
#include "toolchain/sem_ir/ids.h"
#include "toolchain/sem_ir/typed_insts.h"
namespace Carbon::Check {
auto HandleExportIntroducer(Context& context,
Parse::ExportIntroducerId /*node_id*/) -> bool {
context.decl_state_stack().Push(DeclState::Export);
// TODO: Probably need to update DeclNameStack to restrict to only namespaces.
context.decl_name_stack().PushScopeAndStartName();
return true;
}
auto HandleExportDecl(Context& context, Parse::ExportDeclId node_id) -> bool {
auto name_context = context.decl_name_stack().FinishName();
context.decl_name_stack().PopScope();
LimitModifiersOnDecl(context, KeywordModifierSet::None,
Lex::TokenKind::Export);
context.decl_state_stack().Pop(DeclState::Export);
if (name_context.state == DeclNameStack::NameContext::State::Error) {
// Should already be diagnosed.
return true;
}
auto inst_id = name_context.prev_inst_id();
if (!inst_id.is_valid()) {
context.DiagnoseNameNotFound(node_id, name_context.name_id_for_new_inst());
return true;
}
auto inst = context.insts().Get(inst_id);
if (inst.Is<SemIR::ExportDecl>()) {
CARBON_DIAGNOSTIC(ExportRedundant, Warning,
"`export` matches previous `export`.");
CARBON_DIAGNOSTIC(ExportPrevious, Note, "Previous `export` here.");
context.emitter()
.Build(node_id, ExportRedundant)
// Use the location of the export itself, not the exported instruction.
.Note(context.insts().GetLocId(inst_id), ExportPrevious)
.Emit();
return true;
}
auto import_ref = context.insts().TryGetAs<SemIR::ImportRefLoaded>(inst_id);
if (!import_ref) {
CARBON_DIAGNOSTIC(ExportNotImportedEntity, Error,
"Only imported entities are valid for `export`.");
CARBON_DIAGNOSTIC(ExportNotImportedEntitySource, Note,
"Name is declared here.");
context.emitter()
.Build(node_id, ExportNotImportedEntity)
.Note(inst_id, ExportNotImportedEntitySource)
.Emit();
return true;
}
auto export_id = context.AddInst(
{node_id, SemIR::ExportDecl{.type_id = import_ref->type_id,
.bind_name_id = import_ref->bind_name_id,
.value_id = inst_id}});
context.AddExport(export_id);
// Replace the ImportRef in name lookup, both for the above duplicate
// diagnostic and so that cross-package imports can find it easily.
auto bind_name = context.bind_names().Get(import_ref->bind_name_id);
auto& names = context.name_scopes().Get(bind_name.enclosing_scope_id).names;
auto it = names.find(bind_name.name_id);
CARBON_CHECK(it->second == inst_id);
it->second = export_id;
return true;
}
} // namespace Carbon::Check