mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Jon Ross-Perkins
9704dc670e
The main direction of this change is the edits to `destroy.carbon` (matching in both prelude and min_prelude). Previously there was a no-op blanket impl for `Destroy`, which hid all missing implementations of `Destroy`. This does a few things: - Sets up builtin aggregate destruction for struct and tuple types as before, but also adds C++ class types and array types to the same handling. (all as a TODO for actual implementation) - Also maybe-unformed destruction, for now at least. (there's a chance I may try a different approach on this, but the impl lookup wasn't working as I'd hope in order to write it in code) - Adds handlers for simple things that are easy to do in code: `type`, `bool`, pointers. (because these are no-op destruction) - Redirect `const T` destruction to `T` destruction. This leaves as future issues: - `partial T` destruction. (this can't be done similar to `const` because it only works for non-`final` class types; I think `class` definitions should just generate what's needed) - Destruction of other prelude-provided types. (will probably come up as we implement class destruction, that the adapted builtin type doesn't implement `Destroy` -- but may end up special-casing that in a way that moots it) This moves the `&` operator from `facet_types.carbon` to `convert.carbon` because more things need to handle type and now that we're getting separate copy and destroy interfaces. It should be low-cost (an interface and builtin) so hopefully this is the right balance for complexity and re-use. A few tests are also edited in order to focus them more on what they intend to test, and avoid a `Destroy` dependency.
233 lines
6.5 KiB
Plaintext
233 lines
6.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/facet/combine.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/facet/combine.carbon
|
|
|
|
// --- fail_name_collision.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface A {
|
|
fn G();
|
|
}
|
|
interface B {
|
|
fn G();
|
|
}
|
|
|
|
class C {}
|
|
impl C as A {
|
|
fn G();
|
|
}
|
|
impl C as B {
|
|
fn G() {}
|
|
}
|
|
|
|
fn F() {
|
|
// TODO: This error message is wrong here, we are not using `extend`.
|
|
|
|
// CHECK:STDERR: fail_name_collision.carbon:[[@LINE+4]]:14: error: ambiguous use of name `G` found in multiple extended scopes [NameAmbiguousDueToExtend]
|
|
// CHECK:STDERR: ({} as C).((A & B).G)();
|
|
// CHECK:STDERR: ^~~~~~~~~
|
|
// CHECK:STDERR:
|
|
({} as C).((A & B).G)();
|
|
}
|
|
|
|
// --- combine.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface A {}
|
|
interface B {
|
|
fn BB[self: Self]();
|
|
}
|
|
|
|
class C {}
|
|
impl C as A {}
|
|
impl C as B {
|
|
fn BB[self: Self]() {}
|
|
}
|
|
|
|
fn G[T:! A & B](t: T) {}
|
|
|
|
fn F() {
|
|
({} as C).((A & B).BB)();
|
|
|
|
(({} as C) as (C as (A & B))).((A & B).BB)();
|
|
(({} as C) as (C as (A & B))).(B.BB)();
|
|
|
|
G({} as C);
|
|
}
|
|
|
|
// --- generic_interface.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface A(T:! type) {}
|
|
interface B {}
|
|
|
|
class P1 {}
|
|
class P2 {}
|
|
|
|
class C {}
|
|
impl C as A(P1) {}
|
|
impl C as B {}
|
|
|
|
fn G[T:! A(P1) & B](t: T) {}
|
|
|
|
fn F() {
|
|
G({} as C);
|
|
}
|
|
|
|
// --- fail_wrong_generic_interface.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface A(T:! type) {}
|
|
interface B {}
|
|
|
|
class P1 {}
|
|
class P2 {}
|
|
|
|
class C {}
|
|
impl C as A(P1) {}
|
|
impl C as B {}
|
|
|
|
fn G[T:! A(P2) & B](t: T) {}
|
|
|
|
fn F() {
|
|
// CHECK:STDERR: fail_wrong_generic_interface.carbon:[[@LINE+7]]:3: error: cannot convert type `C` into type implementing `A(P2) & B` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: G({} as C);
|
|
// CHECK:STDERR: ^~~~~~~~~~
|
|
// CHECK:STDERR: fail_wrong_generic_interface.carbon:[[@LINE-6]]:1: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR: fn G[T:! A(P2) & B](t: T) {}
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
G({} as C);
|
|
}
|
|
|
|
// --- generic_forall_impl.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Iface {}
|
|
interface GenericIface(T:! type) {}
|
|
|
|
class GenericClass(T:! type) {}
|
|
|
|
class ImplIface {}
|
|
impl ImplIface as Iface {}
|
|
|
|
class C {}
|
|
impl C as Iface {}
|
|
|
|
impl forall [IfaceType:! Iface] C as GenericIface(GenericClass(IfaceType)) {}
|
|
|
|
fn G[T:! Iface & GenericIface(GenericClass(ImplIface))](t: T) {}
|
|
|
|
fn F() {
|
|
G({} as C);
|
|
}
|
|
|
|
// --- compare_equal.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T:! type) {}
|
|
fn AssertSame[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
fn Type(T:! type) -> WrapType(T) { return {}; }
|
|
|
|
interface I;
|
|
interface J;
|
|
interface K(T:! type);
|
|
|
|
fn TestIncomplete() {
|
|
AssertSame(Type(I), Type(I & I));
|
|
AssertSame(Type(I), Type(I & I & I));
|
|
AssertSame(Type(I & J), Type(J & I));
|
|
AssertSame(Type(I & J), Type(I & I & J));
|
|
AssertSame(Type(I & J), Type(I & J & I));
|
|
AssertSame(Type(I & J), Type(J & I & I));
|
|
AssertSame(Type(I & K({})), Type(K({}) & I));
|
|
AssertSame(Type(I & K({}) & K(())), Type(K(()) & K({}) & I));
|
|
}
|
|
|
|
interface I {}
|
|
interface J {}
|
|
interface K(T:! type) {}
|
|
|
|
fn TestComplete() {
|
|
AssertSame(Type(I), Type(I & I));
|
|
AssertSame(Type(I), Type(I & I & I));
|
|
AssertSame(Type(I & J), Type(J & I));
|
|
AssertSame(Type(I & J), Type(I & I & J));
|
|
AssertSame(Type(I & J), Type(I & J & I));
|
|
AssertSame(Type(I & J), Type(J & I & I));
|
|
AssertSame(Type(I & K({})), Type(K({}) & I));
|
|
AssertSame(Type(I & K({}) & K(())), Type(K(()) & K({}) & I));
|
|
}
|
|
|
|
// --- fail_compare_not_equal.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T:! type) {}
|
|
fn Same[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
fn Type(T:! type) -> WrapType(T) { return {}; }
|
|
|
|
interface I {}
|
|
interface J {}
|
|
interface K {}
|
|
|
|
fn Test() {
|
|
// CHECK:STDERR: fail_compare_not_equal.carbon:[[@LINE+7]]:3: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: Same(Type(I & J), Type(K & I & J));
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_compare_not_equal.carbon:[[@LINE-11]]:1: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR: fn Same[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
Same(Type(I & J), Type(K & I & J));
|
|
}
|
|
|
|
// --- fail_compare_not_equal_parameterized.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T:! type) {}
|
|
fn Same[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
fn Type(T:! type) -> WrapType(T) { return {}; }
|
|
|
|
interface I {}
|
|
interface J(T:! type) {}
|
|
|
|
fn Test() {
|
|
// CHECK:STDERR: fail_compare_not_equal_parameterized.carbon:[[@LINE+7]]:3: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: Same(Type(I & J(())), Type(J({}) & I));
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_compare_not_equal_parameterized.carbon:[[@LINE-10]]:1: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR: fn Same[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
Same(Type(I & J(())), Type(J({}) & I));
|
|
}
|
|
|
|
// --- fail_compare_not_equal_parameterized_extra.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T:! type) {}
|
|
fn Same[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
fn Type(T:! type) -> WrapType(T) { return {}; }
|
|
|
|
interface I {}
|
|
interface J(T:! type) {}
|
|
|
|
fn Test() {
|
|
// CHECK:STDERR: fail_compare_not_equal_parameterized_extra.carbon:[[@LINE+7]]:3: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: Same(Type(I & J(())), Type(J(()) & J({}) & I));
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_compare_not_equal_parameterized_extra.carbon:[[@LINE-10]]:1: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR: fn Same[T:! type](a: WrapType(T), b: WrapType(T)) {}
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
Same(Type(I & J(())), Type(J(()) & J({}) & I));
|
|
}
|