mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-PerkinsandRichard Smith
c0ee446cec
`AddDefaultValue` doesn't quite capture the intended semantics; it should typically be replaced with an actual value when dealing with control flows. Trying to indicate the "assign later" with `AddPlaceholder`, mirroring `AddPlaceholderInst`. Shifting the `protected` functionality on `BlockValueStore` so that it's not providing functions just for `InstBlockStore` to use. Also hoping that seeing the comments next to the function name makes them easier to understand, whereas `using` buries that a little. --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>
49 lines
1.8 KiB
C++
49 lines
1.8 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/subpattern.h"
|
|
|
|
#include "toolchain/check/inst.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
auto BeginSubpattern(Context& context) -> void {
|
|
context.inst_block_stack().Push();
|
|
context.region_stack().PushRegion(context.inst_block_stack().PeekOrAdd());
|
|
}
|
|
|
|
auto EndSubpatternAsExpr(Context& context, SemIR::InstId result_id)
|
|
-> SemIR::ExprRegionId {
|
|
if (context.region_stack().PeekRegion().size() > 1) {
|
|
// End the exit block with a branch to a successor block, whose contents
|
|
// will be determined later.
|
|
AddInst(context,
|
|
SemIR::LocIdAndInst::NoLoc<SemIR::Branch>(
|
|
{.target_id = context.inst_blocks().AddPlaceholder()}));
|
|
} else {
|
|
// This single-block region will be inserted as a SpliceBlock, so we don't
|
|
// need control flow out of it.
|
|
}
|
|
auto block_id = context.inst_block_stack().Pop();
|
|
CARBON_CHECK(block_id == context.region_stack().PeekRegion().back());
|
|
|
|
// TODO: Is it possible to validate that this region is genuinely
|
|
// single-entry, single-exit?
|
|
return context.sem_ir().expr_regions().Add(
|
|
{.block_ids = context.region_stack().PopRegion(),
|
|
.result_id = result_id});
|
|
}
|
|
|
|
auto EndSubpatternAsNonExpr(Context& context) -> void {
|
|
auto block_id = context.inst_block_stack().Pop();
|
|
CARBON_CHECK(block_id == context.region_stack().PeekRegion().back());
|
|
CARBON_CHECK(context.region_stack().PeekRegion().size() == 1);
|
|
// TODO: Add `CARBON_CHECK(inst_blocks().Get(block_id).empty())`.
|
|
// Currently that can fail when ending a tuple pattern in a name binding
|
|
// decl in a class or interface.
|
|
context.region_stack().PopAndDiscardRegion();
|
|
}
|
|
|
|
} // namespace Carbon::Check
|