mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-18 02:50:32 +00:00
Historically, we disabled the rendered form in tests outside of `toolchain/diagnostics`. The idea was to keep tests shorter and avoid very long chains of autoupdate before stabilizing due to all the line numbers and other artifacts in the rendered form. This PR adds `--diagnostic-line-numbers=[all|first]` and defaults to `first` in tests. This keeps the rendered form so that we can easily code review that form and the visual cues it does or doesn't provide. But it removes all but the first location's line numbers to provide significantly more stability in tests. By default, tests get the full unicode line-drawing form of diagnostics so we can ensure all of the artifacts there make sense with the specific case being diagnosed, but we do retain some focused ASCII-rendering tests to ensure that fallback remains usable. There are some issues here that will be fixed in subsequent PRs. Notably, we try to keep the frame together in the check lines, and so force some parts to use the first location. This largely works, but fails in some edge cases, causing the entire frame to be located incorrectly. There is a TODO about this that we need to fix, and it only occurs 6 times across the test suite, so it didn't seem worth front-loading a fix for here. Assisted-by: Claude Code
91 lines
3.1 KiB
Plaintext
91 lines
3.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/lookup/access.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/lookup/access.carbon
|
|
|
|
// --- fail_todo_impl_witness_access_in_impl_type_structure.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface X(T: type) {}
|
|
interface Y {
|
|
let Y1: type;
|
|
}
|
|
interface Z {
|
|
let Z1: type;
|
|
}
|
|
|
|
// There's 2 ImplWitnessAccess instructions in the type, but they together
|
|
// resolve to a symbolic type value, so the type structure is: `? as X(?)`
|
|
impl forall [T: Z where .Z1 impls Y] T as X(T.Z1.(Y.Y1)) {}
|
|
|
|
class C(W: type) {
|
|
impl as Y where .Y1 = W {}
|
|
}
|
|
|
|
fn F(generic V: Z where .Z1 = C({})) {
|
|
// The type stucture is `? as X({})` which will match the impl's less specific
|
|
// `? as X(?)`, then the impl will deduce the parameter of `X` to be `{}` from
|
|
// the type of `V`. This would fail if ImplWitnessAccess instructions were
|
|
// treated as Concrete in the type structure, since the impl would have a
|
|
// different concrete value (an ImplWitnessAccess) than the query (a
|
|
// StructValue).
|
|
V as X({});
|
|
}
|
|
|
|
fn G(generic V: Z where .Z1 impls Y) {
|
|
// The type structure is `? as X(?)`, also built from ImplWitnessAccess insts,
|
|
// which will match the impl's `? as X(?)`.
|
|
V as X(V.(Z.Z1).(Y.Y1));
|
|
}
|
|
|
|
fn H(generic U: type, generic V: Z where .Z1 = C(U)) {
|
|
// The type structure is `? as X(?)`, without using an ImplWitnessAccess,
|
|
// which will match the impl's `? as X(?)`. This would fail if
|
|
// ImplWitnessAccess instructions were treated as Concrete in the type
|
|
// structure, since the impl's type structure would be more specific than the
|
|
// query's.
|
|
//
|
|
// TODO: This should pass.
|
|
// CHECK:STDERR: ╭─┤ fail_todo_impl_witness_access_in_impl_type_structure.carbon:[[@LINE+8]]:3
|
|
// CHECK:STDERR: -> │ V as X(U);
|
|
// CHECK:STDERR: · ┳━━━━━━━━
|
|
// CHECK:STDERR: · ┗━━┫ error: cannot convert type `V` that implements `Z where .(Z.Z1) = C(U)`
|
|
// CHECK:STDERR: · ┃ into type implementing `X(U)`
|
|
// CHECK:STDERR: · ┃ [ConversionFailureFacetToFacet]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
V as X(U);
|
|
}
|
|
|
|
// --- lookup_query_self_is_access_with_witness_from_nested_facet.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface HasNested {
|
|
let Nested: type;
|
|
}
|
|
|
|
interface Z {}
|
|
|
|
constraint ProvideZ {
|
|
require impls Z;
|
|
}
|
|
|
|
constraint NeedZ(T: Z) {}
|
|
|
|
constraint N {
|
|
extend require impls HasNested;
|
|
require Self.(Nested) impls ProvideZ;
|
|
|
|
// This performs an impl lookup `Self.(Nested) as Z`. When we identify
|
|
// the facet type of `Self` to find witnesses, we find a witness that
|
|
// `Self.(Nested)` impls `Z`.
|
|
require impls NeedZ(Self.(Nested));
|
|
}
|