Files
carbon-lang/toolchain/check/testdata/facet/runtime_value.carbon
T
Chandler Carruth d0badecd2a Switch tests to use the rendered form of diagnostics (#8070)
Historically, we disabled the rendered form in tests outside of
`toolchain/diagnostics`. The idea was to keep tests shorter and avoid
very long chains of autoupdate before stabilizing due to all the line
numbers and other artifacts in the rendered form.

This PR adds `--diagnostic-line-numbers=[all|first]` and defaults to
`first` in tests. This keeps the rendered form so that we can easily
code review that form and the visual cues it does or doesn't provide.
But it removes all but the first location's line numbers to provide
significantly more stability in tests.

By default, tests get the full unicode line-drawing form of diagnostics
so we can ensure all of the artifacts there make sense with the specific
case being diagnosed, but we do retain some focused ASCII-rendering
tests to ensure that fallback remains usable.

There are some issues here that will be fixed in subsequent PRs.
Notably, we try to keep the frame together in the check lines, and so
force some parts to use the first location. This largely works, but
fails in some edge cases, causing the entire frame to be located
incorrectly. There is a TODO about this that we need to fix, and it only
occurs 6 times across the test suite, so it didn't seem worth
front-loading a fix for here.

Assisted-by: Claude Code
2026-11-05 07:19:59 +00:00

241 lines
9.6 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/facet/runtime_value.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/facet/runtime_value.carbon
// --- facet_value_copy_from_reference.carbon
library "[[@TEST_NAME]]";
interface I {}
class C {
var i: I;
}
fn F(c: C) {
// Member access produces a reference, which is copied into the value
// binding.
//@dump-sem-ir-begin
let unused a: I = c.i;
//@dump-sem-ir-end
}
// --- fail_todo_facet_copy_narrowing_from_reference.carbon
library "[[@TEST_NAME]]";
interface I {}
interface J {}
class C {
var ij: I & J;
}
fn F(c: C) {
// Member access produces a reference, which is copied into the value
// binding.
//
// TODO: This copy should work, but the narrowing prevents it currently.
//
//@dump-sem-ir-begin
// CHECK:STDERR: ╭─┤ fail_todo_facet_copy_narrowing_from_reference.carbon:[[@LINE+8]]:21
// CHECK:STDERR: -> │ let unused a: I = c.ij;
// CHECK:STDERR: · ┳━━━
// CHECK:STDERR: · ┗━━┫ error: semantics TODO:
// CHECK:STDERR: · ┃ `conversion of runtime facet value`
// CHECK:STDERR: · ┃ [SemanticsTodo]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
let unused a: I = c.ij;
//@dump-sem-ir-end
}
// --- fail_compound_member_lookup_in_runtime_facet_without_value.carbon
library "[[@TEST_NAME]]";
interface Z {
let X: type;
}
// CHECK:STDERR: ╭─┤ fail_compound_member_lookup_in_runtime_facet_without_value.carbon:[[@LINE+8]]:15
// CHECK:STDERR: -> │ fn F(T: Z, v: T.(Z.X));
// CHECK:STDERR: · ┳━━━━━━
// CHECK:STDERR: · ┗━━┫ error: semantics TODO:
// CHECK:STDERR: · ┃ `associated value lookup on runtime facet value`
// CHECK:STDERR: · ┃ [SemanticsTodo]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
fn F(T: Z, v: T.(Z.X));
// --- fail_member_lookup_in_runtime_facet_without_value.carbon
library "[[@TEST_NAME]]";
interface Z {
let X: type;
}
// TODO: Improve this diagnostic. The problem is that T is a runtime facet
// _and_ its facet type doesn't specific a value for `.X`. Or make this work
// by producing an ImplWitnessAccess that functions against a runtime facet.
//
// CHECK:STDERR: ╭─┤ fail_member_lookup_in_runtime_facet_without_value.carbon:[[@LINE+8]]:15
// CHECK:STDERR: -> │ fn F(T: Z, v: T.X);
// CHECK:STDERR: · ┳━━
// CHECK:STDERR: · ┗━━┫ error: cannot access member of interface `Z` in type `Z` that
// CHECK:STDERR: · ┃ does not implement that interface
// CHECK:STDERR: · ┃ [MissingImplInMemberAccess]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
fn F(T: Z, v: T.X);
// --- fail_todo_compound_member_lookup_in_runtime_facet_with_value.carbon
library "[[@TEST_NAME]]";
interface Z {
let X: type;
}
// TODO: We should be able to get the value of `.X` from the `FacetType` of
// `T`.
//
// CHECK:STDERR: ╭─┤ fail_todo_compound_member_lookup_in_runtime_facet_with_value.carbon:[[@LINE+8]]:29
// CHECK:STDERR: -> │ fn F(T: Z where .X = (), v: T.(Z.X));
// CHECK:STDERR: · ┳━━━━━━
// CHECK:STDERR: · ┗━━┫ error: semantics TODO:
// CHECK:STDERR: · ┃ `conversion of runtime facet value`
// CHECK:STDERR: · ┃ [SemanticsTodo]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
fn F(T: Z where .X = (), v: T.(Z.X));
// --- fail_todo_member_lookup_in_runtime_facet_with_value.carbon
library "[[@TEST_NAME]]";
interface Z {
let X: type;
}
// TODO: We should be able to get the value of `.X` from the `FacetType` of
// `T`.
//
// CHECK:STDERR: ╭─┤ fail_todo_member_lookup_in_runtime_facet_with_value.carbon:[[@LINE+9]]:29
// CHECK:STDERR: -> │ fn F(T: Z where .X = (), v: T.X);
// CHECK:STDERR: · ┳━━
// CHECK:STDERR: · ┗━━┫ error: cannot access member of interface `Z` in
// CHECK:STDERR: · ┃ type `Z where .(Z.X) = ()` that does not
// CHECK:STDERR: · ┃ implement that interface
// CHECK:STDERR: · ┃ [MissingImplInMemberAccess]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
fn F(T: Z where .X = (), v: T.X);
// --- fail_todo_member_lookup_in_type_of_runtime_facet_with_value.carbon
library "[[@TEST_NAME]]";
interface Z {
fn G();
}
fn F(T: Z) {
// CHECK:STDERR: ╭─┤ fail_todo_member_lookup_in_type_of_runtime_facet_with_value.carbon:[[@LINE+8]]:3
// CHECK:STDERR: -> │ T.G();
// CHECK:STDERR: · ┳━━
// CHECK:STDERR: · ┗━━┫ error: cannot access member of interface `Z` in type `Z` that does not
// CHECK:STDERR: · ┃ implement that interface
// CHECK:STDERR: · ┃ [MissingImplInMemberAccess]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
T.G();
}
// --- fail_member_access_runtime_facet.carbon
library "[[@TEST_NAME]]";
interface Z {
fn G();
}
fn F(T: Z) {
// CHECK:STDERR: ╭─┤ fail_member_access_runtime_facet.carbon:[[@LINE+8]]:3
// CHECK:STDERR: -> │ T.G();
// CHECK:STDERR: · ┳━━
// CHECK:STDERR: · ┗━━┫ error: cannot access member of interface `Z` in type `Z` that does not
// CHECK:STDERR: · ┃ implement that interface
// CHECK:STDERR: · ┃ [MissingImplInMemberAccess]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
T.G();
}
// --- fail_member_access_runtime_type.carbon
library "[[@TEST_NAME]]";
fn F(T: type) {
// CHECK:STDERR: ╭─┤ fail_member_access_runtime_type.carbon:[[@LINE+7]]:3
// CHECK:STDERR: -> │ T.G();
// CHECK:STDERR: · ━┳━
// CHECK:STDERR: · ┗━━┫ error: type `type` does not support qualified expressions
// CHECK:STDERR: · ┃ [QualifiedExprUnsupported]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
T.G();
}
// CHECK:STDOUT: --- facet_value_copy_from_reference.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %I.type: type = facet_type <@I> [concrete]
// CHECK:STDOUT: %C: type = class_type @C [concrete]
// CHECK:STDOUT: %pattern_type.6cb: type = pattern_type %I.type [concrete]
// CHECK:STDOUT: %C.elem: type = unbound_element_type %C, %I.type [concrete]
// CHECK:STDOUT: %a.patt: %pattern_type.6cb = value_binding_pattern a [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @F(%c.param: %C) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %c.ref: %C = name_ref c, %c
// CHECK:STDOUT: %i.ref: %C.elem = name_ref i, @C.%field_decl [concrete = @C.%field_decl]
// CHECK:STDOUT: %.loc13_22.1: ref %I.type = class_element_access %c.ref, element0
// CHECK:STDOUT: %.loc13_22.2: %I.type = acquire_value %.loc13_22.1
// CHECK:STDOUT: %I.ref: type = name_ref I, file.%I.decl [concrete = constants.%I.type]
// CHECK:STDOUT: %a: %I.type = wrapper_binding a, %.loc13_22.2
// CHECK:STDOUT: name_binding_decl {
// CHECK:STDOUT: %a.patt: %pattern_type.6cb = value_binding_pattern a [concrete = constants.%a.patt]
// CHECK:STDOUT: }
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: --- fail_todo_facet_copy_narrowing_from_reference.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %I.type: type = facet_type <@I> [concrete]
// CHECK:STDOUT: %C: type = class_type @C [concrete]
// CHECK:STDOUT: %facet_type: type = facet_type <@I & @J> [concrete]
// CHECK:STDOUT: %C.elem: type = unbound_element_type %C, %facet_type [concrete]
// CHECK:STDOUT: %pattern_type.6cb: type = pattern_type %I.type [concrete]
// CHECK:STDOUT: %a.patt: %pattern_type.6cb = value_binding_pattern a [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @F(%c.param: %C) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %c.ref: %C = name_ref c, %c
// CHECK:STDOUT: %ij.ref: %C.elem = name_ref ij, @C.%field_decl [concrete = @C.%field_decl]
// CHECK:STDOUT: %.loc25_22.1: ref %facet_type = class_element_access %c.ref, element0
// CHECK:STDOUT: %.loc25_22.2: %facet_type = acquire_value %.loc25_22.1
// CHECK:STDOUT: %I.ref: type = name_ref I, file.%I.decl [concrete = constants.%I.type]
// CHECK:STDOUT: %a: %I.type = wrapper_binding a, <error> [concrete = <error>]
// CHECK:STDOUT: name_binding_decl {
// CHECK:STDOUT: %a.patt: %pattern_type.6cb = value_binding_pattern a [concrete = constants.%a.patt]
// CHECK:STDOUT: }
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT: