Files
carbon-lang/toolchain/lower/handle_aggregates.cpp
T
4845f40dff Switch CARBON_CHECK to a format string API (#4285)
This switches `DCHECK` and `FATAL` as well.

The goal is to reduce the code size impact of these assertions so that
we can keep more of them enabled. Currently, the largest cost I see from
`CHECK` is not the actual check or the cold code itself, but actually
the failure to inline trivial functions due to the presence of the cold
code. This means that our goal isn't to reduce apparent code size in the
final binary but the LLVM IR cost assessed for these routines in the
inliner, which closely correlates with code size but is a bit different.

As discussed in #4283, experimentation shows that a single function call
with a minimal number of arguments is the lowest cost model for these.
This is easily achieved with a format-string API that internally uses
`llvm::formatv`. This PR is essentially the `CHECK` version of #4283.

However, the check macros are substantially harder to make work with
both format strings and streaming because they also take a condition.
Also, unexpectedly, I was very successful at devising a regular
expression based automated rewrite from the streaming to the format
string form with only low 10s of manual fixes. This includes compacting
strings broken up across lines, etc. Given how well that went, I've
prepared this PR which just directly switches to the format string API
and migrate everything to use it.

One nice side-effect is that the format string approach ends up greatly
simplifying the implementation here as well.

This is ... *shockingly* effective. Parsing speeds up by more than 3%
with just this change. And checking speeds up by **8%** with this change
alone:
```
BM_CompileAPIFileDenseDecls<Phase::Parse>/256      86.3µs ± 1%  82.9µs ± 1%  -3.94%  (p=0.000 n=17+19)
BM_CompileAPIFileDenseDecls<Phase::Parse>/1024      431µs ± 1%   415µs ± 1%  -3.76%  (p=0.000 n=18+19)
BM_CompileAPIFileDenseDecls<Phase::Parse>/4096     1.77ms ± 1%  1.71ms ± 1%  -3.18%  (p=0.000 n=18+19)
BM_CompileAPIFileDenseDecls<Phase::Parse>/16384    7.44ms ± 1%  7.17ms ± 2%  -3.56%  (p=0.000 n=18+20)
BM_CompileAPIFileDenseDecls<Phase::Parse>/65536    30.7ms ± 1%  29.7ms ± 1%  -3.15%  (p=0.000 n=18+20)
BM_CompileAPIFileDenseDecls<Phase::Parse>/262144    131ms ± 1%   127ms ± 1%  -2.81%  (p=0.000 n=18+18)
BM_CompileAPIFileDenseDecls<Phase::Check>/256       878µs ± 2%   800µs ± 1%  -8.91%  (p=0.000 n=19+20)
BM_CompileAPIFileDenseDecls<Phase::Check>/1024     1.88ms ± 2%  1.72ms ± 1%  -8.56%  (p=0.000 n=19+20)
BM_CompileAPIFileDenseDecls<Phase::Check>/4096     5.78ms ± 2%  5.28ms ± 1%  -8.70%  (p=0.000 n=20+18)
BM_CompileAPIFileDenseDecls<Phase::Check>/16384    21.9ms ± 1%  20.1ms ± 1%  -8.02%  (p=0.000 n=18+20)
BM_CompileAPIFileDenseDecls<Phase::Check>/65536    90.4ms ± 2%  83.1ms ± 1%  -8.04%  (p=0.000 n=19+20)
BM_CompileAPIFileDenseDecls<Phase::Check>/262144    381ms ± 2%   352ms ± 1%  -7.79%  (p=0.000 n=19+19)
```

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
2024-09-12 16:42:08 +00:00

281 lines
11 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/Twine.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/Value.h"
#include "toolchain/lower/function_context.h"
#include "toolchain/sem_ir/inst.h"
#include "toolchain/sem_ir/typed_insts.h"
namespace Carbon::Lower {
auto HandleInst(FunctionContext& /*context*/, SemIR::InstId /*inst_id*/,
SemIR::ClassDecl /*inst*/) -> void {
// No action to perform.
}
// Extracts an element of an aggregate, such as a struct, tuple, or class, by
// index. Depending on the expression category and value representation of the
// aggregate input, this will either produce a value or a reference.
static auto GetAggregateElement(FunctionContext& context,
SemIR::InstId aggr_inst_id,
SemIR::ElementIndex idx,
SemIR::TypeId result_type_id, llvm::Twine name)
-> llvm::Value* {
auto aggr_inst = context.sem_ir().insts().Get(aggr_inst_id);
auto* aggr_value = context.GetValue(aggr_inst_id);
switch (SemIR::GetExprCategory(context.sem_ir(), aggr_inst_id)) {
case SemIR::ExprCategory::Error:
case SemIR::ExprCategory::NotExpr:
case SemIR::ExprCategory::Initializing:
case SemIR::ExprCategory::Mixed:
CARBON_FATAL("Unexpected expression category for aggregate access");
case SemIR::ExprCategory::Value: {
auto value_rep =
SemIR::ValueRepr::ForType(context.sem_ir(), aggr_inst.type_id());
CARBON_CHECK(value_rep.aggregate_kind != SemIR::ValueRepr::NotAggregate,
"aggregate type should have aggregate value representation");
switch (value_rep.kind) {
case SemIR::ValueRepr::Unknown:
CARBON_FATAL("Lowering access to incomplete aggregate type");
case SemIR::ValueRepr::None:
return aggr_value;
case SemIR::ValueRepr::Copy:
// We are holding the values of the aggregate directly, elementwise.
return context.builder().CreateExtractValue(aggr_value, idx.index,
name);
case SemIR::ValueRepr::Pointer: {
// The value representation is a pointer to an aggregate that we want
// to index into.
auto pointee_type_id =
context.sem_ir().GetPointeeType(value_rep.type_id);
auto* value_type = context.GetType(pointee_type_id);
auto* elem_ptr = context.builder().CreateStructGEP(
value_type, aggr_value, idx.index, name);
if (!value_rep.elements_are_values()) {
// `elem_ptr` points to an object representation, which is our
// result.
return elem_ptr;
}
// `elem_ptr` points to a value representation. Load it.
auto result_value_type_id =
SemIR::ValueRepr::ForType(context.sem_ir(), result_type_id)
.type_id;
return context.builder().CreateLoad(
context.GetType(result_value_type_id), elem_ptr, name + ".load");
}
case SemIR::ValueRepr::Custom:
CARBON_FATAL(
"Aggregate should never have custom value representation");
}
}
case SemIR::ExprCategory::DurableRef:
case SemIR::ExprCategory::EphemeralRef: {
// Just locate the aggregate element.
auto* aggr_type = context.GetType(aggr_inst.type_id());
return context.builder().CreateStructGEP(aggr_type, aggr_value, idx.index,
name);
}
}
}
static auto GetStructFieldName(FunctionContext& context,
SemIR::TypeId struct_type_id,
SemIR::ElementIndex index) -> llvm::StringRef {
auto fields = context.sem_ir().inst_blocks().Get(
context.sem_ir()
.types()
.GetAs<SemIR::StructType>(struct_type_id)
.fields_id);
auto field = context.sem_ir().insts().GetAs<SemIR::StructTypeField>(
fields[index.index]);
return context.sem_ir().names().GetIRBaseName(field.name_id);
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::ClassElementAccess inst) -> void {
// Find the class that we're performing access into.
auto class_type_id = context.sem_ir().insts().Get(inst.base_id).type_id();
auto class_id =
context.sem_ir().types().GetAs<SemIR::ClassType>(class_type_id).class_id;
const auto& class_info = context.sem_ir().classes().Get(class_id);
// Translate the class field access into a struct access on the object
// representation.
context.SetLocal(
inst_id,
GetAggregateElement(
context, inst.base_id, inst.index, inst.type_id,
GetStructFieldName(context, class_info.object_repr_id, inst.index)));
}
static auto EmitAggregateInitializer(FunctionContext& context,
SemIR::TypeId type_id,
SemIR::InstBlockId refs_id,
llvm::Twine name) -> llvm::Value* {
auto* llvm_type = context.GetType(type_id);
switch (SemIR::InitRepr::ForType(context.sem_ir(), type_id).kind) {
case SemIR::InitRepr::None:
case SemIR::InitRepr::InPlace:
// TODO: Add a helper to poison a value slot.
return llvm::PoisonValue::get(llvm_type);
case SemIR::InitRepr::ByCopy: {
auto refs = context.sem_ir().inst_blocks().Get(refs_id);
CARBON_CHECK(
refs.size() == 1,
"Unexpected size for aggregate with by-copy value representation");
// TODO: Remove the LLVM StructType wrapper in this case, so we don't
// need this `insert_value` wrapping.
return context.builder().CreateInsertValue(
llvm::PoisonValue::get(llvm_type), context.GetValue(refs[0]), {0},
name);
}
case SemIR::InitRepr::Incomplete:
CARBON_FATAL("Lowering aggregate initialization of incomplete type {0}",
context.sem_ir().types().GetAsInst(type_id));
}
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::ClassInit inst) -> void {
context.SetLocal(
inst_id, EmitAggregateInitializer(context, inst.type_id, inst.elements_id,
"class.init"));
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::StructAccess inst) -> void {
auto struct_type_id = context.sem_ir().insts().Get(inst.struct_id).type_id();
context.SetLocal(
inst_id, GetAggregateElement(
context, inst.struct_id, inst.index, inst.type_id,
GetStructFieldName(context, struct_type_id, inst.index)));
}
auto HandleInst(FunctionContext& /*context*/, SemIR::InstId /*inst_id*/,
SemIR::StructLiteral /*inst*/) -> void {
// A StructLiteral should always be converted to a StructInit or StructValue
// if its value is needed.
}
// Emits the value representation for a struct or tuple whose elements are the
// contents of `refs_id`.
static auto EmitAggregateValueRepr(FunctionContext& context,
SemIR::TypeId type_id,
SemIR::InstBlockId refs_id) -> llvm::Value* {
auto value_rep = SemIR::ValueRepr::ForType(context.sem_ir(), type_id);
switch (value_rep.kind) {
case SemIR::ValueRepr::Unknown:
CARBON_FATAL("Incomplete aggregate type in lowering");
case SemIR::ValueRepr::None:
// TODO: Add a helper to get a "no value representation" value.
return llvm::PoisonValue::get(context.GetType(value_rep.type_id));
case SemIR::ValueRepr::Copy: {
auto refs = context.sem_ir().inst_blocks().Get(refs_id);
CARBON_CHECK(
refs.size() == 1,
"Unexpected size for aggregate with by-copy value representation");
// TODO: Remove the LLVM StructType wrapper in this case, so we don't
// need this `insert_value` wrapping.
return context.builder().CreateInsertValue(
llvm::PoisonValue::get(context.GetType(value_rep.type_id)),
context.GetValue(refs[0]), {0});
}
case SemIR::ValueRepr::Pointer: {
auto pointee_type_id = context.sem_ir().GetPointeeType(value_rep.type_id);
auto* llvm_value_rep_type = context.GetType(pointee_type_id);
// Write the value representation to a local alloca so we can produce a
// pointer to it as the value representation of the struct or tuple.
auto* alloca = context.builder().CreateAlloca(llvm_value_rep_type);
for (auto [i, ref] :
llvm::enumerate(context.sem_ir().inst_blocks().Get(refs_id))) {
context.builder().CreateStore(
context.GetValue(ref),
context.builder().CreateStructGEP(llvm_value_rep_type, alloca, i));
}
return alloca;
}
case SemIR::ValueRepr::Custom:
CARBON_FATAL("Aggregate should never have custom value representation");
}
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::StructInit inst) -> void {
context.SetLocal(
inst_id, EmitAggregateInitializer(context, inst.type_id, inst.elements_id,
"struct.init"));
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::StructValue inst) -> void {
if (auto fn_type = context.sem_ir().types().TryGetAs<SemIR::FunctionType>(
inst.type_id)) {
context.SetLocal(inst_id, context.GetFunction(fn_type->function_id));
return;
}
context.SetLocal(
inst_id, EmitAggregateValueRepr(context, inst.type_id, inst.elements_id));
}
auto HandleInst(FunctionContext& /*context*/, SemIR::InstId /*inst_id*/,
SemIR::StructTypeField /*inst*/) -> void {
// No action to take.
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::TupleAccess inst) -> void {
context.SetLocal(inst_id,
GetAggregateElement(context, inst.tuple_id, inst.index,
inst.type_id, "tuple.elem"));
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::TupleIndex inst) -> void {
auto index_inst =
context.sem_ir().insts().GetAs<SemIR::IntLiteral>(inst.index_id);
auto index = context.sem_ir().ints().Get(index_inst.int_id).getZExtValue();
context.SetLocal(inst_id, GetAggregateElement(context, inst.tuple_id,
SemIR::ElementIndex(index),
inst.type_id, "tuple.index"));
}
auto HandleInst(FunctionContext& /*context*/, SemIR::InstId /*inst_id*/,
SemIR::TupleLiteral /*inst*/) -> void {
// A TupleLiteral should always be converted to a TupleInit or TupleValue if
// its value is needed.
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::TupleInit inst) -> void {
context.SetLocal(
inst_id, EmitAggregateInitializer(context, inst.type_id, inst.elements_id,
"tuple.init"));
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
SemIR::TupleValue inst) -> void {
context.SetLocal(
inst_id, EmitAggregateValueRepr(context, inst.type_id, inst.elements_id));
}
} // namespace Carbon::Lower