mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
This switches `DCHECK` and `FATAL` as well. The goal is to reduce the code size impact of these assertions so that we can keep more of them enabled. Currently, the largest cost I see from `CHECK` is not the actual check or the cold code itself, but actually the failure to inline trivial functions due to the presence of the cold code. This means that our goal isn't to reduce apparent code size in the final binary but the LLVM IR cost assessed for these routines in the inliner, which closely correlates with code size but is a bit different. As discussed in #4283, experimentation shows that a single function call with a minimal number of arguments is the lowest cost model for these. This is easily achieved with a format-string API that internally uses `llvm::formatv`. This PR is essentially the `CHECK` version of #4283. However, the check macros are substantially harder to make work with both format strings and streaming because they also take a condition. Also, unexpectedly, I was very successful at devising a regular expression based automated rewrite from the streaming to the format string form with only low 10s of manual fixes. This includes compacting strings broken up across lines, etc. Given how well that went, I've prepared this PR which just directly switches to the format string API and migrate everything to use it. One nice side-effect is that the format string approach ends up greatly simplifying the implementation here as well. This is ... *shockingly* effective. Parsing speeds up by more than 3% with just this change. And checking speeds up by **8%** with this change alone: ``` BM_CompileAPIFileDenseDecls<Phase::Parse>/256 86.3µs ± 1% 82.9µs ± 1% -3.94% (p=0.000 n=17+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/1024 431µs ± 1% 415µs ± 1% -3.76% (p=0.000 n=18+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/4096 1.77ms ± 1% 1.71ms ± 1% -3.18% (p=0.000 n=18+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/16384 7.44ms ± 1% 7.17ms ± 2% -3.56% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Parse>/65536 30.7ms ± 1% 29.7ms ± 1% -3.15% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Parse>/262144 131ms ± 1% 127ms ± 1% -2.81% (p=0.000 n=18+18) BM_CompileAPIFileDenseDecls<Phase::Check>/256 878µs ± 2% 800µs ± 1% -8.91% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/1024 1.88ms ± 2% 1.72ms ± 1% -8.56% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/4096 5.78ms ± 2% 5.28ms ± 1% -8.70% (p=0.000 n=20+18) BM_CompileAPIFileDenseDecls<Phase::Check>/16384 21.9ms ± 1% 20.1ms ± 1% -8.02% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Check>/65536 90.4ms ± 2% 83.1ms ± 1% -8.04% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/262144 381ms ± 2% 352ms ± 1% -7.79% (p=0.000 n=19+19) ``` --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk> Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
181 lines
6.9 KiB
C++
181 lines
6.9 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/generic.h"
|
|
#include "toolchain/check/handle.h"
|
|
#include "toolchain/check/member_access.h"
|
|
#include "toolchain/check/name_component.h"
|
|
#include "toolchain/check/pointer_dereference.h"
|
|
#include "toolchain/lex/token_kind.h"
|
|
#include "toolchain/sem_ir/inst.h"
|
|
#include "toolchain/sem_ir/typed_insts.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
auto HandleParseNode(Context& context, Parse::MemberAccessExprId node_id)
|
|
-> bool {
|
|
auto node_kind = context.node_stack().PeekNodeKind();
|
|
|
|
if (node_kind == Parse::NodeKind::ParenExpr) {
|
|
auto member_expr_id = context.node_stack().PopExpr();
|
|
auto base_id = context.node_stack().PopExpr();
|
|
auto member_id =
|
|
PerformCompoundMemberAccess(context, node_id, base_id, member_expr_id);
|
|
context.node_stack().Push(node_id, member_id);
|
|
} else if (node_kind == Parse::NodeKind::IntLiteral) {
|
|
auto index_inst_id = context.node_stack().PopExpr();
|
|
auto tuple_inst_id = context.node_stack().PopExpr();
|
|
|
|
auto tuple_value_inst_id =
|
|
PerformTupleIndex(context, node_id, tuple_inst_id, index_inst_id);
|
|
|
|
context.node_stack().Push(node_id, tuple_value_inst_id);
|
|
} else {
|
|
SemIR::NameId name_id = context.node_stack().PopName();
|
|
auto base_id = context.node_stack().PopExpr();
|
|
auto member_id = PerformMemberAccess(context, node_id, base_id, name_id);
|
|
context.node_stack().Push(node_id, member_id);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::PointerMemberAccessExprId node_id)
|
|
-> bool {
|
|
auto diagnose_not_pointer = [&context,
|
|
&node_id](SemIR::TypeId not_pointer_type_id) {
|
|
CARBON_DIAGNOSTIC(ArrowOperatorOfNonPointer, Error,
|
|
"Cannot apply `->` operator to non-pointer type `{0}`.",
|
|
SemIR::TypeId);
|
|
|
|
auto builder = context.emitter().Build(
|
|
TokenOnly(node_id), ArrowOperatorOfNonPointer, not_pointer_type_id);
|
|
builder.Emit();
|
|
};
|
|
|
|
auto node_kind = context.node_stack().PeekNodeKind();
|
|
|
|
if (node_kind == Parse::NodeKind::ParenExpr) {
|
|
auto member_expr_id = context.node_stack().PopExpr();
|
|
auto base_id = context.node_stack().PopExpr();
|
|
auto deref_base_id = PerformPointerDereference(context, node_id, base_id,
|
|
diagnose_not_pointer);
|
|
auto member_id = PerformCompoundMemberAccess(context, node_id,
|
|
deref_base_id, member_expr_id);
|
|
context.node_stack().Push(node_id, member_id);
|
|
} else if (node_kind == Parse::NodeKind::IntLiteral) {
|
|
auto index_inst_id = context.node_stack().PopExpr();
|
|
auto tuple_pointer_inst_id = context.node_stack().PopExpr();
|
|
auto tuple_inst_id = PerformPointerDereference(
|
|
context, node_id, tuple_pointer_inst_id, diagnose_not_pointer);
|
|
auto tuple_value_inst_id =
|
|
PerformTupleIndex(context, node_id, tuple_inst_id, index_inst_id);
|
|
|
|
context.node_stack().Push(node_id, tuple_value_inst_id);
|
|
} else {
|
|
SemIR::NameId name_id = context.node_stack().PopName();
|
|
auto base_id = context.node_stack().PopExpr();
|
|
auto deref_base_id = PerformPointerDereference(context, node_id, base_id,
|
|
diagnose_not_pointer);
|
|
auto member_id =
|
|
PerformMemberAccess(context, node_id, deref_base_id, name_id);
|
|
context.node_stack().Push(node_id, member_id);
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static auto GetIdentifierAsName(Context& context, Parse::NodeId node_id)
|
|
-> std::optional<SemIR::NameId> {
|
|
auto token = context.parse_tree().node_token(node_id);
|
|
if (context.tokens().GetKind(token) != Lex::TokenKind::Identifier) {
|
|
CARBON_CHECK(context.parse_tree().node_has_error(node_id));
|
|
return std::nullopt;
|
|
}
|
|
return SemIR::NameId::ForIdentifier(context.tokens().GetIdentifier(token));
|
|
}
|
|
|
|
// Handle a name that is used as an expression by performing unqualified name
|
|
// lookup.
|
|
static auto HandleNameAsExpr(Context& context, Parse::NodeId node_id,
|
|
SemIR::NameId name_id) -> bool {
|
|
auto result = context.LookupUnqualifiedName(node_id, name_id);
|
|
auto value = context.insts().Get(result.inst_id);
|
|
auto type_id = SemIR::GetTypeInSpecific(context.sem_ir(), result.specific_id,
|
|
value.type_id());
|
|
CARBON_CHECK(type_id.is_valid(), "Missing type for {0}", value);
|
|
|
|
// If the named entity has a constant value that depends on its specific,
|
|
// store the specific too.
|
|
if (result.specific_id.is_valid() &&
|
|
context.constant_values().Get(result.inst_id).is_symbolic()) {
|
|
result.inst_id = context.AddInst<SemIR::SpecificConstant>(
|
|
node_id, {.type_id = type_id,
|
|
.inst_id = result.inst_id,
|
|
.specific_id = result.specific_id});
|
|
}
|
|
|
|
context.AddInstAndPush<SemIR::NameRef>(
|
|
node_id,
|
|
{.type_id = type_id, .name_id = name_id, .value_id = result.inst_id});
|
|
return true;
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::IdentifierNameId node_id)
|
|
-> bool {
|
|
// The parent is responsible for binding the name.
|
|
auto name_id = GetIdentifierAsName(context, node_id);
|
|
if (!name_id) {
|
|
return context.TODO(node_id, "Error recovery from keyword name.");
|
|
}
|
|
context.node_stack().Push(node_id, *name_id);
|
|
return true;
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::IdentifierNameExprId node_id)
|
|
-> bool {
|
|
auto name_id = GetIdentifierAsName(context, node_id);
|
|
if (!name_id) {
|
|
return context.TODO(node_id, "Error recovery from keyword name.");
|
|
}
|
|
return HandleNameAsExpr(context, node_id, *name_id);
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::BaseNameId node_id) -> bool {
|
|
context.node_stack().Push(node_id, SemIR::NameId::Base);
|
|
return true;
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::SelfTypeNameExprId node_id)
|
|
-> bool {
|
|
return HandleNameAsExpr(context, node_id, SemIR::NameId::SelfType);
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::SelfValueNameId node_id) -> bool {
|
|
context.node_stack().Push(node_id, SemIR::NameId::SelfValue);
|
|
return true;
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::SelfValueNameExprId node_id)
|
|
-> bool {
|
|
return HandleNameAsExpr(context, node_id, SemIR::NameId::SelfValue);
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::NameQualifierId /*node_id*/)
|
|
-> bool {
|
|
context.decl_name_stack().ApplyNameQualifier(PopNameComponent(context));
|
|
return true;
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::PackageExprId node_id) -> bool {
|
|
context.AddInstAndPush<SemIR::NameRef>(
|
|
node_id,
|
|
{.type_id = context.GetBuiltinType(SemIR::BuiltinInstKind::NamespaceType),
|
|
.name_id = SemIR::NameId::PackageNamespace,
|
|
.value_id = SemIR::InstId::PackageNamespace});
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|