mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
103 lines
3.5 KiB
C++
103 lines
3.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/diagnostics/format_providers.h"
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "llvm/Support/FormatVariadic.h"
|
|
|
|
namespace Carbon::Diagnostics {
|
|
namespace {
|
|
|
|
using ::testing::Eq;
|
|
|
|
TEST(BoolAsSelect, Cases) {
|
|
constexpr char Format[] = "{0:a|b}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::BoolAsSelect(true)).str(),
|
|
Eq("a"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::BoolAsSelect(false)).str(),
|
|
Eq("b"));
|
|
}
|
|
|
|
TEST(BoolAsSelect, CasesWithNormalFormat) {
|
|
constexpr char Format[] = "{0} {0:a|b}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::BoolAsSelect(true)).str(),
|
|
Eq("true a"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::BoolAsSelect(false)).str(),
|
|
Eq("false b"));
|
|
}
|
|
|
|
TEST(BoolAsSelect, Spaces) {
|
|
constexpr char Format[] = "{0: a | b }";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::BoolAsSelect(true)).str(),
|
|
Eq(" a "));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::BoolAsSelect(false)).str(),
|
|
Eq(" b "));
|
|
}
|
|
|
|
TEST(IntAsSelect, OnlyDefault) {
|
|
constexpr char Format[] = "{0::default}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq("default"));
|
|
}
|
|
|
|
TEST(IntAsSelect, OneEquals) {
|
|
constexpr char Format[] = "{0:=0:zero}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq("zero"));
|
|
}
|
|
|
|
TEST(IntAsSelect, TwoEquals) {
|
|
constexpr char Format[] = "{0:=0:zero|=1:one}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq("zero"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(1)).str(),
|
|
Eq("one"));
|
|
}
|
|
|
|
TEST(IntAsSelect, TwoEqualsAndDefault) {
|
|
constexpr char Format[] = "{0:=0:zero|=1:one|:default}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq("zero"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(1)).str(),
|
|
Eq("one"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(2)).str(),
|
|
Eq("default"));
|
|
}
|
|
|
|
TEST(IntAsSelect, Spaces) {
|
|
constexpr char Format[] = "{0:=0: zero |=1: one |: default }";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq(" zero "));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(1)).str(),
|
|
Eq(" one "));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(2)).str(),
|
|
Eq(" default "));
|
|
}
|
|
|
|
TEST(IntAsSelect, CasesWithNormalFormat) {
|
|
constexpr char Format[] = "{0} argument{0:=1:|:s}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq("0 arguments"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(1)).str(),
|
|
Eq("1 argument"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(2)).str(),
|
|
Eq("2 arguments"));
|
|
}
|
|
|
|
TEST(IntAsSelect, PluralS) {
|
|
constexpr char Format[] = "{0} argument{0:s}";
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(0)).str(),
|
|
Eq("0 arguments"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(1)).str(),
|
|
Eq("1 argument"));
|
|
EXPECT_THAT(llvm::formatv(Format, Diagnostics::IntAsSelect(2)).str(),
|
|
Eq("2 arguments"));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Diagnostics
|