mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 19:38:11 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
280 lines
9.1 KiB
Plaintext
280 lines
9.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/where_expr/dot_self_impls.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/where_expr/dot_self_impls.carbon
|
|
|
|
// --- compound_member_access_through_where_self_impls.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
fn FNonInstance();
|
|
fn FSelf(self);
|
|
}
|
|
|
|
interface J {
|
|
fn GNonInstance();
|
|
fn GSelf(self);
|
|
}
|
|
|
|
fn INotJ[T: I where .Self impls J](x: T) {
|
|
// Can access members of `I` using either kind of member access.
|
|
T.FNonInstance();
|
|
T.(I.FNonInstance)();
|
|
|
|
x.FNonInstance();
|
|
x.FSelf();
|
|
x.(I.FSelf)();
|
|
|
|
// Can still find members of `J` using compound member access,
|
|
// even though they are not available via `T.GNonInstance` or
|
|
// `x.GSelf`.
|
|
T.(J.GNonInstance)();
|
|
x.(J.GSelf)();
|
|
}
|
|
|
|
fn TypeNotJ[T: type where .Self impls J](x: T) {
|
|
T.(J.GNonInstance)();
|
|
x.(J.GSelf)();
|
|
}
|
|
|
|
// --- no_name_conflict_with_where_self_impls.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
fn F() -> ();
|
|
}
|
|
|
|
interface J {
|
|
fn F() -> {};
|
|
}
|
|
|
|
fn INotJ(generic T: I where .Self impls J) {
|
|
// Gets `T.(I.F)`. Doesn't consider `T.(J.F)`, so no ambiguity.
|
|
let unused x: () = T.F();
|
|
}
|
|
|
|
// --- fail_name_lookup_through_where_self_impls.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
fn F();
|
|
}
|
|
|
|
interface J {
|
|
fn G();
|
|
}
|
|
|
|
fn INotJ(generic T: I where .Self impls J) {
|
|
// CHECK:STDERR: fail_name_lookup_through_where_self_impls.carbon:[[@LINE+2]]:3-5: error: member name `G` not found in `I` [MemberNameNotFoundInSpecificScope]
|
|
// CHECK:STDERR:
|
|
T.G();
|
|
}
|
|
|
|
// --- fail_name_lookup_with_type.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface J {
|
|
fn G();
|
|
}
|
|
|
|
fn TypeNotJ(generic T: type where .Self impls J) {
|
|
// CHECK:STDERR: fail_name_lookup_with_type.carbon:[[@LINE+2]]:3-5: error: member name `G` not found [MemberNameNotFound]
|
|
// CHECK:STDERR:
|
|
T.G();
|
|
}
|
|
|
|
// --- fail_facet_type_simple_member_access.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface A {}
|
|
interface B { fn Bfn(); }
|
|
|
|
fn F(generic T: A & B) {
|
|
// CHECK:STDERR: fail_facet_type_simple_member_access.carbon:[[@LINE+2]]:6-32: error: member name `Bfn` not found in `A` [MemberNameNotFoundInSpecificScope]
|
|
// CHECK:STDERR:
|
|
T.((A where .Self impls B).Bfn)();
|
|
|
|
// CHECK:STDERR: fail_facet_type_simple_member_access.carbon:[[@LINE+2]]:3-29: error: member name `Bfn` not found in `A` [MemberNameNotFoundInSpecificScope]
|
|
// CHECK:STDERR:
|
|
(A where .Self impls B).Bfn;
|
|
}
|
|
|
|
// --- fail_name_lookup_instance.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I {
|
|
fn FNonInstance();
|
|
fn FSelf(self);
|
|
}
|
|
|
|
interface J {
|
|
fn GNonInstance();
|
|
fn GSelf(self);
|
|
}
|
|
|
|
fn INotJ[T: I where .Self impls J](x: T) {
|
|
// CHECK:STDERR: fail_name_lookup_instance.carbon:[[@LINE+2]]:3-16: error: member name `GNonInstance` not found in `I` [MemberNameNotFoundInSpecificScope]
|
|
// CHECK:STDERR:
|
|
x.GNonInstance();
|
|
|
|
// CHECK:STDERR: fail_name_lookup_instance.carbon:[[@LINE+2]]:3-9: error: member name `GSelf` not found in `I` [MemberNameNotFoundInSpecificScope]
|
|
// CHECK:STDERR:
|
|
x.GSelf();
|
|
}
|
|
|
|
// --- compare_equal.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T: type) {}
|
|
fn AssertSame[T: type](unused a: WrapType(T), unused b: WrapType(T)) {}
|
|
fn Type(generic T: type) -> WrapType(T) { return {}; }
|
|
|
|
interface I;
|
|
interface J;
|
|
interface K;
|
|
|
|
fn Test() {
|
|
AssertSame(Type(I), Type(I where .Self impls I));
|
|
AssertSame(Type(I), Type(I where .Self impls I & I));
|
|
AssertSame(Type(I & J), Type(J & I where .Self impls I));
|
|
AssertSame(Type(I & J), Type(J & I where .Self impls J));
|
|
AssertSame(Type(I & J), Type(J & I where .Self impls I & J));
|
|
AssertSame(Type(I & J where .Self impls K), Type(J & I where .Self impls I & K));
|
|
AssertSame(Type(I & J where .Self impls K), Type(J & I where .Self impls J & K));
|
|
AssertSame(Type(I & J where .Self impls K), Type(J & I where .Self impls K & I & J));
|
|
AssertSame(Type(I where .Self impls J & K), Type(I where .Self impls K & I & J));
|
|
}
|
|
|
|
interface I {}
|
|
interface J {}
|
|
interface K {}
|
|
|
|
// --- fail_todo_compare_equal_with_rewrite.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T: type) {}
|
|
fn AssertSame[T: type](unused a: WrapType(T), unused b: WrapType(T)) {}
|
|
fn Type(generic T: type) -> WrapType(T) { return {}; }
|
|
|
|
interface I { let A: type; }
|
|
interface J { let B: type; }
|
|
|
|
// TODO: The `.Self` implied in `.A` contains all of the extended interfaces,
|
|
// which is different between these facet types at the point where `.A` is
|
|
// written. So the resulting facet types are different. We should drop
|
|
// interfaces from the rewrite constraint's LHS that don't apply so that we get
|
|
// a canonical representation of `.A` that is independent of the current state
|
|
// of `.Self` since `.A = ()` can not be written as, and is thus not equivalent
|
|
// to, `.Self.(I.A) = ()`.
|
|
|
|
fn Test() {
|
|
// TODO: This should pass.
|
|
// CHECK:STDERR: fail_todo_compare_equal_with_rewrite.carbon:[[@LINE+3]]:3-41: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: fail_todo_compare_equal_with_rewrite.carbon:[[@LINE-17]]:1-70: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
AssertSame(Type((I where .A = ()) & J),
|
|
Type(I & J where .A = ()));
|
|
// TODO: This should pass.
|
|
// CHECK:STDERR: fail_todo_compare_equal_with_rewrite.carbon:[[@LINE+3]]:3-41: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: fail_todo_compare_equal_with_rewrite.carbon:[[@LINE-23]]:1-70: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
AssertSame(Type(I & (J where .B = {})),
|
|
Type(I & J where .B = {}));
|
|
|
|
// TODO: This should pass.
|
|
// CHECK:STDERR: fail_todo_compare_equal_with_rewrite.carbon:[[@LINE+3]]:3-57: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: fail_todo_compare_equal_with_rewrite.carbon:[[@LINE-30]]:1-70: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
AssertSame(Type((I where .A = ()) & (J where .B = {})),
|
|
Type(I & J where .A = () and .B = {}));
|
|
}
|
|
|
|
// --- fail_compare_not_equal.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T: type) {}
|
|
fn Same[T: type](unused a: WrapType(T), unused b: WrapType(T)) {}
|
|
fn Type(generic T: type) -> WrapType(T) { return {}; }
|
|
|
|
interface I {}
|
|
interface J {}
|
|
|
|
fn Test() {
|
|
// CHECK:STDERR: fail_compare_not_equal.carbon:[[@LINE+3]]:3-64: error: inconsistent deductions for value of generic parameter `T` [DeductionInconsistent]
|
|
// CHECK:STDERR: fail_compare_not_equal.carbon:[[@LINE-8]]:1-64: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
Same(Type(I where .Self impls J), Type(J where .Self impls I));
|
|
}
|
|
|
|
// --- todo_fail_compare_not_equal_with_same_type.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class WrapType(T: type) {}
|
|
fn Same[T: type](unused a: WrapType(T), unused b: WrapType(T)) {}
|
|
fn Type(generic T: type) -> WrapType(T) { return {}; }
|
|
|
|
interface I { let A: type; }
|
|
interface J { let B: type; }
|
|
|
|
fn Test() {
|
|
// The first `.A` has a `.Self` of type `I`. The second contains a `.Self` of
|
|
// type `I & J`. That makes the two constaints `.A == ()` have different
|
|
// constant values, so these are different facet types.
|
|
//
|
|
// TODO: This should fail. We don't store same-type constraints in the facet type yet.
|
|
Same(Type((I where .A == ()) & J), Type(I & J where .A == ()));
|
|
}
|
|
|
|
// --- impl_as.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
class C {}
|
|
|
|
interface I {}
|
|
interface J { let T: type; }
|
|
|
|
// Interfaces to the right of the `where` don't interfere with the
|
|
// "can only impl a facet type with a single interface" rule. Only
|
|
// the interface being implemented needs to have all of its
|
|
// associated constants set.
|
|
impl {.a: C} as I where .Self impls J;
|
|
impl {.b: C} as J where .Self impls I and .T = ();
|
|
|
|
// The requirements after `where` must be met before we define the above impls.
|
|
impl {.a: C} as J where .T = () {}
|
|
impl {.a: C} as I where .Self impls J {}
|
|
impl {.b: C} as I {}
|
|
impl {.b: C} as J where .Self impls I and .T = () {}
|
|
|
|
// --- impl_with_rewrite_of_interface_not_being_implemented.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I { let A: type; }
|
|
interface J { let A: type; }
|
|
|
|
class C {}
|
|
|
|
// Implementation of `C as J`.
|
|
impl C as J where .A = {} {}
|
|
|
|
// Requirement of implementing J with `.A = A`.
|
|
constraint NeedJ(A: type) {
|
|
require impls J where .A = A;
|
|
}
|
|
|
|
// This is an implementation of `I` with `I.A = ()`. The requirement
|
|
// that `C` also impls `J where .A = {}` is an additional constraint
|
|
// that must be satisfied (and is satisfied by the impl above, though
|
|
// that currently isn't checked), but doesn't affect `C as I`.
|
|
impl C as I where .A = () and .Self impls NeedJ({}) {}
|
|
|
|
let x: C.(I.A) = ();
|
|
let y: C.(J.A) = {};
|