carbon-language/carbon-lang
1
0 Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-11-15 14:48:10 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
3af25cc1ba9c8b5ed1b4a2d779e71f2b86f11721
carbon-lang/toolchain/check/testdata/patterns/expression.carbon
T
Chandler Carruth 2c9739799b Render diagnostics through the terminal library (#7683) 
Diagnostic rendering was part of the data model: `Loc::FormatLocation`
and
`Loc::FormatSnippet` wrote plain text to a stream, so no capability,
color, or
terminal width could reach them.

A diagnostic is now one message with labels, contexts, and location
information
attached, and `Diagnostics::Renderer` draws it into a
`Terminal::Buffer`. The
design is in `toolchain/docs/diagnostics_rendering.md` (#7668),
authoring in
`toolchain/docs/diagnostics.md`.

Before:

```
example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments
  Run0(1);
  ^~~~~~~
example.carbon:3:1: note: calling function declared here
fn Run0() {}
^~~~~~~~~~~
```

After:

```
error: 1 argument passed to function expecting 0 arguments
       ╭─┤ example.carbon:6:3
       ┆
     3 │ fn Run0() {}
       · ─────┬─────
       ·      ╰──┤ calling function declared here
       ┆
->   6 │   Run0(1);
       ·   ───────
       ╰────────────
```

`--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`.
File
tests use it; the rendering tests under `toolchain/diagnostics/testdata`
ask for
snippets.

C++ interop diagnostics are data now rather than text Clang drew:
`SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang
location is
marked as the point it names.

`StreamConsumer` moves to a `:renderer` target that `:emitter` does not
depend
on, keeping `common/terminal` out of `consumer.h`. Capabilities come
from the
file behind the error stream, so tests get plain ASCII.

`renderer_fuzzer` draws diagnostics built from fuzzer bytes with every
capability combination, since a shape the renderer doesn't expect must
never be
why the compiler dies while reporting a problem.

TODOs mark the follow-ups: line weights and crossing lines, wrapping
that keeps
a quoted type whole, and ordering diagnostics that share a byte offset.

Also: `IncorrectExtension`'s hint moves into its message, since its note
had no
location of its own, and `strip_noise` in `check_diagnostics.py` blanks
multi-line `#define`s instead of deleting them.

Assisted-by: Claude Code
2026-10-15 06:08:57 +00:00

125 lines
5.5 KiB
Plaintext
Raw Blame History

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/patterns/expression.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/patterns/expression.carbon
// --- fail_todo_let.carbon
library "[[@TEST_NAME]]";
// TODO: We should reject this for using a refutable pattern in an irrefutable pattern context.
let a: () = ();
// CHECK:STDERR: fail_todo_let.carbon:[[@LINE+2]]:5: error: semantics TODO: `expression pattern` [SemanticsTodo]
// CHECK:STDERR:
let a = ();
// --- fail_todo_in_tuple.carbon
library "[[@TEST_NAME]]";
// TODO: We should reject this for using a refutable pattern in an irrefutable pattern context.
let a: () = ();
// CHECK:STDERR: fail_todo_in_tuple.carbon:[[@LINE+2]]:13: error: semantics TODO: `expression pattern` [SemanticsTodo]
// CHECK:STDERR:
let (b: (), a, c: ()) = ((), (), ());
// --- fail_todo_in_function_param.carbon
library "[[@TEST_NAME]]";
// TODO: We should reject this for using a refutable pattern in an irrefutable pattern context.
let a: () = ();
// CHECK:STDERR: fail_todo_in_function_param.carbon:[[@LINE+2]]:6: error: semantics TODO: `expression pattern` [SemanticsTodo]
// CHECK:STDERR:
fn F(a) {}
// --- fail_todo_parens.carbon
library "[[@TEST_NAME]]";
let a: () = ();
// TODO: Replace this with a valid expression pattern once we support refutable
// pattern contexts.
// Note that this is a parenthesized zero-tuple expression pattern, not a
// one-tuple pattern containing a zero-tuple.
// CHECK:STDERR: fail_todo_parens.carbon:[[@LINE+2]]:6: error: semantics TODO: `expression pattern` [SemanticsTodo]
// CHECK:STDERR:
let (a) = ();
// --- fail_todo_control_flow.carbon
library "[[@TEST_NAME]]";
fn F() {
// TODO: Replace this with a valid expression pattern once we support refutable
// pattern contexts.
//@dump-sem-ir-begin
// CHECK:STDERR: fail_todo_control_flow.carbon:[[@LINE+4]]:8-35: error: semantics TODO: `expression pattern` [SemanticsTodo]
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_control_flow.carbon:[[@LINE+2]]:38-50: error: semantics TODO: `expression pattern` [SemanticsTodo]
// CHECK:STDERR:
let (if true then true else false, true and true) = (true, true);
//@dump-sem-ir-end
}
// CHECK:STDOUT: --- fail_todo_control_flow.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %true: bool = bool_literal true [concrete]
// CHECK:STDOUT: %false: bool = bool_literal false [concrete]
// CHECK:STDOUT: %pattern_type.831: type = pattern_type bool [concrete]
// CHECK:STDOUT: %tuple.type: type = tuple_type (bool, bool) [concrete]
// CHECK:STDOUT: %pattern_type.860: type = pattern_type %tuple.type [concrete]
// CHECK:STDOUT: %.2f0: %pattern_type.860 = tuple_pattern (@F.%expr_patt.loc12_26, @F.%expr_patt.loc12_43) [concrete]
// CHECK:STDOUT: %tuple: %tuple.type = tuple_value (%true, %true) [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @F() {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %true.loc12_56: bool = bool_literal true [concrete = constants.%true]
// CHECK:STDOUT: %true.loc12_62: bool = bool_literal true [concrete = constants.%true]
// CHECK:STDOUT: %.loc12_66: %tuple.type = tuple_literal (%true.loc12_56, %true.loc12_62) [concrete = constants.%tuple]
// CHECK:STDOUT: name_binding_decl {
// CHECK:STDOUT: %expr_patt.loc12_26: %pattern_type.831 = expr_pattern %.loc12_8 in [concrete] {
// CHECK:STDOUT: %true.loc12_11: bool = bool_literal true [concrete = constants.%true]
// CHECK:STDOUT: if %true.loc12_11 br !if.expr.then else br !if.expr.else
// CHECK:STDOUT:
// CHECK:STDOUT: !if.expr.then:
// CHECK:STDOUT: %true.loc12_21: bool = bool_literal true [concrete = constants.%true]
// CHECK:STDOUT: br !if.expr.result(%true.loc12_21)
// CHECK:STDOUT:
// CHECK:STDOUT: !if.expr.else:
// CHECK:STDOUT: %false.loc12_31: bool = bool_literal false [concrete = constants.%false]
// CHECK:STDOUT: br !if.expr.result(%false.loc12_31)
// CHECK:STDOUT:
// CHECK:STDOUT: !if.expr.result:
// CHECK:STDOUT: %.loc12_8: bool = block_arg !if.expr.result [concrete = constants.%true]
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT: %expr_patt.loc12_43: %pattern_type.831 = expr_pattern %.loc12_43 in [concrete] {
// CHECK:STDOUT: %true.loc12_38: bool = bool_literal true [concrete = constants.%true]
// CHECK:STDOUT: %false.loc12_43: bool = bool_literal false [concrete = constants.%false]
// CHECK:STDOUT: if %true.loc12_38 br !and.rhs else br !.loc12(%false.loc12_43)
// CHECK:STDOUT:
// CHECK:STDOUT: !and.rhs:
// CHECK:STDOUT: %true.loc12_47: bool = bool_literal true [concrete = constants.%true]
// CHECK:STDOUT: br !.loc12(%true.loc12_47)
// CHECK:STDOUT:
// CHECK:STDOUT: !.loc12:
// CHECK:STDOUT: %.loc12_43: bool = block_arg !.loc12 [concrete = constants.%true]
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT: %.loc12_51: %pattern_type.860 = tuple_pattern (%expr_patt.loc12_26, %expr_patt.loc12_43) [concrete = constants.%.2f0]
// CHECK:STDOUT: }
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
Reference in new issue View Git Blame Copy Permalink