carbon-language/carbon-lang
1
0 Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-11-15 20:08:15 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
3af25cc1ba9c8b5ed1b4a2d779e71f2b86f11721
carbon-lang/toolchain/check/testdata/interface/fail_duplicate.carbon
T
Chandler Carruth 2c9739799b Render diagnostics through the terminal library (#7683) 
Diagnostic rendering was part of the data model: `Loc::FormatLocation`
and
`Loc::FormatSnippet` wrote plain text to a stream, so no capability,
color, or
terminal width could reach them.

A diagnostic is now one message with labels, contexts, and location
information
attached, and `Diagnostics::Renderer` draws it into a
`Terminal::Buffer`. The
design is in `toolchain/docs/diagnostics_rendering.md` (#7668),
authoring in
`toolchain/docs/diagnostics.md`.

Before:

```
example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments
  Run0(1);
  ^~~~~~~
example.carbon:3:1: note: calling function declared here
fn Run0() {}
^~~~~~~~~~~
```

After:

```
error: 1 argument passed to function expecting 0 arguments
       ╭─┤ example.carbon:6:3
       ┆
     3 │ fn Run0() {}
       · ─────┬─────
       ·      ╰──┤ calling function declared here
       ┆
->   6 │   Run0(1);
       ·   ───────
       ╰────────────
```

`--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`.
File
tests use it; the rendering tests under `toolchain/diagnostics/testdata`
ask for
snippets.

C++ interop diagnostics are data now rather than text Clang drew:
`SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang
location is
marked as the point it names.

`StreamConsumer` moves to a `:renderer` target that `:emitter` does not
depend
on, keeping `common/terminal` out of `consumer.h`. Capabilities come
from the
file behind the error stream, so tests get plain ASCII.

`renderer_fuzzer` draws diagnostics built from fuzzer bytes with every
capability combination, since a shape the renderer doesn't expect must
never be
why the compiler dies while reporting a problem.

TODOs mark the follow-ups: line weights and crossing lines, wrapping
that keeps
a quoted type whole, and ordering diagnostics that share a byte offset.

Also: `IncorrectExtension`'s hint moves into its message, since its note
had no
location of its own, and `strip_noise` in `check_diagnostics.py` blanks
multi-line `#define`s instead of deleting them.

Assisted-by: Claude Code
2026-10-15 06:08:57 +00:00

260 lines
14 KiB
Plaintext
Raw Blame History

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
// TODO: Add ranges and switch to "--dump-sem-ir-ranges=only".
// EXTRA-ARGS: --dump-sem-ir-ranges=if-present
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interface/fail_duplicate.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interface/fail_duplicate.carbon
// --- fail_redefine_without_dependents.carbon
library "[[@TEST_NAME]]";
interface Interface { }
// CHECK:STDERR: fail_redefine_without_dependents.carbon:[[@LINE+3]]:1-21: error: redefinition of `interface Interface` [RedeclRedef]
// CHECK:STDERR: fail_redefine_without_dependents.carbon:[[@LINE-3]]:1-21: note: previously defined here [RedeclPrevDef]
// CHECK:STDERR:
interface Interface {
fn F();
}
// --- fail_redefine_with_dependents.carbon
library "[[@TEST_NAME]]";
interface Interface {}
// CHECK:STDERR: fail_redefine_with_dependents.carbon:[[@LINE+3]]:1-21: error: redefinition of `interface Interface` [RedeclRedef]
// CHECK:STDERR: fail_redefine_with_dependents.carbon:[[@LINE-3]]:1-21: note: previously defined here [RedeclPrevDef]
// CHECK:STDERR:
interface Interface {
fn F(self);
}
// --- fail_name_conflict_with_fn.carbon
library "[[@TEST_NAME]]";
fn Function();
// CHECK:STDERR: fail_name_conflict_with_fn.carbon:[[@LINE+3]]:11-18: error: duplicate name `Function` being declared in the same scope [NameDeclDuplicate]
// CHECK:STDERR: fail_name_conflict_with_fn.carbon:[[@LINE-3]]:1-14: note: name is previously declared here [NameDeclPrevious]
// CHECK:STDERR:
interface Function;
// --- fail_name_conflict_with_class.carbon
class Class;
// CHECK:STDERR: fail_name_conflict_with_class.carbon:[[@LINE+3]]:11-15: error: duplicate name `Class` being declared in the same scope [NameDeclDuplicate]
// CHECK:STDERR: fail_name_conflict_with_class.carbon:[[@LINE-3]]:1-12: note: name is previously declared here [NameDeclPrevious]
// CHECK:STDERR:
interface Class { }
// CHECK:STDOUT: --- fail_redefine_without_dependents.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %Interface.type.283524.1: type = facet_type <@Interface.loc4> [concrete]
// CHECK:STDOUT: %Self.3ce02d.1: %Interface.type.283524.1 = symbolic_binding Self, 0 [symbolic]
// CHECK:STDOUT: %Interface.type.283524.2: type = facet_type <@Interface.loc9> [concrete]
// CHECK:STDOUT: %Self.3ce02d.2: %Interface.type.283524.2 = symbolic_binding Self, 0 [symbolic]
// CHECK:STDOUT: %Interface.WithSelf.F.type: type = fn_type @Interface.WithSelf.F, @Interface.WithSelf.loc9(%Self.3ce02d.2) [symbolic]
// CHECK:STDOUT: %Interface.WithSelf.F: %Interface.WithSelf.F.type = struct_value () [symbolic]
// CHECK:STDOUT: %Interface.assoc_type: type = assoc_entity_type @Interface.loc9 [concrete]
// CHECK:STDOUT: %assoc0: %Interface.assoc_type = assoc_entity element0, @Interface.WithSelf.loc9.%Interface.WithSelf.F.decl [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
// CHECK:STDOUT: .Interface = %Interface.decl.loc4
// CHECK:STDOUT: }
// CHECK:STDOUT: %Interface.decl.loc4: type = interface_decl @Interface.loc4 [concrete = constants.%Interface.type.283524.1] {} {}
// CHECK:STDOUT: %Interface.decl.loc9: type = interface_decl @Interface.loc9 [concrete = constants.%Interface.type.283524.2] {} {}
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: interface @Interface.loc4 {
// CHECK:STDOUT: %Self: %Interface.type.283524.1 = symbolic_binding Self, 0 [symbolic = constants.%Self.3ce02d.1]
// CHECK:STDOUT: %Interface.WithSelf.decl = interface_with_self_decl @Interface.loc4 [concrete]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = %Self
// CHECK:STDOUT: witness = ()
// CHECK:STDOUT:
// CHECK:STDOUT: !requires:
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: interface @Interface.loc9 {
// CHECK:STDOUT: %Self: %Interface.type.283524.2 = symbolic_binding Self, 0 [symbolic = constants.%Self.3ce02d.2]
// CHECK:STDOUT: %Interface.WithSelf.decl = interface_with_self_decl @Interface.loc9 [concrete]
// CHECK:STDOUT:
// CHECK:STDOUT: !with Self:
// CHECK:STDOUT: %Interface.WithSelf.F.decl: @Interface.WithSelf.loc9.%Interface.WithSelf.F.type (%Interface.WithSelf.F.type) = fn_decl @Interface.WithSelf.F [symbolic = @Interface.WithSelf.loc9.%Interface.WithSelf.F (constants.%Interface.WithSelf.F)] {} {}
// CHECK:STDOUT: %assoc0: %Interface.assoc_type = assoc_entity element0, %Interface.WithSelf.F.decl [concrete = constants.%assoc0]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = %Self
// CHECK:STDOUT: .F = @Interface.WithSelf.loc9.%assoc0
// CHECK:STDOUT: witness = (@Interface.WithSelf.loc9.%Interface.WithSelf.F.decl)
// CHECK:STDOUT:
// CHECK:STDOUT: !requires:
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: generic fn @Interface.WithSelf.F(@Interface.loc9.%Self: %Interface.type.283524.2) {
// CHECK:STDOUT: fn();
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Interface.WithSelf.loc4(constants.%Self.3ce02d.1) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Interface.WithSelf.loc9(constants.%Self.3ce02d.2) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Interface.WithSelf.F(constants.%Self.3ce02d.2) {}
// CHECK:STDOUT:
// CHECK:STDOUT: --- fail_redefine_with_dependents.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %Interface.type.283524.1: type = facet_type <@Interface.loc4> [concrete]
// CHECK:STDOUT: %Self.3ce02d.1: %Interface.type.283524.1 = symbolic_binding Self, 0 [symbolic]
// CHECK:STDOUT: %Interface.type.283524.2: type = facet_type <@Interface.loc9> [concrete]
// CHECK:STDOUT: %Self.3ce02d.2: %Interface.type.283524.2 = symbolic_binding Self, 0 [symbolic]
// CHECK:STDOUT: %Self.as_type: type = facet_access_type %Self.3ce02d.2 [symbolic]
// CHECK:STDOUT: %pattern_type: type = pattern_type %Self.as_type [symbolic]
// CHECK:STDOUT: %self.param_patt: %pattern_type = value_param_pattern [symbolic]
// CHECK:STDOUT: %self.patt: %pattern_type = wrapper_binding_pattern self, %self.param_patt [symbolic]
// CHECK:STDOUT: %Interface.WithSelf.F.type: type = fn_type @Interface.WithSelf.F, @Interface.WithSelf.loc9(%Self.3ce02d.2) [symbolic]
// CHECK:STDOUT: %Interface.WithSelf.F: %Interface.WithSelf.F.type = struct_value () [symbolic]
// CHECK:STDOUT: %Interface.assoc_type: type = assoc_entity_type @Interface.loc9 [concrete]
// CHECK:STDOUT: %assoc0: %Interface.assoc_type = assoc_entity element0, @Interface.WithSelf.loc9.%Interface.WithSelf.F.decl [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
// CHECK:STDOUT: .Interface = %Interface.decl.loc4
// CHECK:STDOUT: }
// CHECK:STDOUT: %Interface.decl.loc4: type = interface_decl @Interface.loc4 [concrete = constants.%Interface.type.283524.1] {} {}
// CHECK:STDOUT: %Interface.decl.loc9: type = interface_decl @Interface.loc9 [concrete = constants.%Interface.type.283524.2] {} {}
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: interface @Interface.loc4 {
// CHECK:STDOUT: %Self: %Interface.type.283524.1 = symbolic_binding Self, 0 [symbolic = constants.%Self.3ce02d.1]
// CHECK:STDOUT: %Interface.WithSelf.decl = interface_with_self_decl @Interface.loc4 [concrete]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = %Self
// CHECK:STDOUT: witness = ()
// CHECK:STDOUT:
// CHECK:STDOUT: !requires:
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: interface @Interface.loc9 {
// CHECK:STDOUT: %Self: %Interface.type.283524.2 = symbolic_binding Self, 0 [symbolic = constants.%Self.3ce02d.2]
// CHECK:STDOUT: %Interface.WithSelf.decl = interface_with_self_decl @Interface.loc9 [concrete]
// CHECK:STDOUT:
// CHECK:STDOUT: !with Self:
// CHECK:STDOUT: %Interface.WithSelf.F.decl: @Interface.WithSelf.loc9.%Interface.WithSelf.F.type (%Interface.WithSelf.F.type) = fn_decl @Interface.WithSelf.F [symbolic = @Interface.WithSelf.loc9.%Interface.WithSelf.F (constants.%Interface.WithSelf.F)] {
// CHECK:STDOUT: %self.param_patt.loc10_8.1: @Interface.WithSelf.F.%pattern_type (%pattern_type) = value_param_pattern [symbolic = %self.param_patt.loc10_8.2 (constants.%self.param_patt)]
// CHECK:STDOUT: %self.patt.loc10_8.1: @Interface.WithSelf.F.%pattern_type (%pattern_type) = wrapper_binding_pattern self, %self.param_patt.loc10_8.1 [symbolic = %self.patt.loc10_8.2 (constants.%self.patt)]
// CHECK:STDOUT: } {
// CHECK:STDOUT: %self.param: @Interface.WithSelf.F.%Self.as_type.loc10_8.1 (%Self.as_type) = value_param call_param0
// CHECK:STDOUT: %.loc10_8.1: type = splice_block %.loc10_8.2 [symbolic = %Self.as_type.loc10_8.1 (constants.%Self.as_type)] {
// CHECK:STDOUT: %Self.ref: %Interface.type.283524.2 = name_ref Self, @Interface.loc9.%Self [symbolic = %Self (constants.%Self.3ce02d.2)]
// CHECK:STDOUT: %Self.as_type.loc10_8.2: type = facet_access_type %Self.ref [symbolic = %Self.as_type.loc10_8.1 (constants.%Self.as_type)]
// CHECK:STDOUT: %.loc10_8.2: type = converted %Self.ref, %Self.as_type.loc10_8.2 [symbolic = %Self.as_type.loc10_8.1 (constants.%Self.as_type)]
// CHECK:STDOUT: }
// CHECK:STDOUT: %self: @Interface.WithSelf.F.%Self.as_type.loc10_8.1 (%Self.as_type) = wrapper_binding self, %self.param
// CHECK:STDOUT: }
// CHECK:STDOUT: %assoc0: %Interface.assoc_type = assoc_entity element0, %Interface.WithSelf.F.decl [concrete = constants.%assoc0]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = %Self
// CHECK:STDOUT: .F = @Interface.WithSelf.loc9.%assoc0
// CHECK:STDOUT: witness = (@Interface.WithSelf.loc9.%Interface.WithSelf.F.decl)
// CHECK:STDOUT:
// CHECK:STDOUT: !requires:
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: generic fn @Interface.WithSelf.F(@Interface.loc9.%Self: %Interface.type.283524.2) {
// CHECK:STDOUT: %Self: %Interface.type.283524.2 = symbolic_binding Self, 0 [symbolic = %Self (constants.%Self.3ce02d.2)]
// CHECK:STDOUT: %Self.as_type.loc10_8.1: type = facet_access_type %Self [symbolic = %Self.as_type.loc10_8.1 (constants.%Self.as_type)]
// CHECK:STDOUT: %pattern_type: type = pattern_type %Self.as_type.loc10_8.1 [symbolic = %pattern_type (constants.%pattern_type)]
// CHECK:STDOUT: %self.param_patt.loc10_8.2: @Interface.WithSelf.F.%pattern_type (%pattern_type) = value_param_pattern [symbolic = %self.param_patt.loc10_8.2 (constants.%self.param_patt)]
// CHECK:STDOUT: %self.patt.loc10_8.2: @Interface.WithSelf.F.%pattern_type (%pattern_type) = wrapper_binding_pattern self, %self.param_patt.loc10_8.2 [symbolic = %self.patt.loc10_8.2 (constants.%self.patt)]
// CHECK:STDOUT:
// CHECK:STDOUT: fn(%self.param: @Interface.WithSelf.F.%Self.as_type.loc10_8.1 (%Self.as_type));
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Interface.WithSelf.loc4(constants.%Self.3ce02d.1) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Interface.WithSelf.loc9(constants.%Self.3ce02d.2) {}
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Interface.WithSelf.F(constants.%Self.3ce02d.2) {
// CHECK:STDOUT: %Self => constants.%Self.3ce02d.2
// CHECK:STDOUT: %Self.as_type.loc10_8.1 => constants.%Self.as_type
// CHECK:STDOUT: %pattern_type => constants.%pattern_type
// CHECK:STDOUT: %self.param_patt.loc10_8.2 => constants.%self.param_patt
// CHECK:STDOUT: %self.patt.loc10_8.2 => constants.%self.patt
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: --- fail_name_conflict_with_fn.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %Function.type.b68: type = fn_type @Function.loc4 [concrete]
// CHECK:STDOUT: %Function: %Function.type.b68 = struct_value () [concrete]
// CHECK:STDOUT: %Function.type.186: type = facet_type <@Function.loc9> [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
// CHECK:STDOUT: .Function = %Function.decl.loc4
// CHECK:STDOUT: }
// CHECK:STDOUT: %Function.decl.loc4: %Function.type.b68 = fn_decl @Function.loc4 [concrete = constants.%Function] {} {}
// CHECK:STDOUT: %Function.decl.loc9: type = interface_decl @Function.loc9 [concrete = constants.%Function.type.186] {} {}
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: interface @Function.loc9;
// CHECK:STDOUT:
// CHECK:STDOUT: fn @Function.loc4();
// CHECK:STDOUT:
// CHECK:STDOUT: --- fail_name_conflict_with_class.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %Class: type = class_type @Class.loc2 [concrete]
// CHECK:STDOUT: %Class.type: type = facet_type <@Class.loc7> [concrete]
// CHECK:STDOUT: %Self: %Class.type = symbolic_binding Self, 0 [symbolic]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
// CHECK:STDOUT: .Class = %Class.decl.loc2
// CHECK:STDOUT: }
// CHECK:STDOUT: %Class.decl.loc2: type = class_decl @Class.loc2 [concrete = constants.%Class] {} {}
// CHECK:STDOUT: %Class.decl.loc7: type = interface_decl @Class.loc7 [concrete = constants.%Class.type] {} {}
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: interface @Class.loc7 {
// CHECK:STDOUT: %Self: %Class.type = symbolic_binding Self, 0 [symbolic = constants.%Self]
// CHECK:STDOUT: %Class.WithSelf.decl = interface_with_self_decl @Class.loc7 [concrete]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = %Self
// CHECK:STDOUT: witness = ()
// CHECK:STDOUT:
// CHECK:STDOUT: !requires:
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: class @Class.loc2;
// CHECK:STDOUT:
// CHECK:STDOUT: specific @Class.WithSelf(constants.%Self) {}
// CHECK:STDOUT:
Reference in new issue View Git Blame Copy Permalink