mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 14:48:10 +00:00
Chandler Carruth
2c9739799b
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
207 lines
5.9 KiB
Plaintext
207 lines
5.9 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/eval_musteval.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/eval_musteval.carbon
|
|
|
|
// --- interface.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Runtime {
|
|
fn F(self) -> type;
|
|
}
|
|
|
|
interface Eval {
|
|
eval fn F(self) -> type;
|
|
}
|
|
|
|
interface MustEval {
|
|
musteval fn F(self) -> type;
|
|
}
|
|
|
|
// --- impl_runtime.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class A { adapt {}; }
|
|
|
|
impl A as Runtime {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as Eval {
|
|
// TODO: Consider rejecting this, as compile-time evaluation would always
|
|
// fail.
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as MustEval {
|
|
// TODO: Consider rejecting this, as compile-time evaluation would always
|
|
// fail.
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
fn Call() {
|
|
({} as A).(Runtime.F)();
|
|
({} as A).(Eval.F)();
|
|
({} as A).(MustEval.F)();
|
|
}
|
|
|
|
// --- fail_impl_runtime_eval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class A { adapt {}; }
|
|
|
|
impl A as Runtime {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as Eval {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as MustEval {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
fn Call() {
|
|
// CHECK:STDERR: fail_impl_runtime_eval.carbon:[[@LINE+2]]:17-39: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR:
|
|
let unused t: ({} as A).(Runtime.F)() = {} as A;
|
|
// CHECK:STDERR: fail_impl_runtime_eval.carbon:[[@LINE+2]]:17-36: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR:
|
|
let unused u: ({} as A).(Eval.F)() = {} as A;
|
|
// CHECK:STDERR: fail_impl_runtime_eval.carbon:[[@LINE+2]]:17-40: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR:
|
|
let unused v: ({} as A).(MustEval.F)() = {} as A;
|
|
}
|
|
|
|
// --- impl_eval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class A { adapt {}; }
|
|
|
|
impl A as Runtime {
|
|
eval fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as Eval {
|
|
eval fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as MustEval {
|
|
eval fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
fn Call() {
|
|
// TODO: Should we allow calling this at compile time? This is not allowed if
|
|
// we generate a thunk; see the next split for an example.
|
|
let unused t: ({} as A).(Runtime.F)() = {} as A;
|
|
let unused u: ({} as A).(Eval.F)() = {} as A;
|
|
let unused v: ({} as A).(MustEval.F)() = {} as A;
|
|
}
|
|
|
|
// --- fail_todo_impl_eval_from_runtime_thunk.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B {}
|
|
|
|
class BView {}
|
|
impl B as Core.ImplicitAs(BView) {
|
|
fn Convert(unused self) -> BView { return {}; }
|
|
}
|
|
|
|
impl B as Runtime {
|
|
eval fn F(unused self: BView) -> type { return B; }
|
|
}
|
|
|
|
fn Call() {
|
|
// TODO: Should we allow calling this at compile time? This is allowed if we
|
|
// don't generate a thunk.
|
|
// CHECK:STDERR: fail_todo_impl_eval_from_runtime_thunk.carbon:[[@LINE+2]]:17-39: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR:
|
|
let unused t: ({} as B).(Runtime.F)() = {} as B;
|
|
}
|
|
|
|
// --- fail_impl_musteval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B { adapt {}; }
|
|
|
|
impl B as Runtime {
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+5]]:3-38: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+4]]:3-38: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
|
|
// CHECK:STDERR: imported from: fail_impl_musteval.carbon:[[@LINE-7]]:1 [InImport]
|
|
// CHECK:STDERR: interface.carbon:5:3-21: note: while building thunk to match the signature of this function [ThunkSignature]
|
|
// CHECK:STDERR:
|
|
musteval fn F(unused self) -> type { return B; }
|
|
}
|
|
|
|
impl B as Eval {
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+5]]:3-38: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+4]]:3-38: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
|
|
// CHECK:STDERR: imported from: fail_impl_musteval.carbon:[[@LINE-16]]:1 [InImport]
|
|
// CHECK:STDERR: interface.carbon:9:3-26: note: while building thunk to match the signature of this function [ThunkSignature]
|
|
// CHECK:STDERR:
|
|
musteval fn F(unused self) -> type { return B; }
|
|
}
|
|
|
|
// --- impl_musteval_from_musteval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B { adapt {}; }
|
|
|
|
impl B as MustEval {
|
|
musteval fn F(unused self) -> type { return B; }
|
|
}
|
|
|
|
fn Call() {
|
|
let unused t: ({} as B).(MustEval.F)() = {} as B;
|
|
}
|
|
|
|
// --- fail_todo_impl_musteval_from_musteval_thunk.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B {}
|
|
|
|
class BView {}
|
|
impl B as Core.ImplicitAs(BView) {
|
|
fn Convert(unused self) -> BView { return {}; }
|
|
}
|
|
|
|
impl B as MustEval {
|
|
// CHECK:STDERR: fail_todo_impl_musteval_from_musteval_thunk.carbon:[[@LINE+5]]:3-45: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
|
|
// CHECK:STDERR: fail_todo_impl_musteval_from_musteval_thunk.carbon:[[@LINE+4]]:3-45: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
|
|
// CHECK:STDERR: imported from: fail_todo_impl_musteval_from_musteval_thunk.carbon:[[@LINE-12]]:1 [InImport]
|
|
// CHECK:STDERR: interface.carbon:13:3-30: note: while building thunk to match the signature of this function [ThunkSignature]
|
|
// CHECK:STDERR:
|
|
musteval fn F(unused self: BView) -> type { return B; }
|
|
}
|