Files
carbon-lang/toolchain/sem_ir/name_scope.cpp
T
Boaz Brickner 23e5677c8e Avoid poisoning non identifier names (#4884)
There are different use cases where we call
`Context::LookupQualifiedName()` on non identifiers, like
`NameId::SelfType`, which implicitly triggers poisoning these names. I
don't think poisoning non identifiers like`Self` is ever useful.

Use cases where `Self` is being poisoned:
* Checking allowed access:
https://github.com/carbon-language/carbon-lang/blob/e257051612e4217295e206fd3274fc75e22d206a/toolchain/check/member_access.cpp#L62,
for example, in
https://github.com/carbon-language/carbon-lang/blob/e257051612e4217295e206fd3274fc75e22d206a/toolchain/check/testdata/alias/no_prelude/fail_aliased_name_in_diag.carbon#L21
* Using the type `Self` as a parameter type:
https://github.com/carbon-language/carbon-lang/blob/e257051612e4217295e206fd3274fc75e22d206a/core/prelude/operators/arithmetic.carbon#L78

Part of #4622.
2025-02-13 20:00:54 +00:00

102 lines
3.0 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/sem_ir/name_scope.h"
#include "toolchain/sem_ir/file.h"
namespace Carbon::SemIR {
auto NameScope::Print(llvm::raw_ostream& out) const -> void {
out << "{inst: " << inst_id_ << ", parent_scope: " << parent_scope_id_
<< ", has_error: " << (has_error_ ? "true" : "false");
out << ", extended_scopes: [";
llvm::ListSeparator scope_sep;
for (auto id : extended_scopes_) {
out << scope_sep << id;
}
out << "]";
out << ", names: {";
llvm::ListSeparator sep;
for (auto entry : names_) {
if (entry.result.is_poisoned()) {
continue;
}
out << sep << entry.name_id << ": " << entry.result.target_inst_id();
}
out << "}";
out << "}";
}
auto NameScope::AddRequired(Entry name_entry) -> void {
CARBON_CHECK(!name_entry.result.is_poisoned(),
"Cannot add a poisoned name: {0}.", name_entry.name_id);
auto add_name = [&] {
EntryId index(names_.size());
names_.push_back(name_entry);
return index;
};
auto result = name_map_.Insert(name_entry.name_id, add_name);
if (!result.is_inserted()) {
// A required name can overwrite poison.
auto& name = names_[result.value().index];
CARBON_CHECK(name.result.is_poisoned(), "Failed to add required name: {0}",
name_entry.name_id);
name = name_entry;
}
}
auto NameScope::LookupOrAdd(NameId name_id, InstId inst_id,
AccessKind access_kind)
-> std::pair<bool, EntryId> {
auto insert_result = name_map_.Insert(name_id, EntryId(names_.size()));
if (!insert_result.is_inserted()) {
return {false, EntryId(insert_result.value())};
}
names_.push_back({.name_id = name_id,
.result = ScopeLookupResult::MakeWrappedLookupResult(
inst_id, access_kind)});
return {true, EntryId(names_.size() - 1)};
}
auto NameScope::LookupOrPoison(LocId loc_id, NameId name_id)
-> std::optional<EntryId> {
if (!name_id.AsIdentifierId().has_value()) {
return Lookup(name_id);
}
auto insert_result = name_map_.Insert(name_id, EntryId(names_.size()));
if (insert_result.is_inserted()) {
names_.push_back({.name_id = name_id,
.result = ScopeLookupResult::MakePoisoned(loc_id)});
return std::nullopt;
}
return insert_result.value();
}
auto NameScopeStore::GetInstIfValid(NameScopeId scope_id) const
-> std::pair<InstId, std::optional<Inst>> {
if (!scope_id.has_value()) {
return {InstId::None, std::nullopt};
}
auto inst_id = Get(scope_id).inst_id();
if (!inst_id.has_value()) {
return {InstId::None, std::nullopt};
}
return {inst_id, file_->insts().Get(inst_id)};
}
auto NameScopeStore::IsCorePackage(NameScopeId scope_id) const -> bool {
if (!IsPackage(scope_id)) {
return false;
}
return Get(scope_id).name_id() == NameId::Core;
}
} // namespace Carbon::SemIR