mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Dana JansensandJon Ross-Perkins
315e206ff1
Remove calls to `InstStore::GetLocId()` to build a LocId from an InstId now that they can be constructed directly from the InstId. Most uses of LocId are just plumbing, so this does not affect them. However places that want to look inside the LocId do not want to work with the InstId form. In these places, introduce `InstStore::GetResolvedLocId()` which converts a LocId (or an InstId as an optimization) into a LocId which is not backed by an InstId. These locations can be printed (they have a line and column when they are a NodeId), they can have flags added to them (`ToImplicit`, `ToTokenOnly`), they can be converted to an underlying ImportIRInstId, or they may be `None`. `Dump()` is made to print a resolved location instead of printing the InstId in the location, since (at least in my experience) the resolved location is what is interesting in debugging, and this saves manual `MakeInstId` steps in the debugger every time a location is of interest. The LocId constructor from InstId is made `explicit` to add clarity to function calls passing an `inst_id` now directly instead of calling `context.insts().GetLocId(inst_id)`. To avoid needing to construct `SemIR::LocId(...)` explicitly in all cases though, the diagnostics code in Check uses `DiagnosticLocId` as its template parameter which accepts InstId as well and does the construction of LocId from it. Because LocId now requires an explicit construction from InstId, any callers to `AddInst()` functions will have to explicitly convert to LocId if they had an InstId, but not if they pass a NodeId. To make this difference clear to callers, we `requires` that the input type can be converted to LocId. This ensures that passing an InstId results in an error at the callsite where the InstId is passed, instead of generating a compiler error when trying to construct `LocIdAndInst` inside `AddInst()`, which is less clear about what went wrong and doesn't seem entirely intentional. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
32 lines
1.1 KiB
C++
32 lines
1.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/convert.h"
|
|
#include "toolchain/check/handle.h"
|
|
#include "toolchain/sem_ir/inst.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
// TODO: Find a better home for this. We'll likely need it for more than just
|
|
// expression statements.
|
|
static auto HandleDiscardedExpr(Context& context, SemIR::InstId expr_id)
|
|
-> void {
|
|
// If we discard an initializing expression, convert it to a value or
|
|
// reference so that it has something to initialize.
|
|
auto expr = context.insts().Get(expr_id);
|
|
Convert(context, SemIR::LocId(expr_id), expr_id,
|
|
{.kind = ConversionTarget::Discarded, .type_id = expr.type_id()});
|
|
|
|
// TODO: This will eventually need to do some "do not discard" analysis.
|
|
}
|
|
|
|
auto HandleParseNode(Context& context, Parse::ExprStatementId /*node_id*/)
|
|
-> bool {
|
|
HandleDiscardedExpr(context, context.node_stack().PopExpr());
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|