carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
30f0ddab71bda71f8789080962b1fe8a5938e327
carbon-lang/toolchain/check
T
History
Boaz Brickner 30f0ddab71 Add support for importing access from C++ to Carbon (#5858) 
Better access control with inheritance should come with better
inheritance support (actually importing inheritance).

C++ Interop Demo:

```c++
// hello_world.h

class HelloWorld {
 public:
  static auto Pub() -> void;

 protected:
  static auto Pro() -> void;

 private:
  static auto Pri() -> void;
};
```

```c++
// hello_world.cpp

#include "hello_world.h"

#include <cstdio>

auto HelloWorld::Pub() -> void { printf("Public!\n"); }
auto HelloWorld::Pro() -> void { printf("Protected!\n"); }
auto HelloWorld::Pri() -> void { printf("Private!\n"); }
```

```carbon
// main.carbon

library "Main";

import Cpp library "hello_world.h";

fn Run() -> i32 {
  Cpp.HelloWorld.Pub();
  Cpp.HelloWorld.Pro();
  Cpp.HelloWorld.Pri();
  return 0;
}
```

```shell
$ clang -c hello_world.cpp
$ bazel-bin/toolchain/carbon compile main.carbon
main.carbon:9:3: error: cannot access protected member `Pro` of type `Cpp.HelloWorld`
  Cpp.HelloWorld.Pro();
  ^~~~~~~~~~~~~~~~~~
main.carbon: note: declared here

main.carbon:10:3: error: cannot access private member `Pri` of type `Cpp.HelloWorld`
  Cpp.HelloWorld.Pri();
  ^~~~~~~~~~~~~~~~~~
main.carbon: note: declared here
```

Before this change (no access checks):
```shell
$ bazel-bin/toolchain/carbon compile main.carbon
$ bazel-bin/toolchain/carbon link hello_world.o main.o --output=demo
$ ./demo
Public!
Protected!
Private!
```

Part of #5859.
2025-07-29 08:25:15 +00:00
..
fuzzer_corpus
Change array syntax from [T; N] to array(T, N) (#4981)
2025-02-20 22:42:47 +00:00
testdata
Add support for importing access from C++ to Carbon (#5858)
2025-07-29 08:25:15 +00:00
action.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
action.h
Even more usage of TypeInstId (#5296)
2025-04-11 21:47:43 +00:00
BUILD
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
call.cpp
When making a direct call to a thunk, inline the call in SemIR. (#5642)
2025-06-11 21:34:01 +00:00
call.h
Use As and ImplicitAs interfaces for conversions. (#4209)
2024-09-05 23:39:58 +00:00
check_fuzzer.cpp
Switch Driver back to parameters for construction (#4849)
2025-01-27 23:48:44 +00:00
check_unit.cpp
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
check_unit.h
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
check.cpp
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
check.h
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
class.cpp
Ensure vtable entries for generics are attached constants (#5853)
2025-07-28 21:06:57 +00:00
class.h
Vtable support for generics (#5793)
2025-07-11 22:29:10 +00:00
context.cpp
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
context.h
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
control_flow.cpp
Tag destruction as desugaring (#5790)
2025-07-10 21:21:19 +00:00
control_flow.h
Handle destruction for return statements (#5785)
2025-07-10 16:32:39 +00:00
convert.cpp
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
convert.h
Clean up some TODO and other comments (#5813)
2025-07-17 18:58:34 +00:00
decl_introducer_state.h
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
decl_name_stack.cpp
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
decl_name_stack.h
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
deduce.cpp
Avoid deducing errors as argument instructions after subst (#5710)
2025-06-23 23:10:33 +00:00
deduce.h
Fearlessly hold references into ValueStore again (#5589)
2025-06-03 18:07:23 +00:00
deferred_definition_worklist.cpp
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
deferred_definition_worklist.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
diagnostic_emitter.cpp
Improve backtrace for lowering crashes. (#5651)
2025-06-16 23:21:22 +00:00
diagnostic_emitter.h
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
diagnostic_helpers.h
Move TokenOnly to LocIdForDiagnostics (#5590)
2025-06-03 01:14:54 +00:00
dump.cpp
Move LocId dumping to semir/ (#5656)
2025-06-12 20:37:27 +00:00
eval_inst.cpp
Ignore abstract functions when checking for referenced functions requiring definitions (#5816)
2025-07-17 20:25:59 +00:00
eval_inst.h
Support for lowering references to imported vars. (#5513)
2025-05-29 19:48:16 +00:00
eval.cpp
Change CanonicalValueStore to take ValueT and KeyT as parameters (#5759)
2025-07-02 20:58:02 +00:00
eval.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
facet_type.cpp
Avoid incorrect conflicting assignment diags in rewrite constraints (#5686)
2025-06-18 01:10:26 +00:00
facet_type.h
Nested facets (#5644)
2025-06-12 22:06:12 +00:00
full_pattern_stack.h
Clean up handling of Call params (#5061)
2025-03-04 21:01:59 +00:00
function.cpp
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
function.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
generic_region_stack.cpp
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
generic_region_stack.h
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
generic.cpp
Add missing standard library header inclusions (#5486)
2025-05-28 22:48:20 +00:00
generic.h
Avoid resolving the decl block for specifics in imported instructions (#5517)
2025-05-23 16:58:46 +00:00
global_init.cpp
[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)
2025-03-18 23:49:24 +00:00
global_init.h
Split global init out from InstBlockStack. (#4101)
2024-07-03 17:49:47 +00:00
handle_alias.cpp
Stop pushing a fake generic for the duration of check. (#5326)
2025-04-17 21:58:37 +00:00
handle_array.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_binding_pattern.cpp
Move TokenOnly to LocIdForDiagnostics (#5590)
2025-06-03 01:14:54 +00:00
handle_call_expr.cpp
Include the call arguments in the location of a call. (#4602)
2024-12-02 18:51:44 +00:00
handle_choice.cpp
Fearlessly hold references into ValueStore again (#5589)
2025-06-03 18:07:23 +00:00
handle_class.cpp
Vtable support for generics (#5793)
2025-07-11 22:29:10 +00:00
handle_codeblock.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_export.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_expr_statement.cpp
Convert discarded calls in thunks. (#5452)
2025-05-09 16:35:28 +00:00
handle_file.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_function.cpp
Diagnose impl method without matching virtual function in base class (#5817)
2025-07-18 19:03:06 +00:00
handle_if_expr.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_if_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_impl.cpp
Factor out an impl declaration helper function (#5851)
2025-07-25 18:34:07 +00:00
handle_import_and_package.cpp
Implement #4864: Core is a keyword (#4909)
2025-02-11 21:33:57 +00:00
handle_index.cpp
Make pointers in ValueStore stable across insertions (#5576)
2025-06-02 19:16:31 +00:00
handle_interface.cpp
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
handle_let_and_var.cpp
Check and lowering support for for loops. (#5698)
2025-06-25 23:45:14 +00:00
handle_literal.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
handle_loop_statement.cpp
Check and lowering support for for loops. (#5698)
2025-06-25 23:45:14 +00:00
handle_match.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_modifier.cpp
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
handle_name.cpp
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
handle_named_constraint.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_namespace.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_noop.cpp
Abort checking when encountering an invalid parse node (#4700)
2024-12-18 00:19:12 +00:00
handle_operator.cpp
Clean up some TODO and other comments (#5813)
2025-07-17 18:58:34 +00:00
handle_paren_expr.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_pattern_list.cpp
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
handle_return_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_struct.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_tuple_literal.cpp
Remove all remaining uses of TypeIds as instruction operands. (#5280)
2025-04-10 20:53:42 +00:00
handle_where.cpp
Make the .Self entity name in a WhereExpr a canonical one (#5827)
2025-07-18 20:42:16 +00:00
handle.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
impl_lookup.cpp
Add comment to FindAssociatedImportIRs (#5840)
2025-07-23 16:55:13 +00:00
impl_lookup.h
Diagnose impls that are fully overlapped by a final impl (#5417)
2025-05-10 17:36:28 +00:00
impl_validation.cpp
Fearlessly hold references into ValueStore again (#5589)
2025-06-03 18:07:23 +00:00
impl_validation.h
Add diagnostics for invalid impl declarations (#5420)
2025-05-22 18:58:47 +00:00
impl.cpp
Factor out an impl declaration helper function (#5851)
2025-07-25 18:34:07 +00:00
impl.h
Factor out an impl declaration helper function (#5851)
2025-07-25 18:34:07 +00:00
import_cpp.cpp
Add support for importing access from C++ to Carbon (#5858)
2025-07-29 08:25:15 +00:00
import_cpp.h
Add support for importing access from C++ to Carbon (#5858)
2025-07-29 08:25:15 +00:00
import_ref.cpp
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
import_ref.h
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
import.cpp
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
import.h
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
inst_block_stack.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
inst_block_stack.h
Split SemIR's formatter class into a more typical h+cpp (#5372)
2025-04-29 18:00:07 +00:00
inst.cpp
Change from ToImplicit to AsDesugared (#5591)
2025-06-03 17:55:16 +00:00
inst.h
Fix a small implicit/desugared reference (#5791)
2025-07-10 18:27:28 +00:00
interface.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
interface.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
keyword_modifier_set.h
Clean up KeywordModifierSet after #5345 (#5425)
2025-05-06 16:56:06 +00:00
lexical_lookup.h
Set an explicit size for lexical lookup's vector (#5786)
2025-07-09 22:42:27 +00:00
literal.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
literal.h
Factor out machinery for forming int type literals. (#4616)
2024-12-03 18:46:27 +00:00
member_access.cpp
Gracefully error in non-compound member lookup into a runtime facet value (#5485)
2025-05-15 16:25:53 +00:00
member_access.h
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
merge.cpp
Support importing var parameters (#5400)
2025-05-19 22:50:16 +00:00
merge.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
modifiers.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
modifiers.h
Refactor modifier formatting to remove string passing. (#4418)
2024-10-17 22:47:40 +00:00
name_component.cpp
Fix parse support for 'fn F[];' (#5135)
2025-03-18 00:31:17 +00:00
name_component.h
Id::Invalid -> Id::None (#4834)
2025-01-22 23:15:00 +00:00
name_lookup.cpp
Add support for importing access from C++ to Carbon (#5858)
2025-07-29 08:25:15 +00:00
name_lookup.h
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
name_ref.cpp
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
name_ref.h
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
node_id_traversal.cpp
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
node_id_traversal.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
node_stack.cpp
Avoid redundantly specifying Id::Kind. (#4911)
2025-02-07 22:35:18 +00:00
node_stack.h
Check and lowering support for for loops. (#5698)
2025-06-25 23:45:14 +00:00
operator.cpp
Change from ToImplicit to AsDesugared (#5591)
2025-06-03 17:55:16 +00:00
operator.h
Move diagnostic usings off Context (#5007)
2025-02-26 18:44:36 +00:00
param_and_arg_refs_stack.h
Consolidate post-check logic (#5003)
2025-02-25 02:07:43 +00:00
pattern_match.cpp
Fix tuple patterns matching expressions with atomic tuple form. (#5697)
2025-06-23 22:09:29 +00:00
pattern_match.h
Invalid comment cleanup (#4836)
2025-01-23 02:21:48 +00:00
pattern.cpp
Check and lowering support for for loops. (#5698)
2025-06-25 23:45:14 +00:00
pattern.h
Check and lowering support for for loops. (#5698)
2025-06-25 23:45:14 +00:00
pending_block.h
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
pointer_dereference.cpp
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
pointer_dereference.h
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
region_stack.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
return.cpp
Handle destruction for return statements (#5785)
2025-07-10 16:32:39 +00:00
return.h
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
scope_index.h
Move None to IdBase (#5030)
2025-03-01 08:00:17 +00:00
scope_stack.cpp
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
scope_stack.h
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
subst.cpp
Abandon SubstInst when encountering ErrorInst (#5692)
2025-06-18 21:33:18 +00:00
subst.h
Resolve the RHS of rewrite constraints in facets (#5639)
2025-06-11 21:11:00 +00:00
thunk.cpp
When making a direct call to a thunk, inline the call in SemIR. (#5642)
2025-06-11 21:34:01 +00:00
thunk.h
When making a direct call to a thunk, inline the call in SemIR. (#5642)
2025-06-11 21:34:01 +00:00
type_completion.cpp
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
type_completion.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
type_structure.cpp
Add diagnostics for invalid impl declarations (#5420)
2025-05-22 18:58:47 +00:00
type_structure.h
Add diagnostics for invalid impl declarations (#5420)
2025-05-22 18:58:47 +00:00
type.cpp
Support for importing const-qualified types from C++. (#5794)
2025-07-12 02:22:24 +00:00
type.h
Support for importing const-qualified types from C++. (#5794)
2025-07-12 02:22:24 +00:00