mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
54 lines
1.5 KiB
C++
54 lines
1.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/diagnostics/diagnostic_consumer.h"
|
|
|
|
#include <algorithm>
|
|
#include <cstdint>
|
|
|
|
namespace Carbon::Diagnostics {
|
|
|
|
auto StreamConsumer::HandleDiagnostic(Diagnostic diagnostic) -> void {
|
|
if (printed_diagnostic_) {
|
|
*stream_ << "\n";
|
|
} else {
|
|
printed_diagnostic_ = true;
|
|
}
|
|
|
|
for (const auto& message : diagnostic.messages) {
|
|
message.loc.FormatLocation(*stream_);
|
|
switch (message.level) {
|
|
case Level::Error:
|
|
*stream_ << "error: ";
|
|
break;
|
|
case Level::Warning:
|
|
*stream_ << "warning: ";
|
|
break;
|
|
case Level::Note:
|
|
*stream_ << "note: ";
|
|
break;
|
|
case Level::LocationInfo:
|
|
break;
|
|
}
|
|
*stream_ << message.Format();
|
|
if (include_diagnostic_kind_) {
|
|
*stream_ << " [" << message.kind << "]";
|
|
}
|
|
*stream_ << "\n";
|
|
// Don't include a snippet for location information to keep this diagnostic
|
|
// more visually associated with the following diagnostic that it describes
|
|
// and to better match C++ compilers.
|
|
if (message.level != Level::LocationInfo) {
|
|
message.loc.FormatSnippet(*stream_);
|
|
}
|
|
}
|
|
}
|
|
|
|
auto ConsoleConsumer() -> Consumer& {
|
|
static auto* consumer = new StreamConsumer(&llvm::errs());
|
|
return *consumer;
|
|
}
|
|
|
|
} // namespace Carbon::Diagnostics
|