mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:10:13 +01:00
Chandler Carruth
8be274cf60
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
79 lines
2.7 KiB
C++
79 lines
2.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/parse/context.h"
|
|
#include "toolchain/parse/handle.h"
|
|
|
|
namespace Carbon::Parse {
|
|
|
|
static auto ExpectAsOrTypeExpression(Context& context) -> void {
|
|
if (context.PositionIs(Lex::TokenKind::As)) {
|
|
// as <expression> ...
|
|
context.AddLeafNode(NodeKind::ImplDefaultSelfAs, context.Consume());
|
|
context.PushState(StateKind::Expr);
|
|
} else {
|
|
// <expression> as <expression>...
|
|
context.PushState(StateKind::ImplBeforeAs);
|
|
context.PushStateForExpr(PrecedenceGroup::ForImplAs());
|
|
}
|
|
}
|
|
|
|
auto HandleImplAfterIntroducer(Context& context) -> void {
|
|
auto state = context.PopState();
|
|
state.kind = StateKind::DeclOrDefinitionAsImpl;
|
|
context.PushState(state);
|
|
|
|
if (context.PositionIs(Lex::TokenKind::Forall)) {
|
|
// forall [<implicit parameter list>] ...
|
|
context.PushState(StateKind::ImplAfterForall);
|
|
context.AddLeafNode(NodeKind::Forall, context.Consume());
|
|
if (context.PositionIs(Lex::TokenKind::OpenSquareBracket)) {
|
|
context.PushState(StateKind::PatternListAsImplicit, *context.position(),
|
|
BindingContext::DeducedParam);
|
|
} else {
|
|
CARBON_DIAGNOSTIC(ImplExpectedAfterForall, Error,
|
|
"expected `[` after `forall` in `impl` declaration");
|
|
context.emitter().Emit(*context.position(), ImplExpectedAfterForall);
|
|
context.ReturnErrorOnState();
|
|
// If we aren't producing a node from the PatternListAsImplicit state,
|
|
// we still need to create a node to be the child of the `ImplForall`
|
|
// token created in the `ImplAfterForall` state.
|
|
context.AddInvalidParse(*context.position());
|
|
}
|
|
} else {
|
|
// One of:
|
|
// as <expression> ...
|
|
// <expression> as <expression>...
|
|
ExpectAsOrTypeExpression(context);
|
|
}
|
|
}
|
|
|
|
auto HandleImplAfterForall(Context& context) -> void {
|
|
auto state = context.PopState();
|
|
if (state.has_error) {
|
|
context.ReturnErrorOnState();
|
|
}
|
|
// One of:
|
|
// as <expression> ...
|
|
// <expression> as <expression>...
|
|
ExpectAsOrTypeExpression(context);
|
|
}
|
|
|
|
auto HandleImplBeforeAs(Context& context) -> void {
|
|
auto state = context.PopState();
|
|
if (auto as = context.ConsumeIf(Lex::TokenKind::As)) {
|
|
context.AddNode(NodeKind::ImplTypeAs, *as, state.has_error);
|
|
context.PushState(StateKind::Expr);
|
|
} else {
|
|
if (!state.has_error) {
|
|
CARBON_DIAGNOSTIC(ImplExpectedAs, Error,
|
|
"expected `as` in `impl` declaration");
|
|
context.emitter().Emit(*context.position(), ImplExpectedAs);
|
|
}
|
|
context.ReturnErrorOnState();
|
|
}
|
|
}
|
|
|
|
} // namespace Carbon::Parse
|