mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 16:46:02 +01:00
Jon Ross-Perkins
2de746e83c
I've been mulling this mainly for the parameter complexity of check/lower, but doing lex/parse for symmetry. I'm motivated by the plan to move dumping for all of them into the respective functions, because of discussion about llvm-verifier. That basically would add another bool parameter (or more) to each of these. My instinct is we're going to probably accrue a little more over time, so I'm suggesting this as maybe adding the boundary a little simpler and/or easier to read. Note it may make sense to refactor a little further, e.g. maybe Lower::Context could receive the full set of options and pick out what it wants, but I figured creating the struct itself would be a decent start. I'm trying to put things into options when we can produce a reasonable default if the user doesn't assign a value. I'm using an explicit constructor so that values can be added without affecting every caller. A different factoring would be to pass in everything through the param struct, but that just felt weird when I was trying it out. Removing `inst_namer` and `module_name` from `LowerToLLVM` params -- both of these can be inferred from `sem_ir`, and I'm not seeing a particular reason to maintain them at the call site.
34 lines
1.1 KiB
C++
34 lines
1.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/lower/lower.h"
|
|
|
|
#include <memory>
|
|
#include <optional>
|
|
|
|
#include "toolchain/lower/context.h"
|
|
#include "toolchain/lower/file_context.h"
|
|
|
|
namespace Carbon::Lower {
|
|
|
|
auto LowerToLLVM(
|
|
llvm::LLVMContext& llvm_context,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> fs,
|
|
llvm::ArrayRef<Parse::GetTreeAndSubtreesFn> tree_and_subtrees_getters,
|
|
const SemIR::File& sem_ir, const LowerToLLVMOptions& options)
|
|
-> std::unique_ptr<llvm::Module> {
|
|
Context context(llvm_context, std::move(fs), options.want_debug_info,
|
|
tree_and_subtrees_getters, sem_ir.filename(),
|
|
options.vlog_stream);
|
|
|
|
// TODO: Consider disabling instruction naming by default if we're not
|
|
// producing textual LLVM IR.
|
|
SemIR::InstNamer inst_namer(&sem_ir);
|
|
context.GetFileContext(&sem_ir, &inst_namer).LowerDefinitions();
|
|
|
|
return std::move(context).Finalize(options.llvm_verifier_stream);
|
|
}
|
|
|
|
} // namespace Carbon::Lower
|