mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-10 12:28:25 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
146 lines
5.7 KiB
C++
146 lines
5.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/cpp/location.h"
|
|
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/Basic/SourceManager.h"
|
|
#include "toolchain/lex/tokenized_buffer.h"
|
|
#include "toolchain/sem_ir/absolute_node_ref.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
namespace {
|
|
struct FileInfo {
|
|
const SemIR::File* sem_ir;
|
|
clang::SourceLocation start_loc;
|
|
};
|
|
} // namespace
|
|
|
|
// Map a CheckIRId into information about the corresponding file in both SemIR
|
|
// and Clang's source manager.
|
|
static auto GetFileInfo(Context& context, SemIR::CheckIRId ir_id) -> FileInfo {
|
|
const SemIR::File* sem_ir = &context.sem_ir();
|
|
int file_index = 0;
|
|
|
|
// If the file is imported, locate it in our imports map.
|
|
if (ir_id != context.sem_ir().check_ir_id()) {
|
|
auto import_id = context.check_ir_map().Get(ir_id);
|
|
CARBON_CHECK(import_id.has_value());
|
|
file_index = context.import_irs().GetRawIndex(import_id) + 1;
|
|
|
|
sem_ir = context.import_irs().Get(import_id).sem_ir;
|
|
CARBON_CHECK(sem_ir, "Node location in nonexistent IR");
|
|
}
|
|
|
|
// If we've seen this file before, reuse the same FileID.
|
|
auto& file_start_locs = context.cpp_context()->carbon_file_locations();
|
|
if (static_cast<int>(file_start_locs.size()) <= file_index) {
|
|
// Never valid; prepare a slot for the caching below.
|
|
file_start_locs.resize(file_index + 1);
|
|
} else if (file_start_locs[file_index].isValid()) {
|
|
return {.sem_ir = sem_ir, .start_loc = file_start_locs[file_index]};
|
|
}
|
|
|
|
// We've not seen this file before. Create a corresponding virtual file in
|
|
// Clang's source manager.
|
|
// TODO: Consider recreating the complete import path instead of only the
|
|
// final entry.
|
|
const auto& source = sem_ir->parse_tree().tokens().source();
|
|
auto& src_mgr = context.ast_context().getSourceManager();
|
|
auto file_id = src_mgr.createFileID(
|
|
llvm::MemoryBufferRef(source.text(), source.filename()));
|
|
auto file_start_loc = src_mgr.getLocForStartOfFile(file_id);
|
|
file_start_locs[file_index] = file_start_loc;
|
|
return {.sem_ir = sem_ir, .start_loc = file_start_loc};
|
|
}
|
|
|
|
auto GetCppLocation(Context& context, SemIR::LocId loc_id)
|
|
-> clang::SourceLocation {
|
|
if (!context.sem_ir().cpp_file()) {
|
|
return clang::SourceLocation();
|
|
}
|
|
|
|
// Break down the `LocId` into an import path. If that ends in a C++ location,
|
|
// we can just return that directly.
|
|
llvm::SmallVector<SemIR::AbsoluteNodeRef> absolute_node_refs =
|
|
SemIR::GetAbsoluteNodeRef(&context.sem_ir(), loc_id);
|
|
const auto& final_node = absolute_node_refs.back();
|
|
if (final_node.is_cpp()) {
|
|
return final_node.file()
|
|
->clang_source_locs()
|
|
.Get(final_node.clang_source_loc_id())
|
|
.getBegin();
|
|
}
|
|
|
|
if (!final_node.node_id().has_value()) {
|
|
// A non-existent NodeID implies our C++ is compiler-synthesised. Synthetic
|
|
// code doesn't have a physical source location to retrieve, so the Clang
|
|
// mapping is empty.
|
|
return clang::SourceLocation();
|
|
}
|
|
|
|
// This is a location in Carbon code; get or create a corresponding file in
|
|
// Clang and build a corresponding location.
|
|
auto [ir, start_loc] = GetFileInfo(context, final_node.check_ir_id());
|
|
const auto& tree = ir->parse_tree();
|
|
auto offset =
|
|
tree.tokens().GetByteOffset(tree.node_token(final_node.node_id()));
|
|
return start_loc.getLocWithOffset(offset);
|
|
}
|
|
|
|
auto GetCppRange(Context& context, SemIR::LocId loc_id)
|
|
-> clang::CharSourceRange {
|
|
if (!context.sem_ir().cpp_file()) {
|
|
return clang::CharSourceRange();
|
|
}
|
|
|
|
llvm::SmallVector<SemIR::AbsoluteNodeRef> absolute_node_refs =
|
|
SemIR::GetAbsoluteNodeRef(&context.sem_ir(), loc_id);
|
|
const auto& final_node = absolute_node_refs.back();
|
|
if (final_node.is_cpp()) {
|
|
auto loc = GetCppLocation(context, loc_id);
|
|
return clang::CharSourceRange::getTokenRange(loc, loc);
|
|
}
|
|
if (!final_node.node_id().has_value()) {
|
|
return clang::CharSourceRange();
|
|
}
|
|
|
|
auto [ir, start_loc] = GetFileInfo(context, final_node.check_ir_id());
|
|
const auto& tokens = ir->parse_tree().tokens();
|
|
auto token = ir->parse_tree().node_token(final_node.node_id());
|
|
// Only the file being checked has its subtrees available, since a `Context`
|
|
// holds the one `TreeAndSubtrees`.
|
|
Lex::InclusiveTokenRange token_range = {.begin = token, .end = token};
|
|
if (final_node.check_ir_id() == context.sem_ir().check_ir_id()) {
|
|
token_range = context.parse_tree_and_subtrees().GetSubtreeTokenRange(
|
|
final_node.node_id());
|
|
}
|
|
return clang::CharSourceRange::getCharRange(
|
|
start_loc.getLocWithOffset(tokens.GetByteOffset(token_range.begin)),
|
|
start_loc.getLocWithOffset(tokens.GetByteOffset(token_range.end) +
|
|
tokens.GetTokenText(token_range.end).size()));
|
|
}
|
|
|
|
auto AddImportIRInst(SemIR::File& file, clang::CharSourceRange clang_range)
|
|
-> SemIR::ImportIRInstId {
|
|
// Stored as its two ends: every range reaching here is a character range, so
|
|
// `CharSourceRange`'s token-or-character bit would always say the same thing
|
|
// and cost a word to say it. Rebuilt as one where it is read.
|
|
CARBON_CHECK(!clang_range.isTokenRange(),
|
|
"A token range would lose which it was; widen it first.");
|
|
SemIR::ClangSourceLocId clang_source_loc_id =
|
|
file.clang_source_locs().Add(clang_range.getAsRange());
|
|
return file.import_ir_insts().Add(SemIR::ImportIRInst(clang_source_loc_id));
|
|
}
|
|
|
|
auto AddImportIRInst(SemIR::File& file, clang::SourceLocation clang_source_loc)
|
|
-> SemIR::ImportIRInstId {
|
|
return AddImportIRInst(file, clang::CharSourceRange::getCharRange(
|
|
clang_source_loc, clang_source_loc));
|
|
}
|
|
|
|
} // namespace Carbon::Check
|